From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oJ1NC8HP2GXMJgEAqHPOHw:P1 (envelope-from ) for ; Fri, 23 Feb 2024 18:02:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id oJ1NC8HP2GXMJgEAqHPOHw (envelope-from ) for ; Fri, 23 Feb 2024 18:02:57 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MwBZZXJF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708707777; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qhmvYIP6mcO0LSdcxbLZlwUEk/SMsxW/A8BcMkrnUuE=; b=fI06cNPfWx4kKDFcjgpIwskcr/biQx5SSySQMwLgIfne0vmA9jAGfCIM7LeX/cqTEED7Yz rV083whVf5XI/n/5kiu2UKmkqrwPSeauEXqsZFD2PrNW8e2XgseWPtqs7KaooV/2GTqdvR BZQvXalQHJfOHNLY62GIwqNUJ+gud2wv2wHi710xrNHOfHyGt2AWhK0cssPhgUdi04lMZO jvHOnKWCr+nghelXuvi5hp0XqS+UiJ+eagzhsSciI3gzsLsd9BfJ6s1ua6SO+9B7TM8UIR ZzZjy2jaV7yUcOkqVKUoJry5lbnwU/cKIk2BPrXzRGQVQoyN4IpbUzWk8tKo+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MwBZZXJF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708707777; a=rsa-sha256; cv=none; b=Av7jW5woVUhEAO/4poRfHtY0YPb9bAksK5++BcIXgsMzWc5cs62jFuJAvrOldAxnwcKkRm uTG6W+Mg3J89w2zjDEAvzR0aGiXO3xASzIQS2M1pRl11nD10kLwA2n0Ed1jpCYbH6ZHTQB XQ8r35GLnijZ8mZRcS/uLexRJk56Ue/0Uozl7G9q5KvIAO2vV30ZMpTMJTmV487gjR9JA3 4ScUJZ2z3D8YTMJUxdd64fY3xW19QimTbpa7lZ8f6/xPz4vi+FxwOKqZHE8kn3qlGvUDhZ rarbHh4YsKUblaY0aSDRyUZCgkKFdWbafKTNg36d6nQ5dsN1PJqmoBt5L6DSaA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1135A66CF4 for ; Fri, 23 Feb 2024 18:02:56 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdYtT-0005Ih-Ap; Fri, 23 Feb 2024 11:59:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYcG-0003BE-Vi for guix-patches@gnu.org; Fri, 23 Feb 2024 11:41:41 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdYcF-00010s-Fo for guix-patches@gnu.org; Fri, 23 Feb 2024 11:41:39 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdYcc-0004fZ-K9 for guix-patches@gnu.org; Fri, 23 Feb 2024 11:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69292] [PATCH 5/6] store: database: Refactor sqlite-register. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Feb 2024 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69292 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 69292@debbugs.gnu.org, Christopher Baines Received: via spool by 69292-submit@debbugs.gnu.org id=B69292.170870647517805 (code B ref 69292); Fri, 23 Feb 2024 16:42:02 +0000 Received: (at 69292) by debbugs.gnu.org; 23 Feb 2024 16:41:15 +0000 Received: from localhost ([127.0.0.1]:52597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYbq-0004d4-VJ for submit@debbugs.gnu.org; Fri, 23 Feb 2024 11:41:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYbm-0004c2-Sy for 69292@debbugs.gnu.org; Fri, 23 Feb 2024 11:41:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYU7-000884-UX; Fri, 23 Feb 2024 11:33:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=qhmvYIP6mcO0LSdcxbLZlwUEk/SMsxW/A8BcMkrnUuE=; b=MwBZZXJFRUFvg3ey5TUu 0WaR4mV+aYIvVtA+oXp5eFkPNX7gDQPwHwvpVXVktkYXiBtTNV/LABmBHikDWZjc0C8mD1GBigla5 CJJe153IAA0rsWqZCP7UVB/+8JcCQLf3f7mY3IQdetpXlp7PAsXNWIdgwwWFGgHkzeFxxD0trWl7n A8EyEIGMkabWpNMj48NVqZe31xLmwAOcSKCmyogfm2qridgV7s9zzrxWU3inp2Q/aOwJadptmOCuX XN3bWKaLYKnRTjsAH7qL36om97oHj4JZK/AYsqQDHZ3EFQlqDq44wumbJOMC5Our9kxbICM+m+tTJ 6yCoCOgsJEJEgQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <11b24242dd71349c09486341ed0d01b55f5f8f9a.1708457946.git.mail@cbaines.net> (Christopher Baines's message of "Tue, 20 Feb 2024 19:39:05 +0000") References: <4b6a268daab5e0b307dff2229d551a47c9fe1ebc.1708457946.git.mail@cbaines.net> <11b24242dd71349c09486341ed0d01b55f5f8f9a.1708457946.git.mail@cbaines.net> Date: Fri, 23 Feb 2024 17:33:13 +0100 Message-ID: <87cysnf8dy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -3.47 X-Spam-Score: -3.47 X-Migadu-Queue-Id: 1135A66CF4 X-TUID: S0ME1t+ndDMu Christopher Baines skribis: > The update-or-insert procedure name was unhelpfully generic, and these changes > should improve the code readability. > > * guix/store/database.scm (update-or-insert): Remove procedure and inline > functionality in to sqlite-register. > > Change-Id: Ifab0cdb7972d095460cc1f79b8b2f0e9b958059c LGTM.