From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id EDl+KXO23GVtbAAA62LTzQ:P1 (envelope-from ) for ; Mon, 26 Feb 2024 17:04:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id EDl+KXO23GVtbAAA62LTzQ (envelope-from ) for ; Mon, 26 Feb 2024 17:04:03 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=jHKLE1US; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708963443; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=H4UVTP+k0KJHSwLR7FOQq1GMytjdABWDtRtjzcEZp80=; b=UZydfPEidqiTZwiAW9XLsXJlZW3WD0KF6Ty4Hi91XpQ1CEsS9plqTCaRZtSHekuPG1+fbb kxuH7D4aKneZbiMCanqH20thP8poxcduzhg/mQPQCsn4oXsvpiN2cvgdvB8N+sZyaQ96Mx mprFlXTl+omm9SSTS6WbnlpRfSDVrUVDrziK+jWxFf5tcuKnoqz/WAhtJfYZGiQEgQfxDJ 5/qimZDdqxVkWkAScbf86sH4jz19MzH95jlJCHIwAL0dXSWWAhakrwZwr4tVufe3ZyR8VR 95NUxlDIwScBzJoy3+njSY2p4XAcuK2L5yJt4NV40mlCfuYus8R9XmTO3OxN4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=jHKLE1US; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708963443; a=rsa-sha256; cv=none; b=fW5+f0Vpy69dAWLeR3ZU3WoZ+eqG34QfzJ1zTThxBJGhbjrIcYaH7c+KMndZGTy5Cvhmhj UdPgGimzpl47avuQa1uWOtMb0SWXoYtH7TKSbL+vur2vI+ID4aco8TDFIXGdDvb5v8F9/q SsI07KggiZBFEZhQF6XKrUl/E+1ZfkP5C1i6TqpcWS1QSucyZqruAvS4qulOpc+bsjvI7A J7AU/4tMxPBEEwb5as2ouu55uFaWisQWbRKe2G/P72Vw8acMF9m5lFXWE8ZQ7FYK6bPwen YeoiKC085DQdIQKHp390FstBZMBceLoxy2n9nV6s5Bt+A9OvAhCBEzgZ6rgXvw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F98D723EC for ; Mon, 26 Feb 2024 17:04:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1redSB-0005bB-Vv; Mon, 26 Feb 2024 11:03:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1redS7-0005aC-Eg for guix-patches@gnu.org; Mon, 26 Feb 2024 11:03:39 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1redS5-0005WK-T1 for guix-patches@gnu.org; Mon, 26 Feb 2024 11:03:38 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1redSU-0004Nm-RG for guix-patches@gnu.org; Mon, 26 Feb 2024 11:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Feb 2024 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68250 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hilton Chain Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Lars-Dominik Braun , Zheng Junjie , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke Received: via spool by 68250-submit@debbugs.gnu.org id=B68250.170896338816659 (code B ref 68250); Mon, 26 Feb 2024 16:04:02 +0000 Received: (at 68250) by debbugs.gnu.org; 26 Feb 2024 16:03:08 +0000 Received: from localhost ([127.0.0.1]:46331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1redRc-0004Kd-0b for submit@debbugs.gnu.org; Mon, 26 Feb 2024 11:03:08 -0500 Received: from mail-ot1-f49.google.com ([209.85.210.49]:52436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1redRZ-0004Jz-BD for 68250@debbugs.gnu.org; Mon, 26 Feb 2024 11:03:06 -0500 Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-6e4899fa7f1so1338583a34.0 for <68250@debbugs.gnu.org>; Mon, 26 Feb 2024 08:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708963294; x=1709568094; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=H4UVTP+k0KJHSwLR7FOQq1GMytjdABWDtRtjzcEZp80=; b=jHKLE1USWdQIx58tJYnPXUtme6etqUfngFmXkLCGbz03lrIvPfdRPm0p1KPa5nlBG8 fTYn6k/gxmoPKUGlUeYrAsvgHfigQgOidrW6xjjWjnQ7hpdmI17ZtMSX0tvWRlsjmDQ1 I6J9sM2Q8Zda/FcHXhb7znlwH9nQVMn+09TH4SymFsAJOb6QdU6p829QhsX6XGs7vUQb 6ekI5jKwDp8x7vn0R8KGw5JOSyCHDOfe8tAKu4Ze+19PfYnHs6I1AyItyLX4yX4kSevC oLEIYjZH8QCLvLqLJI5I0Uz9BinAz/AlHjXB610wlPVDZePN3FZEhZgTHBXDMr2Co3pm tgdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708963294; x=1709568094; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H4UVTP+k0KJHSwLR7FOQq1GMytjdABWDtRtjzcEZp80=; b=WuXx0ueX2NSQIsLIzd+bDWmc/C1Lv6tIdZvbN/u2VGLyQyugbBbvPa2XNUIQaCKmJY 35vibcH9NipCPzWxPu90A0JsBHSXYqrAduDIlAsVUkpWpNl/VOcm+BaPqxTDibCXPydZ MtiHCA95AHBO+k8XVKAcA1GUHq66HBiLJNVCu5EkRw9nbe9DWSuuuubG5R8McgbnEmMa k/au6azREHu4TvKLieJoEs2FGl/e3pfG3yX7yaZ9uLjwNEJS0HdVLBQNSleFi1Japd3F toW2txqfWo2tQwyaNj0zBKcx36B8M0W05WmDXfP/6nfcTieezPqVugmuTBj8P5pHRkdx QorQ== X-Forwarded-Encrypted: i=1; AJvYcCVCd1iF9f+gsv68WFJBqKkhurqI6JYMTXJIfdJNG/mf+vOjBu3w9tHQby3+0sk4P7vmFs7NX7tnqFM+qktOjgFlGnxaYNo= X-Gm-Message-State: AOJu0YwM+9+vdg2wyDQDcEVVH/8rvKlD4Vk6jVc4Gm/75+nTi0/OXmWE YF9hatbaM/CVlZOZ5c3zqjjNmwV2LUVe7IumdMdzhyJ3+paOoPwi X-Google-Smtp-Source: AGHT+IF3G02OFhGOPqlz9E/QXWdR1Dv7M3PE5o0UG7CiQhxiNsVROH6Bq6g7EIViPRT/EsuwDoRDkw== X-Received: by 2002:a05:6830:11d2:b0:6e4:6305:367b with SMTP id v18-20020a05683011d200b006e46305367bmr8783726otq.30.1708963293538; Mon, 26 Feb 2024 08:01:33 -0800 (PST) Received: from hurd (dsl-141-6.b2b2c.ca. [66.158.141.6]) by smtp.gmail.com with ESMTPSA id x1-20020a05620a0b4100b00787c9b2459bsm1987018qkg.72.2024.02.26.08.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 08:01:33 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <87cyta66sr.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 05 Feb 2024 14:37:56 -0500") References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <8734uukrgq.fsf_-_@gmail.com> <87o7d04w1k.wl-hako@ultrarare.space> <87cyta66sr.fsf@gmail.com> Date: Mon, 26 Feb 2024 11:01:31 -0500 Message-ID: <87cysjkyec.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.17 X-Spam-Score: -5.17 X-Migadu-Queue-Id: 6F98D723EC X-Migadu-Scanner: mx11.migadu.com X-TUID: TWVHUXmE61AG Hi Hilton, Maxim Cournoyer writes: > Hi Hilton, > > [...] > >>> I've just seen this, after pushing a hot fix as >>> f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed >>> libraries in Requires.private. >>> >>> I suppose that someone wanting to build something statically from mpv >>> would benefit from having the original mpv.pc file without >>> modifications. >>> >>> Perhaps we can try it out for a bit, and if the propagation causes >>> problems, we can fall-back to this change here? >> >> >> Then we should follow the approach in v1 to add libmpv as a separate package. >> I'll send v3 later. > > Actually I don't think we need to split out a library for mpv here; > there are two things we can do in the short term: > > 1. Build MPV strictly as a shared library (-Dbuild=shared) or something > in Meson. Then Meson doesn't output all these Requires.private > dependencies, which are only useful for static linking, and which > pkg-config confusingly uses for its --exists check. > > 2. On core-updates, I've been experimenting with replacing pkg-config > with pkgconf, which seems to be designed better for avoiding the above > pkg-config's pitfall. Currently stuck on a hard to understand cycle. I've implemented 2. above; see: , which removes the need to propagate pkg-config *.private fields, which should only be needed when doing static builds. I'm thus closing this issue. Let me know if I've missed anything! -- Thanks, Maxim