From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id KHAxDhLYO2aFcAAAe85BDQ:P1 (envelope-from ) for ; Wed, 08 May 2024 21:52:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id KHAxDhLYO2aFcAAAe85BDQ (envelope-from ) for ; Wed, 08 May 2024 21:52:50 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Pjay7jpE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715197969; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/0352/4BawxYl29mhY4BMG2oQiSjoQwKYJxBSUyH5Bc=; b=JZ1XZi5cO5C8vZ6/i8E/9j9Pm4iyPjSDfB0qnblqx0jY6UGp/VPpuL2bPmIDGNliJq5HhS ENifvDYlfyyyXgFehRhYeyKyfYVyuxwIkEGFi3DM24NT19xyHdBcrwjdB8ar3e4Rdqb1wW WVQ5gyQe9RtAl4O2YjnVxT324NCGjtb3KvCAu9dJxoXZJLDFmxUpjHVCoSQ2akg75fAqjQ hLggH3KbjcRSV58Bp612/x9Q6X2QxCpE7SKA4EEPZp8p7uBl0E8g9ymBi7meH4FnDlchoR Otp/qP8dpFvzPaWcbIou9hGpJBHq6Y6/WdSRvQ778t2HiqXj/oxs+IR856UjyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715197969; a=rsa-sha256; cv=none; b=tatT/15Ju1+5wiaZBtOzHMWuXTjlyfFFE2wksOdFKhMEFGoVRIXkxQ3qdx+XJS3RdUgcsb FoOG3BBIh0AFVxsLADeY7TQ7MR+jtDa719cA7xVNlkiyTeK+cX3g5yDAZkGD0EtTk+brXp pKxnyvwHidGtjQYctAMK2w1VKNHvBk2+Nq6q1M6Kfod7TVyzCkAx3iF6rcLv/UzdIhBZv8 ZXTCbU07wp8ezK7YLWk8Qb4ji8sCvNtt0tyOH1W2Qp2dpDq7SUfU433Yh4Bnyq86Mgne5O znMpDZUZ/4meh2cDlMXCb9JHJ8RnXD5Fjb4B2FJp4urULLV1Vs9dRfLbV2N1nA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Pjay7jpE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ADD90B3B1 for ; Wed, 08 May 2024 21:52:49 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4nLB-0001C4-S8; Wed, 08 May 2024 15:52:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4nLA-0001Bi-Ce for guix-patches@gnu.org; Wed, 08 May 2024 15:52:36 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s4nLA-0007VE-1o for guix-patches@gnu.org; Wed, 08 May 2024 15:52:36 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s4nLZ-0002Qn-Jq for guix-patches@gnu.org; Wed, 08 May 2024 15:53:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 May 2024 19:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq Cc: 70282@debbugs.gnu.org, Vivien Kraus , Liliana Marie Prikler Received: via spool by 70282-submit@debbugs.gnu.org id=B70282.17151979299307 (code B ref 70282); Wed, 08 May 2024 19:53:01 +0000 Received: (at 70282) by debbugs.gnu.org; 8 May 2024 19:52:09 +0000 Received: from localhost ([127.0.0.1]:50565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4nKi-0002Q3-Kt for submit@debbugs.gnu.org; Wed, 08 May 2024 15:52:09 -0400 Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]:57685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4nKZ-0002PY-Gg for 70282@debbugs.gnu.org; Wed, 08 May 2024 15:52:07 -0400 Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-69b5de48126so837666d6.3 for <70282@debbugs.gnu.org>; Wed, 08 May 2024 12:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715197888; x=1715802688; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/0352/4BawxYl29mhY4BMG2oQiSjoQwKYJxBSUyH5Bc=; b=Pjay7jpEQSQn+9CT30TKdYRacr9At4kSS0V2vjFc8ubwKHRbQNbRT/wonLpqLolxer GUfSBO52dw9Om0COjfeiKL9V8a+sN6t5T0UqlJpF8LT0/x7z7iDIOHQG1hVrkuIrJdfJ FgWr+rcNXZtHu28Z00S2OfujxCOB2IeOBohV5cAqhA8flnsR3xkdFPwhZswlBKGMZvG/ uaBVGwg21BRCknRp3XaNeo1S4qOIaKJlDHfH3hvQex1ak04bmgP3aXotbUhlnqqjTSf2 v5DXbv7kt2MKnCVUEfFDofmpKobJp+QzuDEbtAVy48CcoWBCT5qpaFKhrR6uokGnoIOs gAcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715197888; x=1715802688; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/0352/4BawxYl29mhY4BMG2oQiSjoQwKYJxBSUyH5Bc=; b=jZgwBaajSGbhzaHSRUUtsZhdDxsq7JOJqzaiDufVBZTEKTLGjnTOX5z82cJmYOhM31 qd/eq4gHwLOyXOyHi3lATkDL5A+XSQmbQBPQ9/vry83Dfy8+kIzaQHtsSWCTyIbljqkH WgsGcFFHxHQJdj7rmkCJ6j1Hs5068ftS6fnNKeTaCyWMamlxgD4j1w1BoA5FWrRX6gb/ BuZbkUYM2fIcPIOAvD/vwgm9abbsua+l8swt55/aLNrYgVaidNqy+6Mr423eZiSwxMfU 9etMB5sqz1nlNLXC4B66A/tM1czDHFLtPe5RYoZZ5c7LQLPnJJ1tAt0MLFUCmpQ4QqDX tb+g== X-Gm-Message-State: AOJu0Yy0wqjsipeacp1tjuKwMctr6gnkxDHlFz5JJlhVMcvW88YtzDwV fXgCTEmYyO2GLQpcBAU9qP1nZmrempUsL8AbCm3bqBFuOiJ/W1CE X-Google-Smtp-Source: AGHT+IEw+ZlNP9crEnvx4RRhaUulH7wtAv9akolRojO7crGMmfMEqdLBR6fBaHRiQ8/7Fh4Rrb44nA== X-Received: by 2002:a05:6214:4107:b0:6a0:b99e:7ad6 with SMTP id 6a1803df08f44-6a151490281mr43819576d6.34.1715197888169; Wed, 08 May 2024 12:51:28 -0700 (PDT) Received: from hurd (dsl-159-136.b2b2c.ca. [66.158.159.136]) by smtp.gmail.com with ESMTPSA id nd2-20020a056214420200b006a1006ddad2sm5855745qvb.131.2024.05.08.12.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 12:51:27 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> (dariqq@posteo.net's message of "Wed, 8 May 2024 18:33:30 +0000") References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> Date: Wed, 08 May 2024 15:51:26 -0400 Message-ID: <87cypw6q0x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.79 X-Spam-Score: -0.79 X-Migadu-Queue-Id: ADD90B3B1 X-Migadu-Scanner: mx11.migadu.com X-TUID: oFePojVoIW7y Hi Dariqq, Dariqq writes: > Adjust screencast such that GI_TYPELIB_PATH and GST_PLUGIN_SYSTEM_PATH are set > before starting. > > Add all required gstreamer plugins to inputs. > > To be able to use it a running pipewire service is needed. > > * gnu/packages/gnome.scm (gnome-shell): > [inputs]: Add gst-plugins-good and pipewire. > [#:phases]<'wrap-programs>: Wrap org.gnome.Shell.Screencast. Thanks for your efforts improving our GNOME desktop experience! > Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 > --- > Here is v4 which appends the gstreamer plugins to > GST_PLUGIN_SYSTEM_PATH, handling the case when getenv returns null. I > think the difference between appendending or prepending in this case > is not too important as the user GST_PLUGIN_PATH should take > precedent. The more important thing is that the plugins are in any > plugin path at all. > > gnu/packages/gnome.scm | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 92e35e3c5a..4bbff2a89b 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -9408,6 +9408,7 @@ (define-public gnome-shell > (add-after 'install 'wrap-programs > (lambda* (#:key inputs #:allow-other-keys) > (let ((gi-typelib-path (getenv "GI_TYPELIB_PATH")) > + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) > (python-path > (string-join > (filter (lambda (item) > @@ -9427,6 +9428,19 @@ (define-public gnome-shell > "path => imports.gi.GIRepository.Repository." > "prepend_search_path(path));\n" > all))) > + ;; Screencast requires a pipewire service running > + ;; (i.e. as provided by home-pipewire-service-type) > + (substitute* (string-append #$output "/share/gnome-shell/" > + "org.gnome.Shell.Screencast") > + (("imports\\.package\\.start" all) > + (string-append "'" gi-typelib-path "'.split(':').forEach(" > + "path => imports.gi.GIRepository.Repository." > + "prepend_search_path(path));\n" > + "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH'," > + "[imports.gi.GLib.getenv('GST_PLUGIN_SYSTEM_PATH')," > + "'" gst-plugin-path "'].filter(v => v).join(':')," > + "true);\n" > + all))) Perhaps a simple patch would convey the change better and be easier to maintain in the future / be readily available for other distributions to use. > (for-each > (lambda (prog) > (wrap-program (string-append #$output "/bin/" prog) > @@ -9492,6 +9506,7 @@ (define-public gnome-shell > gnome-settings-daemon > graphene > gst-plugins-base > + gst-plugins-good > ibus > libcanberra > libcroco > @@ -9502,6 +9517,7 @@ (define-public gnome-shell > mesa-headers > mutter > network-manager-applet > + pipewire > polkit > pulseaudio > python-pygobject Otherwise, LGTM! -- Thanks, Maxim