From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id iGR3HkkxRmbsJQEAe85BDQ:P1 (envelope-from ) for ; Thu, 16 May 2024 18:16:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id iGR3HkkxRmbsJQEAe85BDQ (envelope-from ) for ; Thu, 16 May 2024 18:16:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ehohl7mz; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715876169; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xVf7SFpwAJNm1CEdL1hs5IjOZ3DRd4cgBbpPNXGltNE=; b=h1a1v6CqUg9WNl/1AfRIjmn97zmxQ7DRh1zElghSm12U6W/YL1g9gF0erFjgeZmgP0sSzZ 7M6R1u8DCPkTkUxFawSACD214Q5akPbLcejPBvjLrsk4wIPtNmD7DIoqe+bACrsbE1351H 0P6c/5JTgERpXa1Z+XMsRJmZwO4o+l0j3Ua24LGbdlZQxzc+bCvfy8M46+KY0VWXZJpc1i EwKNw4D7u6GbuCXB9vXSAecCuo4QqKjgKmNYgGBtfAfdF7/XQXN6M93nltOPNL/H/DxdQK 55sfdstjYWMcMMON/mABS92UiQ/+EITYoJHzosyV7fcMGhPF5DdwwoQpXZOZfA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ehohl7mz; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715876169; a=rsa-sha256; cv=none; b=EWYVQk4nI3mR8HrdRdMwc8EXZx6DDVk5Ssf/m7irA9FSLeCH0gbDw4kIg2vpXEUm2H5y1w vsypRR+DH1lawa1X4PMzJm7N7XJMKUnfW8/R8UNbHkjfod00am8cMiR6iaPQ9Po3/8Nrip PUg/Hn2HUqB7zhh1gOzn5CRGiW0MGb7tImA98JGeb2MtPvmv1zHkFK36j+BSvc2NZfqp7q zZ5r57Kd/CXDRH0aDxKcMYR+Ilr4IRaeHwnw57zl/dc+JwQ9I9qF2g6Jk8yprUwwlb2WNj x8T2c4NJg94cG1lG7o4a48Xkse86AXZCE4C9Gbd9mMKqaSQbgvT4UopZyefLnQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 594AD6B2C7 for ; Thu, 16 May 2024 18:16:09 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7dlz-0001RK-Bp; Thu, 16 May 2024 12:16:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7dlw-0001NY-7S for guix-patches@gnu.org; Thu, 16 May 2024 12:16:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7dlv-0001Nb-Do for guix-patches@gnu.org; Thu, 16 May 2024 12:15:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7dlx-0000Nm-Mp for guix-patches@gnu.org; Thu, 16 May 2024 12:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70494] [PATCH 13/23] syscalls: Add unshare. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 May 2024 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 70494@debbugs.gnu.org Received: via spool by 70494-submit@debbugs.gnu.org id=B70494.17158761081448 (code B ref 70494); Thu, 16 May 2024 16:16:01 +0000 Received: (at 70494) by debbugs.gnu.org; 16 May 2024 16:15:08 +0000 Received: from localhost ([127.0.0.1]:49606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dl4-0000NE-3o for submit@debbugs.gnu.org; Thu, 16 May 2024 12:15:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dl2-0000MY-DS for 70494@debbugs.gnu.org; Thu, 16 May 2024 12:15:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7dku-0001Be-Pp; Thu, 16 May 2024 12:14:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=xVf7SFpwAJNm1CEdL1hs5IjOZ3DRd4cgBbpPNXGltNE=; b=Ehohl7mzzuCwOCa6P0/J 4qCjNTr+w97z9DiCWpo820YgmkIesH38HxwRwUEmsnO4bymotc+SfpqOv0ZpA1YO5jTeAbIqTYBsi XKx1/f+MkPiXZvmQKYTe2nViCRgKTVy67ICYt9qdQ2w9uyax/Ug22xxBU2OBK+rW0ujL09dWnm31f yqxJ2C+DY0wIfC4HA1MUA2AQuDDW7utf08eDXiL+fNzVqaHAquPNF9SKPP7iDFJ/FeO/fZQh1Rd5M bCGCTDEtc09JSfWOn0jlzUGWjq00PioAEgIfg9rXpxJYzusDuZ1vJvIcbbz1GL59Ig6s4q2HATKZi NOWeGE0xGSYK+g==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Christopher Baines's message of "Sun, 21 Apr 2024 10:42:31 +0100") References: <87bk632h36.fsf@cbaines.net> Date: Thu, 16 May 2024 18:14:47 +0200 Message-ID: <87cyplag3s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -7.27 X-Migadu-Queue-Id: 594AD6B2C7 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -7.27 X-TUID: c5eYPmJnDRE6 Christopher Baines skribis: > * guix/build/syscalls.scm (unshare): New procedure. > > Change-Id: I7caad207117b17b349290e680277f650c51d2f3b [...] > +(define unshare > + (false-if-exception > + (let ((proc (syscall->procedure int "unshare" (list int)))) > + (lambda (flags) > + (let ((ret err (proc flags))) > + (unless (zero? ret) > + (throw 'system-error "unshare" "~d ~d: ~A" > + (list flags (strerror err)) > + (list err)))))))) Please remove =E2=80=98false-if-exception=E2=80=99, add a docstring, and ad= d a test or two. (I find that unshare(2) is not that useful because a process cannot unshare(2) its PID namespace: it has to fork to do that. At that point, one might as well call clone(CLONE_NEWPID) directly.) Ludo=E2=80=99.