From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CKdNF2Tr52b+EQEA62LTzQ:P1 (envelope-from ) for ; Mon, 16 Sep 2024 08:25:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CKdNF2Tr52b+EQEA62LTzQ (envelope-from ) for ; Mon, 16 Sep 2024 10:25:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=iCQDN2ln; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=H9Qu3Wnd; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726475108; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YC96Q1smuzNW+lE7Yk1oG/hXFKuhUh/em9UPINuMOjo=; b=Ej5l+sYa/8CiqrTwGhSkhM/rv6zfWmxaLzl5mjfN1ymUe9tlq5livXzZKyi/j0BXd8O6mc qRIF3edjPoKICHCFKOcpmABcaNCtvmbPcfGxGtrZpCJ6U5U6HT7bVuRQr80RK92m2wpBUL srTJgzQmmZUKDHKLsmsaxVMLricnK93izPf1EA+ggxcpOY+lKDxO+fofTWCjxONpybYL/r 4+FZLPGAVef/CddGAfDZ1daogeKp3i34UGOge2XalvVTUugYltXhctSCM4wLX7XrSgxi+9 99pGaJgPlj736+5+vWrfb8FrkNZ/BTJm75cEss6gUnzmt51SQZATxUouYai1sg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726475108; a=rsa-sha256; cv=none; b=hHhYY3z+Qvf5HqgARIBUMR9gV4yh8uz4T7umvSwWrl69cQ00anGDcftF1eOHr3CNDDqngn jnMaTJRW4gHQLXBezkf8w7dNV50Pu8Btp4KH2/ubYAGumjPluL3N3PzuXbcZJucvPGqYXg Kut0fo4P3H545/ZC+NFhiZK+YYpIVOI5b3J3Lqf0awSgc0NGr/KxJkNbwMxjdzxB9yhsk5 s2VUPUqIo73wM7ZdwrKzyZJSczeMQAtlctDi77Cr3l5sD8dSpV5sp3nV8eVfk+VoFKOBvM nuNfJNo2F+Wb9RFGn4E8orYnAudwtP0TJCtdBWI0Tp8BKszpJz1YF9Y0ObALWA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=iCQDN2ln; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=H9Qu3Wnd; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0F4CF69624 for ; Mon, 16 Sep 2024 10:25:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sq72S-0000JM-R8; Mon, 16 Sep 2024 04:24:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sq72P-00009n-A3 for guix-patches@gnu.org; Mon, 16 Sep 2024 04:24:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sq72O-0000ra-Uw for guix-patches@gnu.org; Mon, 16 Sep 2024 04:24:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=YC96Q1smuzNW+lE7Yk1oG/hXFKuhUh/em9UPINuMOjo=; b=iCQDN2lnkmgUEJQhO2EqgtijxTBIF5aZXPfwsQncJNlNnIwxOkJQT+96dmyUMZqTw00hg7r8Iuq3k+WqXfTMimMLmk3/v2TSwPsDl4McGaRG+5dOoQ9kfaZJ+fQKprTKGNfp23R36+O41hKXWUtjxd6062XCTA1gZhkoXe8SdwS8Uhsi2I7HfiB4NAim8TGKOBWw5e3R4e6Ycz4ry6/Zhn3zQC3C2hNZROjlJm5HadAOoPAthHCbzxYE7/lSc8ALiH24u7XCfO2ZVqW/YCxGMa7RXInC+0C87yc7Pa6UhiT1rcB/cxChP57aaEqY39igq4TXl3JvRj5OeoVbVcybwQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sq72b-0008IW-Tw for guix-patches@gnu.org; Mon, 16 Sep 2024 04:25:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72994] [PATCH] gnu: emacs-julia-snail: Vendor julia libraries. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Sep 2024 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72994 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: Katherine Cox-Buday , 72994@debbugs.gnu.org, Liliana Marie Prikler , Andrew Tropin Received: via spool by 72994-submit@debbugs.gnu.org id=B72994.172647507031846 (code B ref 72994); Mon, 16 Sep 2024 08:25:01 +0000 Received: (at 72994) by debbugs.gnu.org; 16 Sep 2024 08:24:30 +0000 Received: from localhost ([127.0.0.1]:51051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sq725-0008HZ-L0 for submit@debbugs.gnu.org; Mon, 16 Sep 2024 04:24:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sq722-0008HH-6x for 72994@debbugs.gnu.org; Mon, 16 Sep 2024 04:24:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sq71j-0000q9-Ao; Mon, 16 Sep 2024 04:24:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=YC96Q1smuzNW+lE7Yk1oG/hXFKuhUh/em9UPINuMOjo=; b=H9Qu3WndRMuEPq+SPtei uzFhD9wk77d8OmfjcWu7YQVKk+i/7wNj3i5M69dAMHDuZpQGIZaKUh51CNIUWA3hOR9OaidVPuCOs NMZaeWP+WfuTuDefBpT6zJlzMB95P4IxC62eInppdA2jlE4vx8stL6qPAokt1XxyMj7zd9AnjcV1p tQSkwLiYJufVIbicBdh4LhfBtq0HOAAAQ0XP2SVXPIi1abqTMhO38UoLs8+OPY18H62QOyHMZ8Yo4 N8Q7RNkGwuyft4GFNlOnuqDsPAF0u0q/3tSusEww6NUJxJVr5sIziudqOotJrt5G6Zf06Wps6NvmC fkNrtowdh1cWVw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <58ce361528f55e5ad76ed7da4123525a9e9375e5.1725319687.git.dannym@friendly-machines.com> (Danny Milosavljevic's message of "Tue, 3 Sep 2024 02:02:18 +0200") References: <58ce361528f55e5ad76ed7da4123525a9e9375e5.1725319687.git.dannym@friendly-machines.com> Date: Mon, 16 Sep 2024 10:24:04 +0200 Message-ID: <87cyl49fbv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.51 X-Spam-Score: -5.51 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Queue-Id: 0F4CF69624 X-TUID: Mk7KRhG8Lm9p Hey Danny, Danny Milosavljevic skribis: > * gnu/packages/patches/emacs-julia-snail-1.3.1-vendor.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/emacs-xyz.scm (emacs-julia-snail)[arguments]<#:phases>[ven= dor]: > New phase. > [inputs]: Add julia-cstparser, julia-tokenize. > [propagated-inputs]: Remove julia-cstparser, julia-tokenize. > [source]: Add patch. > > Change-Id: I61c0a4493fcfd219809bcc35f8765be0928a7e81 [...] > + (add-after 'validate-compiled-autoloads 'vendor > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (base (dirname (car (find-files out "JuliaSnail.jl"= )))) > + (vendor (string-append base "/vendor"))) > + (mkdir-p vendor) > + (copy-recursively (string-append (assoc-ref inputs "juli= a-cstparser") > + "/share/julia/loadpath/= CSTParser") > + (string-append vendor "/CSTParser")) > + (copy-recursively (string-append (assoc-ref inputs "juli= a-tokenize") > + "/share/julia/loadpath/= Tokenize") Use =E2=80=98search-input-directory=E2=80=99 rather than =E2=80=98assoc-ref= =E2=80=99. > +++ b/gnu/packages/patches/emacs-julia-snail-1.3.1-vendor.patch > @@ -0,0 +1,57 @@ > +Author: Danny Milosavljevic > +Date: 2024-09-03 > +License: GPL3+ > + > +Previously, we propagated julia-cstparser and julia-tokenize. This would= only > +work if the user had installed julia in their profile (because only then > +JULIA_LOAD_PATH of julia-cstparser would be propagated). > +That doesn't seem likely or desireable. > + > +It turns out that it's not difficult to make julia read vendored package= s. > +Let's do that (since there's a comment inside JuliaSnail.jl that warns a= bout > +CSTParser APIs being easily incompatible, vendoring is better anyway). I=E2=80=99m not sure I understand. For most programming languages (Python, etc.), we use propagated inputs like this. How does that differ? Normally we unbundle (=E2=80=9Cunvendor=E2=80=9D?) libraries and this seems= to go in the opposite direction, right? Thanks, Ludo=E2=80=99.