From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wNrnGKDBGGeXhgEA62LTzQ:P1 (envelope-from ) for ; Wed, 23 Oct 2024 09:28:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id wNrnGKDBGGeXhgEA62LTzQ (envelope-from ) for ; Wed, 23 Oct 2024 11:28:00 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=fYbJuCND; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Wnt5pgmS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729675680; a=rsa-sha256; cv=none; b=j0kxEvb/fNl+qLbXL0tYwbZ4I7aErM0U6NyS08TrHRQwUpfuLa5EDf++7e57TP8TOH+R4B 4jIOro7U2ONUR0+tFz0+KGCC9Xslxgz9CdPkFK8bZGx41up4G4TrjjwBjlyjPG1iEVyDwT Fd/D1h+g9hU/VZ26ahKjUMx1v5bg3RtVYWX8Qvt+o0COPBfWo3avQlvdXRwxqmUpp8aRSu ydEWETmPBFJ41YYhsWpkJC5s33CUV6oHVrjfBM+Bl2cPFCPYZl+NaBn/oQB+icMZgtv151 zCq8sGPgEU87qKx8RMXnFUONDUOjiWMuvFvM/62jRlp+fNmpfFEHlppkILpMTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=fYbJuCND; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Wnt5pgmS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729675680; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ByM4dJ/dAdwdIH8Dl08q5m3NtdGZ5ezLdJrXhjlqnHU=; b=KpZ3rQ/Ak6NIco5lmXasoahFLFgz+Uhdb9D17yk88xW1R/jf9GhH8sQVadmLoKScxyVa8x y3xjMfPV0nPzsKVI5aCA5c9mwsO8bW3snljKdv6rfNUsY+fihO3PSoU5Vq4y2VckGehNN5 z1WshqTDtgKV4ev8aFvuDMQJkEk4r/QXAefZehgnw6F8KkuM6LsU4tW6NwXIdYo7nbaFkp CiQy5/8Y/KQDBfuAEvEHFRX3JMjWHIf5XbyJWtvJlfONG4zBjym9GtF8jtScYsC/xUqiCo MtRI6aoq9MpgJUSLWHPIAd50B/aiPd0isHH7Y0+Sr7aY4DH6hAumgm5vI6EPpQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CFC982818 for ; Wed, 23 Oct 2024 11:27:59 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3XeR-0001q6-Ep; Wed, 23 Oct 2024 05:27:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3XeP-0001px-VZ for guix-patches@gnu.org; Wed, 23 Oct 2024 05:27:34 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3XeP-0003Dh-Nb for guix-patches@gnu.org; Wed, 23 Oct 2024 05:27:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ByM4dJ/dAdwdIH8Dl08q5m3NtdGZ5ezLdJrXhjlqnHU=; b=fYbJuCNDpu25OaP3okPkm+EBhCfNJz9kaL/2iE0XxjW56vgZNyU80h6WvWm1gmYtb1qATKHjwYUL1GzW8/wP85c+lf0XX6c14fY0CKDNnggSUVXZj/74oSJcUNfpD9iHJBfZVE3QHuH9Y1oQPxdrT1hgrlPOjCGoHhyMNGC6Bu5EzQ+mkMrfUSAj2qShQXC30dLfBsw1La9cJla2mNd3U2Fw5ckuWd9iRl6EVPydv+t+2tDqHeRrwm1Cy9ruPJZWMvVEO2XKSpJakneRKq+Uag6umiBmJI9jhZh1GEA47FbrldZ6cUjqeX0y/RvZAjWp2bie92SVIFHOX5p1CtPfqg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3Xes-0001ju-Ga for guix-patches@gnu.org; Wed, 23 Oct 2024 05:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73955] [PATCH 2/2] services: wireguard: Support lists of gexps for most fields. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Oct 2024 09:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Richard Sent Cc: eu@euandre.org, maxim.cournoyer@gmail.com, 73955@debbugs.gnu.org, guix@twilken.net Received: via spool by 73955-submit@debbugs.gnu.org id=B73955.17296756616660 (code B ref 73955); Wed, 23 Oct 2024 09:28:02 +0000 Received: (at 73955) by debbugs.gnu.org; 23 Oct 2024 09:27:41 +0000 Received: from localhost ([127.0.0.1]:58616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3XeW-0001jL-LZ for submit@debbugs.gnu.org; Wed, 23 Oct 2024 05:27:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3XeU-0001j8-Ib for 73955@debbugs.gnu.org; Wed, 23 Oct 2024 05:27:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Xds-0003C4-EN; Wed, 23 Oct 2024 05:27:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ByM4dJ/dAdwdIH8Dl08q5m3NtdGZ5ezLdJrXhjlqnHU=; b=Wnt5pgmSA9rvP750uYAO nKai4M+pYxuellLMbhuu2CbGW8SYajCd+GnWNhIXsKKr/kdFrdl3z1KL4+Khc/aIxYFrAkmiD5DMa JWyVSJ2VLeC+ns5pSrM+52CsRzkkt6En7m66iw3XbMaZNsfnNuOtM/PBXQINNK5TDKU06ufgQqR1d JNLqVt6UYupODqyypU+BJ3SY7sde1XrFxzafFSNsFesfer6YKfkfXYaDfKhO6VVcU+j3scVQ34SkI i5ZW0IBcNWJlYTFkFzm8dLrtslRjmJ0iUbTR+y+MQLwBLVWNbmWBQGvigS2thIpHw6jL60PHpciKw YzVUJ28Tj2qitw==; From: Mathieu Othacehe In-Reply-To: <0bb043a194b4c1b7d85921aac16f2fc2cbac2cfd.1729632049.git.richard@freakingpenguin.com> (Richard Sent's message of "Tue, 22 Oct 2024 17:25:29 -0400") References: <0bb043a194b4c1b7d85921aac16f2fc2cbac2cfd.1729632049.git.richard@freakingpenguin.com> Date: Wed, 23 Oct 2024 11:26:26 +0200 Message-ID: <87cyjr2mrh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 1.81 X-Spam-Score: 1.81 X-Migadu-Queue-Id: 4CFC982818 X-Migadu-Scanner: mx12.migadu.com X-TUID: 4JgT9XOsDesF Hello Richard, Thanks for this series. The first commit looks OK to me. > For example, the wg-quick(8) manual has an example on how to use > password-store to retrieve a private key with a PreUp entry. This is now > possible. It would be interesting to provide some testing for that. Sadly, we do not have a system test for Wireguard yet. We only have a unit test file in (tests services vpn). Adding a new (gnu tests vpn) module would be great in the future to test different Wireguard configurations. That can of course be done later on :) Regarding this patch, the documentation is somehow vague on how to pass post and pre commands: --8<---------------cut here---------------start------------->8--- @item @code{post-up} (default: @code{'()}) The script commands to be run after setting up the interface. ... --8<---------------cut here---------------end--------------->8--- Maybe you could elaborate on that a little bit and give some examples that would be the translation of some of the post and pre commands that are given in the wg-quick man page? Thanks, Mathieu