From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id sAk6AuLgTWckXwEAqHPOHw:P1 (envelope-from ) for ; Mon, 02 Dec 2024 16:31:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id sAk6AuLgTWckXwEAqHPOHw (envelope-from ) for ; Mon, 02 Dec 2024 17:31:30 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=tAM9cOek; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm3 header.b=tyM9sit2; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="z XYZIOb"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733157089; a=rsa-sha256; cv=none; b=FosV1Q1083sZ2ktHMbGjCS+s6zp5+vVcLqEsHkYzoJ8bVeAj0FE5Y9rlcAAWheglepiaKH yHkYDAMKbFwKelIGX3iieWT2Iwhr3JhlRSs8ubyirPZkTPH2/xxiBK2BAJ7+mb9nkTlsEm 2z+TWZp9ANsozupLysRE2KOeWveAW75LZmS8XYvyleMlhmr1l20iwnMZu/nMnU/iqSHh8j zIKGWL6y/ukmcXsM2/y91ry5xlLdXxDI1bp+MmZ7ZPWr7zYRiCp5UuLDWP2OMcOxYXFQAK v8Ignjn57lqPelEFuxX9JTJ2gV3+6jB4HDWp1H1z5ZIsmLqzMbQzSOqii0AMRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=tAM9cOek; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm3 header.b=tyM9sit2; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="z XYZIOb"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733157089; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=05H40HCd57XDLy3ozOkedRtaF3Q0zLohhi4IUE+hCBI=; b=amqH8F2G/w9R2muXxCYdmL0vb+w09ZsIo6EwE+cYBhDcasfyDfzzyqMh63IT+uwwMfvoSa QHPaJl2mMekaeRI5RbF8zQ7LwV1NU/HhoY8zNI1l34/s98cAKgwWodTeZKC/t9rktvObB3 bq+Bgl56xwdbKb2eEkj+WV7fTSdDRlS0p1DXcLszKwG/A40309cy741MwHYxIwqdDRgJoZ XOhb50MTm2uXZ9c6YumHeXxA91UdhbThjNZH36zj3rFraEMKchkSDa/G5dHfj4nCSU1rGL LK/6I0+Ga/1XXhTv4/Ahw3YVhNklb4DiL3ck7ZjO2GyX73VGjq7njga3as0HMg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 85E1E799F4 for ; Mon, 02 Dec 2024 17:31:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tI9KJ-0006VY-El; Mon, 02 Dec 2024 11:31:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9KA-0006Tr-Sh for guix-patches@gnu.org; Mon, 02 Dec 2024 11:31:09 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tI9KA-00014Z-FF for guix-patches@gnu.org; Mon, 02 Dec 2024 11:31:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=05H40HCd57XDLy3ozOkedRtaF3Q0zLohhi4IUE+hCBI=; b=tAM9cOekY1/NTfEpg6+LB+XWNHkSV/kzSUSHm9VhH5WgeLiXihFE5Nd/yu5BEG7u5SNI80dOSh6465BSO7xxFP6m5Lp6+MoVPRsBb4tbVop1N16l6LBKsnDRhwrnr1VGPtn1SPvvJ9OdD9/ny87CnE3py9jj50O/ciUk3RAEN57nksHei+4WBTGYJJNpctUDfBqA+s7Gh0m4asHS6SX2vAfVHZ7pSrKQLjuKfMUzbVZVLkluyTO9NYIYwzeoVKRvpADKinm8qQPZ/xMAdCnNdURuHS914osb735AVgOZbVO+Go3NQYCKH+zaLGSmWOJc2JiySR8gaYQsXy0t7nnDDQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tI9KA-0001rV-8e for guix-patches@gnu.org; Mon, 02 Dec 2024 11:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74648] [PATCH] gnu: librewolf: Add %u to Exec option to open URLs. Resent-From: Ian Eure Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Dec 2024 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74648 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Roman Scherer Cc: =?UTF-8?Q?Andr=C3=A9?= Batista , Mark H Weaver , Jonathan Brielmaier , 74648@debbugs.gnu.org Received: via spool by 74648-submit@debbugs.gnu.org id=B74648.17331570257092 (code B ref 74648); Mon, 02 Dec 2024 16:31:02 +0000 Received: (at 74648) by debbugs.gnu.org; 2 Dec 2024 16:30:25 +0000 Received: from localhost ([127.0.0.1]:56301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9JY-0001qJ-OD for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:30:25 -0500 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]:48103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9JV-0001q0-NT for 74648@debbugs.gnu.org; Mon, 02 Dec 2024 11:30:22 -0500 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 0085625401A2; Mon, 2 Dec 2024 11:30:15 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Mon, 02 Dec 2024 11:30:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733157015; x=1733243415; bh=05H40HCd57XDLy3ozOkedRtaF3Q0zLohhi4IUE+hCBI=; b= tyM9sit2/6bVWoXAv1hbJ3+PwM7bmehSQn4Ltq5I2gCEPAjM+n7R0cPHM4G94kdW Q2BGKUOP1B153eOSyoXJ/oS8WQpy8lmm0hBx1uoRmlo1STZLFLYxvsr3vaqu8H5z GdNl6ZXQfMb1YfcCM/6GYlDlENUCv9B3ZZn6Jf7Xkaq85x0kT03FyVhxI+Yztk2M 9gNuDnloTp2jVeCeMw5FTDaBuAHOORliOnJNZWNLAhT0qn1au6azmckCOimTQd1C g06NmUyzCezk2qI1L62LXYP06xspmHk/8+t8AjClZA15HRH1127YRsOVe+vGDAgJ 8ZfTxCIZubZp/g+6eLJLhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733157015; x= 1733243415; bh=05H40HCd57XDLy3ozOkedRtaF3Q0zLohhi4IUE+hCBI=; b=z XYZIObJc8tWQk93yt2IaQlRYIk/lWVDaEHkcS9/YyF4eyqFA/Qd+e4CZUkNVNAgj lu9ay4FKQkkKixYp7cZVQBbMfz188Di00QKvWVBfFoAIDg+sjECef2nkuyklrUlP +d7n/O8NOPNx/NfM3Dn7HakfBiDMogKkIujP953eFhbaf3x2Ho/MkSfpKPl8P2JN YFmebTJCvnH6urq9AYnuk+EWC4ehulEBhTdlnaCdOAsgO65YUIPKYWFjbau0ap5i nE31/AFjavXNVw0goqd/Nk5TZB5u0/EdnUA6vH8PQyRRNMBMKbjgU3RjtkBlSdyF PmqFiiupGZgFuQbKqgH8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrheelgdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeen ucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenuc ggtffrrghtthgvrhhnpeevueelueegudejueekhffhhfelgfejheefffehgfffleekveek uedtgeekleegffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvhdpnhgspghrtghpthhtohephedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepmhhhfiesnhgvthhrihhsrdhorhhgpdhrtg hpthhtohepjhhonhgrthhhrghnrdgsrhhivghlmhgrihgvrhesfigvsgdruggvpdhrtghp thhtohepjeegieegkeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehnrg hnughrvgesrhhishgvuhhprdhnvghtpdhrtghpthhtoheprhhomhgrnhessghurhhnihhn ghhsfigvlhhlrdgtohhm X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Dec 2024 11:30:14 -0500 (EST) From: Ian Eure In-Reply-To: <875xo2f6ii.fsf@burningswell.com> (Roman Scherer's message of "Mon, 02 Dec 2024 16:29:09 +0100") References: <875xo2f6ii.fsf@burningswell.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 02 Dec 2024 08:30:12 -0800 Message-ID: <87cyiam4iz.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 85E1E799F4 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.78 X-Spam-Score: -4.78 X-TUID: AQuA5Kw+EDWa Hi Roman, Andr=C3=A9, Roman Scherer writes: > Andr=C3=A9 Batista writes: > > Hi Andr=C3=A9, > > thanks for taking a look. So this is fixing a security issue?=20 > Which one > exactly? Is it this one? > This isn=E2=80=99t a security issue, the concern was created in a change=20 which also had security updates. The current nature of the=20 browser ecosystem means nearly every Firefox update contains=20 security fixes, so presence of them isn=E2=80=99t a very useful signal. > >> Hi Roman, >> >> seg 02 dez 2024 =C3=A0s 13:20:20 (1733156420),=20 >> roman@burningswell.com enviou: >>> * gnu/packages/librewolf.scm (librewolf): Add %u to Exec=20 >>> option to open URLs. >>> >>> Change-Id: I8cf5d3886eaf7805209cf12eae0cc875bef6d5dd >>> --- >>> gnu/packages/librewolf.scm | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/gnu/packages/librewolf.scm=20 >>> b/gnu/packages/librewolf.scm >>> index 5d432cfad8..42d212e9f9 100644 >>> --- a/gnu/packages/librewolf.scm >>> +++ b/gnu/packages/librewolf.scm >>> @@ -605,7 +605,7 @@ (define-public librewolf >>> (substitute* desktop-file >>> (("^Exec=3D@MOZ_APP_NAME@") >>> (string-append "Exec=3D" >>> - #$output=20 >>> "/bin/librewolf")) >>> + #$output=20 >>> "/bin/librewolf %u")) >>> (("@MOZ_APP_DISPLAYNAME@") >>> >> >> This was its previous state and was removed on commit >> 280aa6b57d7b741a7d8b076e1afa3dff23569332. See also #74070. >> >> Copying Ian, who was the author of that change and has been=20 >> maintaining >> Librewolf. >> The context behind this change is that Firefox used to ship a=20 taskcluster/docker/firefox-snap/firefox.desktop file which had an=20 Exec line like this: Exec=3D@MOZ_APP_NAME@ %u The Guix package would use that file, replacing the token with the=20 path to the binary. The presence of %u in the package definition=20 is because the substitute* regexp is sloppy and replaces the whole=20 line instead of @MOZ_APP_NAME@ only. For reasons unknown to me,=20 Firefox stopped shipping this file and deleted it from their repo.=20 I looked around the repo and found=20 toolkit/mozapps/installer/linux/rpm/mozilla.desktop, for the rpm=20 package. Its Exec line is: Exec=3D@MOZ_APP_NAME@ So I updated the package to use that, and the regexp to match. The patch in #74648 looks fine to me, and I think it should be=20 pushed. Thanks, =E2=80=94 Ian