From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YESkDFE2bWezHwEAqHPOHw:P1 (envelope-from ) for ; Thu, 26 Dec 2024 10:56:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id YESkDFE2bWezHwEAqHPOHw (envelope-from ) for ; Thu, 26 Dec 2024 11:56:17 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=fAuCjo6L; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=SGV2mF1v; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735210576; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=6MzBHsURx/+2LIRp9wzv2MLSxMLwxf1V3ZLB6d1mmaI=; b=Li6eDNiWJYNeeHXbN7AupDewXghNOM8xtkaWJ3m19BDMFXyAXjEfiDQTzGMlpbTMtMj6PL WSSaCuCbAh1TzqoqYtPVbAwhZfu+pYbYAWTEJ/33i3TPmJq1eRC3wbN0NO6jM4PDg61q8G q7zlXFhZHfggjnydOGCc2294cmQOIQLrA1+nzS3PwDyqE6NqUh1tZmUghqewxkoxwWQcAB wVIZfKqoIi5KME27R65mXHiuGenajxD8e2PcfLzjIsvMb9nzYjh9tCmYwoI0jwav5rRGfm 8h+BPN9/NhFHBOk+QyWuWdlVhThEDYIj3k2FAEouy74dTVZuEKwpibI1WywdBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=fAuCjo6L; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=SGV2mF1v; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735210576; a=rsa-sha256; cv=none; b=TNPrX6gOcuE/7QImOtLqS7amZ9p/PAdcXxWwncgvHkbg5ldDLkQOYRXHxqZB7rLu/2Dqsp dNh5ilvfb+dzMiIlnq9mwB2C8jEvXroyTAyCYIYnFmucgaTO7Iscr6pM1KdH46x6FUADYi hjQEAaGIMjmeN9PHjHqm4SPFG2nUpUp7wSai9koPtWTtqabeZhZhDnN37KgV/ZbEs8B6Xl sdqH+4AFQvOgGZ2QNwcPIxcCuc6mFuup4HbzfBBdKBOHQbgimvyUqz3ow80KM7spFXlZC2 G2UAXbtm/I70XhhYIiC//3a8ryG8XuZO0POx7rTfhzd4iaTnmcmsbeJY2xmIIA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DDC5D84872 for ; Thu, 26 Dec 2024 11:56:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQlXC-0003Ku-An; Thu, 26 Dec 2024 05:56:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQlX8-0003Kc-SF for guix-patches@gnu.org; Thu, 26 Dec 2024 05:56:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tQlX8-00006w-5F for guix-patches@gnu.org; Thu, 26 Dec 2024 05:56:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=6MzBHsURx/+2LIRp9wzv2MLSxMLwxf1V3ZLB6d1mmaI=; b=fAuCjo6Lw43d9ppufUyuEIOc50tc1AkEFHm++cexV6knkrV/fUi11vTwMSkWRs3NAWUGxlGss1bT8wx4ng3YCaeN2693wEObQWLTXCKAaFaekQncegOivLFkp9MWbyn96M1VRy9ZgTuEE0H+1tg9LomzEL+s1bhRXqazuwriL6zvtqhpjnz7eLyBG5lmjNE+vis1kIjuLNbqC7/mTZ8Y3WfrLNy6on17G8JiLRheGxQdCX0pbYdAoCzcdTakguZWrfR3Zg5juRwaP9aogW3QrWlNxGtqswtcojz5OqC1OMYJAEMalaf64Pu83R0ClUuPurgXHoi7JsOYfiWafxMf+Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tQlX7-0007XF-Vv for guix-patches@gnu.org; Thu, 26 Dec 2024 05:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74962] [PATCH 3/3] etc/guix-install.sh: Fix quoting and other issues. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 Dec 2024 10:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74962 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Mathieu Othacehe , Josselin Poiret , 74962@debbugs.gnu.org, Janneke Nieuwenhuizen Received: via spool by 74962-submit@debbugs.gnu.org id=B74962.173521054728935 (code B ref 74962); Thu, 26 Dec 2024 10:56:01 +0000 Received: (at 74962) by debbugs.gnu.org; 26 Dec 2024 10:55:47 +0000 Received: from localhost ([127.0.0.1]:40226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQlWt-0007Wd-BX for submit@debbugs.gnu.org; Thu, 26 Dec 2024 05:55:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:32960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQlWr-0007WP-VT for 74962@debbugs.gnu.org; Thu, 26 Dec 2024 05:55:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQlWm-00005z-NW; Thu, 26 Dec 2024 05:55:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=6MzBHsURx/+2LIRp9wzv2MLSxMLwxf1V3ZLB6d1mmaI=; b=SGV2mF1vqEYJsbc5+QrN oPEqjvx1eoFbw/VUjHlVe5qDvFb/mn0elQcwWt1WWnSMBezx43q5o5G0TyfnMit+Yxm9ojW+5jccp MwZrybLAzb/l52DBnU6CETpGk4UKIvkY4LEzjuxoA/loWlkMnbtgq/jLxgxfKr9I0NMWWS+RAybQ5 1SvebX8nmYFXIi/G3wTX3WVqesoslsniT9G5kHb/ZL7kKiSRDJ1dl6qCkK6MyKuuwKHEwo194kO/9 pdpVSZqLFo9HPd90wdnVR1O8wuYnxKAJ9HkYM0UXagO5pKodmP7CIS2k4HxPaWtbNNFXYBK0VXOH/ PHfJD3ig/vkP3w==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <6b04713cc24b58ab4bbf4ac4060e4d57f7c8e1b3.1734592672.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Thu, 19 Dec 2024 16:17:52 +0900") References: <6b04713cc24b58ab4bbf4ac4060e4d57f7c8e1b3.1734592672.git.maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 =?UTF-8?Q?Niv=C3=B4se?= an 233 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la Lave X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 26 Dec 2024 11:55:37 +0100 Message-ID: <87cyhezpau.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -6.91 X-Spam-Score: -6.91 X-Migadu-Queue-Id: DDC5D84872 X-TUID: 7GJCoY11vdVF Maxim Cournoyer skribis: > This change fixes most issues reported by the 'shellcheck' command. > > * etc/guix-install.sh (add_init_sys_require): Use -n instead of ! -z. > (sys_create_build_user): Quote variable expansion. > (sys_delete_build_user): Likewise. > (sys_create_shell_completion): Likewise. > (sys_delete_user_profiles): Likewise. > (main): Replace $@ with $* inside string. > > Change-Id: Ia88509b461b3844f2dd5abf9fb21a5b2bbb8a1e1 LGTM.