On 2025-01-05, Gabriel Wicki wrote:
> This mainly addresses `double-space after sentence end period' and `trailing
> white space' issues.
>
> * gnu/packages/astronomy.scm (python-tweakwcs): Fix description.
...
> * gnu/packages/xfce.scm (xfce4-volumed-pulse): Fix description.
>
> Change-Id: Ic312ff450542cf6797e7e6ef7f80dea39d735af8
> ---
>  gnu/packages/astronomy.scm        |  2 +-
>  gnu/packages/audio.scm            |  8 ++--
>  gnu/packages/axoloti.scm          | 12 +++---
>  gnu/packages/bioinformatics.scm   |  4 +-
>  gnu/packages/check.scm            | 10 ++---
>  gnu/packages/chez.scm             | 14 +++----
>  gnu/packages/code.scm             |  2 +-
>  gnu/packages/compression.scm      |  4 +-
>  gnu/packages/connman.scm          |  2 +-
>  gnu/packages/cran.scm             | 34 ++++++++---------
>  gnu/packages/crates-graphics.scm  | 11 +++---
>  gnu/packages/crates-io.scm        |  8 ++--
>  gnu/packages/crypto.scm           |  9 ++---
>  gnu/packages/display-managers.scm |  2 +-
>  gnu/packages/docker.scm           |  2 +-
>  gnu/packages/emacs-xyz.scm        | 61 +++++++++++++++----------------
>  gnu/packages/freedesktop.scm      |  2 +-
>  gnu/packages/game-development.scm |  4 +-
>  gnu/packages/games.scm            |  2 +-
>  gnu/packages/geo.scm              |  2 +-
>  gnu/packages/gnunet.scm           | 10 ++---
>  gnu/packages/golang-check.scm     |  2 +-
>  gnu/packages/golang-web.scm       |  2 +-
>  gnu/packages/golang-xyz.scm       |  6 +--
>  gnu/packages/golang.scm           |  7 ++--
>  gnu/packages/haskell-check.scm    | 32 ++++++++--------
>  gnu/packages/haskell-web.scm      |  2 +-
>  gnu/packages/haskell-xyz.scm      | 12 +++---
>  gnu/packages/ipfs.scm             |  4 +-
>  gnu/packages/kodi.scm             |  7 ++--
>  gnu/packages/linux.scm            | 19 +++++-----
>  gnu/packages/lisp-xyz.scm         | 16 ++++----
>  gnu/packages/machine-learning.scm | 24 ++++++------
>  gnu/packages/messaging.scm        |  2 +-
>  gnu/packages/music.scm            | 11 +++---
>  gnu/packages/perl.scm             |  2 +-
>  gnu/packages/python-xyz.scm       |  6 +--
>  gnu/packages/qt.scm               |  5 ++-
>  gnu/packages/rocm.scm             |  6 +--
>  gnu/packages/scanner.scm          |  4 +-
>  gnu/packages/security-token.scm   |  6 +--
>  gnu/packages/shellutils.scm       |  4 +-
>  gnu/packages/tex.scm              | 50 ++++++++++++-------------
>  gnu/packages/textutils.scm        |  3 +-
>  gnu/packages/tor.scm              |  2 +-
>  gnu/packages/xdisorg.scm          |  8 ++--
>  gnu/packages/xfce.scm             |  4 +-
>  47 files changed, 224 insertions(+), 227 deletions(-)

This patch overall looks good, but I was unable to apply it to master.
This is probably due to changes in the master branch since you
originally wrote the patch.

Unfortunately, git am left me with zero changes applied to even attempt
partially applying! Possibly using "git format-patch
--base=origin/master" to generate the patches would help with this?

I would suggest breaking this patch up into a few smaller patches since
they touch so many files, conflicts are likely to arise, especially
breaking out the parts with larger diffs (e.g. tex.scm, emacs-xyz.scm,
haskell.scm, cran.scm, etc.) since these are the most likely to have
conflicts. Obviously, there is a balance to be struck, but hopefully
that is enough guidance to go on!

Then if a few do not apply, at least the rest can hopefully apply and be
merged incrementally...

live well,
  vagrant