unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Muriithi Frederick Muriuki <fredmanglis@gmail.com>,
	27558@debbugs.gnu.org
Subject: [bug#27558] [PATCH] gnu: Add python-ruamel.yaml
Date: Thu, 13 Jul 2017 21:47:47 +0200	[thread overview]
Message-ID: <87bmoojezg.fsf@fastmail.com> (raw)
In-Reply-To: <20170711231701.14368-1-fredmanglis@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

Muriithi Frederick Muriuki <fredmanglis@gmail.com> writes:

> * gnu/packages/python.scm (python-ruamel.yaml, python2-ruamel.yaml) New
> * variables.

Ugh, I'm afraid I have to bother you one more time on this one!

First, we're trying to reduce the amount of packages in python.scm. So I
think we should add it to "serialization.scm" instead, sorry for missing
that the first time around.

> +         (replace 'check
> +           (lambda* _
> +             (zero? (system* "bash" "-c" "py.test" "_test/test_*.py")))))))

This prints "collected 0 items...", which indicates it doesn't actually
run any tests. Looking closer, it seems tests are missing altogether
from the PyPi archive. Could you try downloading the tarball straight
from BitBucket instead?

> +    (home-page "https://bitbucket.org/ruamel/yaml")
> +    (synopsis "This is a YAML 1.2 parser/emitter")

s/This is a //

Again, sorry for the slow and incomplete feedback. I can try to do this
last improvement over the weekend if you're already tired of this patch.

Thanks for your contribution and patience! :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2017-07-13 19:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03  3:47 [bug#27558] [PATCH] gnu: Add python-ruamel.yaml Muriithi Frederick Muriuki
2017-07-11 19:21 ` Marius Bakke
2017-07-11 23:17 ` Muriithi Frederick Muriuki
2017-07-13 19:47   ` Marius Bakke [this message]
2017-07-13 19:53     ` Frederick Muriithi
2017-07-14 13:22 ` Muriithi Frederick Muriuki
2017-07-16 20:38   ` Marius Bakke
2017-07-16 20:39     ` Frederick Muriithi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmoojezg.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=27558@debbugs.gnu.org \
    --cc=fredmanglis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).