From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eC3PG-0004te-5P for guix-patches@gnu.org; Tue, 07 Nov 2017 07:55:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eC3PC-0003VP-0t for guix-patches@gnu.org; Tue, 07 Nov 2017 07:55:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:46609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eC3PB-0003VA-SK for guix-patches@gnu.org; Tue, 07 Nov 2017 07:55:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eC3PB-0000Ni-J7 for guix-patches@gnu.org; Tue, 07 Nov 2017 07:55:01 -0500 Subject: [bug#26647] Upgrade fabric to 1.13.2, remove upstreamed patch. Resent-Message-ID: References: <87fugxky57.fsf@sturm.com.au> <871ssgsk0e.fsf@elephly.net> <878tmom2tu.fsf@sturm.com.au> <87r2vqxcfx.fsf@gnu.org> <87k21cr6i9.fsf@gumble.sturm.com.au> From: Ben Sturmfels In-reply-to: <87k21cr6i9.fsf@gumble.sturm.com.au> Date: Tue, 07 Nov 2017 23:54:29 +1100 Message-ID: <87bmkefdve.fsf@sturm.com.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ricardo Wurmus , 26647@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On Wed, 06 Sep 2017, Ben Sturmfels wrote: > On Sat, 02 Sep 2017, Ludovic Courtès wrote: > >> Did you have a chance to look into this? >> (See for context.) It looks like Tobias beat me to the fabric 1.13.2 upgrade in f58be417 - thanks Tobias! But the build hanging issue Ricardo mentioned still remains. Should be fixed by the attached patch. I've re-added the "Requires < X.X" comments as I think these will help anyone trying to debug build problems if/when these dependencies are upgraded. If that's all ok, I can look at the upgrade to 0.14.0 in a separate patch. Regards, Ben -- Ben Sturmfels Sturm - Software Engineering www.sturm.com.au (03) 9024 2467 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-fabric-Disable-problematic-tests.patch >From 1a88d0aede4aee911617dc4ad5359d43a1193f22 Mon Sep 17 00:00:00 2001 From: Ben Sturmfels Date: Tue, 7 Nov 2017 23:37:38 +1100 Subject: [PATCH] gnu: fabric: Disable problematic tests. * gnu/packages/admin.scm (fabric): Add custom check phase to disable two tests. --- gnu/packages/admin.scm | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 7b8e41fce..dcc5ecbff 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -2122,11 +2122,24 @@ Intel DRM Driver.") "0k944dxr41whw7ib6380q9x15wyskx7fqni656icdn8rzshn9bwq")))) (build-system python-build-system) (arguments - `(#:python ,python-2)) ; Python 2 only + `(#:python ,python-2 ; Python 2 only + #:phases + (modify-phases %standard-phases + (replace 'check + (lambda _ + (zero? + (system* + "nosetests" "-v" "tests/" + ;; This test hangs indefinitely when run on a single core VM + ;; (see GNU bug #26647 and Debian bug #850230). + "--exclude=test_nested_execution_with_explicit_ports" + ;; This test randomly fails in certain environments causing too + ;; much noise to be useful (see Debian bug #854686). + "--exclude=test_should_use_sentinel_for_tasks_that_errored"))))))) (native-inputs - `(("python2-fudge" ,python2-fudge) - ("python2-jinja2" ,python2-jinja2) - ("python2-nose" ,python2-nose))) + `(("python2-fudge" ,python2-fudge) ; Requires < 1.0 + ("python2-jinja2" ,python2-jinja2) ; Requires < 3.0 + ("python2-nose" ,python2-nose))) ; Requires < 2.0 (propagated-inputs `(("python2-paramiko" ,python2-paramiko))) (home-page "http://fabfile.org") -- 2.14.2 --=-=-=--