From: ludo@gnu.org (Ludovic Courtès)
To: Rutger Helling <rhelling@mykolab.com>
Cc: 29210@debbugs.gnu.org
Subject: [bug#29210] [PATCH] gnu: messaging: Add libsignal-protocol-c and enable OMEMO for dino.
Date: Tue, 14 Nov 2017 23:46:19 +0100 [thread overview]
Message-ID: <87bmk4lbr8.fsf@gnu.org> (raw)
In-Reply-To: <5a2d4159793c664e2f6277b9ad0345f5@mykolab.com> (Rutger Helling's message of "Wed, 08 Nov 2017 11:38:00 +0100")
Hi Rutger,
Rutger Helling <rhelling@mykolab.com> skribis:
> From 4212f0c4ffe43464ed7bd2e9f1a8f10e308ec792 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Wed, 8 Nov 2017 11:16:29 +0100
> Subject: [PATCH] gnu: messaging: Add libsignal-protocol-c.
>
> * gnu/packages/messaging.scm (libsignal-protocol-c): New variable.
[...]
> + (arguments
> + `(#:tests? #f
> + ; Required for proper linking.
> + #:configure-flags '("-DBUILD_SHARED_LIBS=on")))
> + ; FIXME: With the below additional flags the tests pass, however this
> + ; causes problems with timestamps, therefore the tests are disabled for
> + ; now:
> + ; -DCMAKE_BUILD_TYPE=Debug
> + ; -DBUILD_TESTING=1
What are the timestamp issues you’re referring to above? It would be
nice if we could have our cake and eat it too. :-)
Besides, the default in ‘cmake-build-system’ is
“-DCMAKE_BUILD_TYPE=RelWithDebugInfo” (i.e., “-O2 -g”), and I think we
should keep it this way here.
Nipick: please use two semicolons for block comments like this (one
semicolon is for margin comments).
> + (home-page "https://github.com/WhisperSystems/libsignal-protocol-c")
> + (synopsis "Ratcheting forward secrecy protocol")
> + (description "libsignal-protocol-c is a ratcheting forward secrecy protocol
> +that works in synchronous and asynchronous messaging environments.")
Nitpicking here as well: it’s an /implementation/ of the protocol.
Could you also expound the description a little bit?
> + (license license:gpl3)))
Since source file headers don’t say anything particular, it’s ‘gpl3+’
(“or any later version”.)
Could you send an updated patch?
> From db99f5874d24e0aa3e74005bf7200f459451aeb7 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Wed, 8 Nov 2017 11:18:38 +0100
> Subject: [PATCH] gnu: messaging: Enable OMEMO for dino.
>
> * gnu/packages/messaging.scm (dino) Update to commit f6ac5bbd26638412a2289fd1d28ef12de1d7e8b5. [inputs]: Add libsignal-protocol-c, libgcrypt. [arguments]: Change #configure-flags to "-DSHARED_SIGNAL_PROTOCOL=yes".
OK!
Thank you,
Ludo’.
next prev parent reply other threads:[~2017-11-14 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 10:38 [bug#29210] [PATCH] gnu: messaging: Add libsignal-protocol-c and enable OMEMO for dino Rutger Helling
2017-11-14 22:46 ` Ludovic Courtès [this message]
2017-11-15 7:39 ` Rutger Helling
2017-11-16 8:51 ` bug#29210: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmk4lbr8.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29210@debbugs.gnu.org \
--cc=rhelling@mykolab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).