From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36922)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eFGwu-0003TQ-VY
	for guix-patches@gnu.org; Thu, 16 Nov 2017 04:59:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eFGwp-0007qV-VA
	for guix-patches@gnu.org; Thu, 16 Nov 2017 04:59:09 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33925)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eFGwp-0007pq-Rs
	for guix-patches@gnu.org; Thu, 16 Nov 2017 04:59:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eFGwo-0000Zi-Dj
	for guix-patches@gnu.org; Thu, 16 Nov 2017 04:59:03 -0500
Subject: [bug#29292] [PATCH] Scribus: Fix No module named _sysconfigdata_nd
Resent-Message-ID: <handler.29292.B29292.15108263012155@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87zi7pzque.fsf@nicolasgoaziou.fr>
Date: Thu, 16 Nov 2017 10:58:17 +0100
In-Reply-To: <87zi7pzque.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Tue, 14 Nov 2017 00:44:25 +0100")
Message-ID: <87bmk2ilza.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 29292@debbugs.gnu.org

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

>>>From 445ce30a90250d6c584a98ac60fddb4b96f1a3a7 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Tue, 14 Nov 2017 00:35:46 +0100
> Subject: [PATCH] gnu: scribus: Fix No module named _sysconfigdata_nd
>
> * gnu/packages/scribus.scm (scribus): Wrap PATH with expected Python arou=
nd
>   executable.
>
> This fixes #25035.

Please make it =E2=80=9CFixes <https://bugs.gnu.org/25035>.=E2=80=9D so we =
can more
easily grep the git log.

> +       (modify-phases %standard-phases
> +         (add-after 'install 'wrap-program
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             ;; Fix "ImportError: No module named _sysconfigdata_nd" whe=
re
> +             ;; Scribus checks PATH and eventually runs system's Python
> +             ;; instead of package's.
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (py2 (assoc-ref inputs "python")))
> +               (wrap-program (string-append out "/bin/scribus")
> +                 `("PATH" ":" prefix (,(string-append py2 "/bin")))))

Did you identify the part of the code that invokes =E2=80=9Cpython=E2=80=9D=
?  If so,
instead of adding a wrapper, we could patch that file to use the
absolute file name of =E2=80=9Cpython=E2=80=9D, which would be even better.

Anyway, congrats on finding out what was wrong!

Thanks,
Ludo=E2=80=99.