From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIK43-0006c3-Nm for guix-patches@gnu.org; Fri, 24 Nov 2017 14:55:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIK3y-0003T8-Ro for guix-patches@gnu.org; Fri, 24 Nov 2017 14:55:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:47700) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eIK3y-0003Si-Np for guix-patches@gnu.org; Fri, 24 Nov 2017 14:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eIK3y-0003tC-HP for guix-patches@gnu.org; Fri, 24 Nov 2017 14:55:02 -0500 Subject: bug#29403: [PATCH] gnu: gcl: Update snapshot. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Kei Kebreau References: <20171122190619.3505-1-kkebreau@posteo.net> <87fu95vwfx.fsf@gnu.org> <87fu94kdpk.fsf@posteo.net> <874lpkpt1c.fsf@gnu.org> Date: Fri, 24 Nov 2017 14:54:17 -0500 In-Reply-To: <874lpkpt1c.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 23 Nov 2017 22:46:39 +0100") Message-ID: <87bmjrjvva.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 29403-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Kei Kebreau skribis: > >>> Kei Kebreau skribis: >>> >>>> * gnu/packages/lisp.scm (gcl): Update to 2.6.12-1.5956140. >>>> [arguments]: Remove CFLAGS from make-flags; adjust pre-conf phase. >>>> [native-inputs]: Add which. >>> >>> Could you include a rationale for using a development snapshot? >>> Normally we=E2=80=99d stick to upstream releases, unless there=E2=80=99= s a good reason. >>> >>> Thanks, >>> Ludo=E2=80=99. >> >> The short story is that there is an issue with GCL's garbage collection >> when it gets built on hydra.gnu.org. > > Do you mean that substitutes disappeared? (I just tried and got > substitutes from berlin.guixsd.org.) > Sorry for not being clearer. I meant that the stratified garbage collection that GCL uses seems to have a non-reproducible memory protection issue right now. >> In the process of investigating this issue, I noticed that Camm >> Maguire, GCL maintainer, uses these development snapshots in the >> package he oversees for Debian. This specific snapshot is the latest >> one and is shipped in Debian unstable, but even stable uses a fairly >> recent GCL development snapshot. These snapshots are mainly small bug >> fixes and optimizations from the look of the GCL commit history. > > OK, that certainly justifies this patch. > > Nevertheless, we should also kindly invite them to publish these as > formal releases rather than giving Debian a special treatment. > I'll send a message to the GCL mailing list. >> If you think this update is permissible, how does the following commit >> message read: >> >> * gnu/packages/lisp.scm (gcl): Update to 2.6.12-1.5956140. >> [arguments]: Remove CFLAGS from make-flags; adjust pre-conf phase. >> [native-inputs]: Add which. >> >> This update includes small upstream bug fixes and optimizations. > > Sounds good, yes. > > Thanks for explaining! > > Ludo=E2=80=99. Pushed to master as dd0134fcb707452e1c343d66af6088c0be38a285. I also managed to avoid adding "which" as a build dependency by substituting paths to gcc, ld and objdump in GCL's top loop. Thanks for the review! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAloYeOoACgkQ5qXuPBlG eg0nexAAgHwHTk2ufEuX8x0Ce8jYZ2HQScKFjljKxvp8yo3lXLFGMAaYjot5x8Lj L/Q31xGUCjCfi6wf63pEdfZfo4Y1kPzUstHIFxh76zYSjM8VX3cJco3/X2/A7cqQ UKVFvdIIgf0tRLivSFWSvz5g5ZKE1fK0TIeF7Qrj4DKtf4JP5vazYmLffyYcMpel Ofm2OgO3zxFDkS5JRWIjy1dDlSZLbF9chyKQDOwrK/FhICi97Uyg1dEX110QsEPZ yXDyFT5t7qX5T5EKoupUPKWVJ7xp4NHISR1Co9cxbsEkBMLq2TR2LFFphyQQBIKL iTwNmJyhlSzTKAh+PCtipIjMU85HdmTXk1lZZhHvBb0NTSyEIJXZWNTge2QLquGR ENVWS2OF7nNtfVnS1IJVNHg+vraOyF0xEmiDH+O3DezCZt+P28KVwcYyaHgR8wQr dsYtwPWgi5dUNT9wCfGGNkBJAnxu5NZBIx26+PGO3RK79tDLzYRH2Po0O88GSgZ9 rPZEThWbDtH+KsEOJIXFzpmcn71V5yzn7OID4DY8HXXOm0uG1Gl7IIpE9cUz2QJ+ WnSqHbACf0cqsPONc27H2ioWFGrxN7kQdkP+882ttr945czu2zYlQF5Z8eQhG47y 0t1v7RFKZ6FOLeMeMMBM79HD2PJVvSL2qxzpIueJAg0Zs06YgoE= =1YyW -----END PGP SIGNATURE----- --=-=-=--