From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efSE5-0007ZJ-6V for guix-patches@gnu.org; Sat, 27 Jan 2018 10:17:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efSE2-0001nd-E3 for guix-patches@gnu.org; Sat, 27 Jan 2018 10:17:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:37476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efSE2-0001nX-Ao for guix-patches@gnu.org; Sat, 27 Jan 2018 10:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1efSE2-0005GZ-4x for guix-patches@gnu.org; Sat, 27 Jan 2018 10:17:02 -0500 Subject: [bug#30214] [PATCH 02/10] gnu: Add go-github.com-howeyc-gopass. Resent-Message-ID: References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122210830.28924-2-mail@cbaines.net> <20180122215306.GC15170@jasmine.lan> <87wp085ph3.fsf@cbaines.net> <20180123205123.GH6750@jasmine.lan> From: Christopher Baines In-reply-to: <20180123205123.GH6750@jasmine.lan> Date: Sat, 27 Jan 2018 15:16:35 +0000 Message-ID: <87bmhfs564.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 30214@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Tue, Jan 23, 2018 at 07:45:12PM +0000, Christopher Baines wrote: >>=20 >> Leo Famulari writes: >>=20 >> > On Mon, Jan 22, 2018 at 09:08:22PM +0000, Christopher Baines wrote: >> >> * gnu/packages/terminals.scm (go-github.com-howeyc-gopass): New varia= ble. >> > >> >> + (native-inputs >> >> + `(("go-golang.org-x-crypto-ssh-terminal" >> >> + ,go-golang.org-x-crypto-ssh-terminal))) >> > >> > Is it really just a native-input? Or could it need this library later, >> > at run-time? >>=20 >> Well, the package doesn't build without it, and as far as I can tell the >> store output doesn't reference it. I believe that >> go-golang.org-x-crypto-ssh-terminal is a dependency of >> go-github.com-howeyc-gopass, so if you're using >> go-github.com-howeyc-gopass, then you'll need >> go-golang.org-x-crypto-ssh-terminal. Maybe it should be a propagated >> input instead? > > Go looks for dependencies by first looking for their source code (this > is why the go-build-system installs the source code by default). Once it > finds the source code, then it looks up the compiled objects. > > Finally, when building the end-user application (not just some library) > it links everything together in what's basically a static archive. > > If everything seems to work even though x-crypto-ssh-terminal is a > native-input, then I bet that whatever is using howeyc-gopass does not > exercise the part of howeyc-gopass's code using x-crypto-ssh-terminal. > > I think it's more correct here to propagate, unless > x-crypto-ssh-terminal is only used for howeyc-gopass's test suite or > something like that. Ok, I've made it a propagated input, as I think it's more than a build time dependency. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKSBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpsl9NfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xcsnw/1FfDLH1bi+Fp23ZkUfuQlFh/Cb5xfb3UY4AflVUKd45IYhM9umtYzU8hE +EW80jZ4US969YY1zUGm0wyJw1ZGXFpdQSfYgpU2MGdjcR6anju4dI0HZh8017DB oseOW2NwGeUzSfb0lRTBH7hVW3BQ6T27ffJ9HOyW5kObX/BD+U9X1iv9uXRIP0Sl ZS936eKGPEeuT77OyjwrFGkZX07PT2H5lYOTzk6uOKLIctTvyl4mFggOMggKqqGX ZWZ8yNLe3TJVzd8ugTFJ5XPGvh+cqRVWY2ujghUX8+3S17J5Xjx+9StThWD/9i2G YYkGSDbb/XpmibRVy+JwYgXSA8w2XkTddbpPQb9/GBCTneYiNSSeCu+1W7mnWmMc YPyQETTHmaUNRRSwTkOuEac58Lr6UGQ4W5ptG9NVSESJi71qqr/xLdNKKyzlnze1 sKrZQt4cBkilJCAlZzxywbsdNr4qmKFvzwkCAWHnopOthBk6NYThuJ/LtdCsL00n Gfn0+QQrsG+lN0E94JVkn+CeReA2MZDDSiZMyW21mM/FSew9yzAYGzCzIIozGZ5A Pn1XigmdrCVUZYKCyodCIp/sGbiogCaO3MhaiXawUanFHs+a1YnhD7jh3P2llNo5 wWMXa76+Iec/9oyfx+x/0wluPiTGwMNi07zh3f2Q0kM/ahOqwQ== =7Qw3 -----END PGP SIGNATURE----- --=-=-=--