From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45068)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eh1IT-0001CS-Uh
	for guix-patches@gnu.org; Wed, 31 Jan 2018 17:56:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eh1IQ-0005wd-Tk
	for guix-patches@gnu.org; Wed, 31 Jan 2018 17:56:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:43733)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eh1IQ-0005wU-Pr
	for guix-patches@gnu.org; Wed, 31 Jan 2018 17:56:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eh1IQ-00026L-EG
	for guix-patches@gnu.org; Wed, 31 Jan 2018 17:56:02 -0500
Subject: [bug#30201] [PATCH] Fix Solfege configuration skeleton
Resent-Message-ID: <handler.30201.B30201.15174393608069@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87y3kqak23.fsf@nicolasgoaziou.fr>
Date: Wed, 31 Jan 2018 23:55:55 +0100
In-Reply-To: <87y3kqak23.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Mon, 22 Jan 2018 00:06:28 +0100")
Message-ID: <87bmh9r62s.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 30201@debbugs.gnu.org

Hey,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Currently, Guix Solfege package replaces, in the skeleton configuration,
> hard-coded filenames to various sound players with hard-coded filenames
> to the same players in the store. I think this is no good.
>
> The first time it is run, Solfege copies the skeleton configuration in
> home directory, as a dot file. However, at some point, possibly long
> after you forget about this detail, initial inputs are GC'ed, leaving
> non-existing filenames in a now broken configuration. Once you realize
> it, you need to find the new inputs in the store, rinse and repeat.

Heh.

> One option would be to move players to propagated-inputs. Since they do
> not prevent Solfege from building, however, I think simply removing them
> from the package is enough. One can always add them to their profile if
> needed.

Does Solfege look for them in $PATH?  If it does, providing just the
basename of these programs like your patch does is perfect IMO.

>>>From e30b919f03ad9b37123b96dc38c24d41e562a02a Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Sun, 21 Jan 2018 23:43:02 +0100
> Subject: [PATCH] gnu: solfege: Make configuration more robust to GC
>
> * gnu/packages/music.scm (solfege): Do not introduce store filenames in t=
he
> configuration skeleton.
> [inputs]: Remove optional players.

LGTM!

Thanks,
Ludo=E2=80=99.