From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58856)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fJEjd-0000Q9-VN
	for guix-patches@gnu.org; Thu, 17 May 2018 04:58:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fJEja-00065T-RQ
	for guix-patches@gnu.org; Thu, 17 May 2018 04:58:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58253)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fJEja-00065N-Ne
	for guix-patches@gnu.org; Thu, 17 May 2018 04:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fJEja-0007AK-E2
	for guix-patches@gnu.org; Thu, 17 May 2018 04:58:02 -0400
Subject: [bug#31462] [PATCH] profiles: Add hook to generate
	"gschemas.compiled".
Resent-Message-ID: <handler.31462.B31462.152654747127524@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180515124917.1751-1-dannym@scratchpost.org>
Date: Thu, 17 May 2018 10:57:37 +0200
In-Reply-To: <20180515124917.1751-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Tue, 15 May 2018 14:49:17 +0200")
Message-ID: <87bmde4q2m.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>, 31462@debbugs.gnu.org

Hello!

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * guix/profiles.scm (glib-schemas): New procedure.
> (%default-profile-hooks): Add it.

[...]

> +  (mlet %store-monad ((%glib (manifest-lookup-package manifest "glib"))
> +                      ;; XXX: Can't use glib-compile-schemas correspondi=
ng
> +                      ;; to the glib referenced by 'manifest'.  Because
> +                      ;; '%glib' can be either a package or store path, =
and
> +                      ;; there's no way to get the "bin" output for the =
later.
> +                      (glib-compile-schemas
> +                       -> #~(string-append #+glib:bin
> +                                           "/bin/glib-compile-schemas")))

Oh right, too bad.

=E5=AE=8B=E6=96=87=E6=AD=A6, any comments, since you wrote the existing hoo=
ks in that area?

Otherwise LGTM, thank you Danny!

Ludo=E2=80=99.