From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXvh0-0001Ch-By for guix-patches@gnu.org; Tue, 26 Jun 2018 17:40:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXvgx-00017I-8z for guix-patches@gnu.org; Tue, 26 Jun 2018 17:40:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57003) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXvgx-00016h-0l for guix-patches@gnu.org; Tue, 26 Jun 2018 17:40:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fXvgw-0003sO-I5 for guix-patches@gnu.org; Tue, 26 Jun 2018 17:40:02 -0400 Subject: [bug#31957] [PATCH] gnu: Add python-libusb1. Resent-Message-ID: From: Marius Bakke In-Reply-To: <8736xanm8j.fsf@aikidev.net> References: <87r2kwne89.fsf@aikidev.net> <877emmejjg.fsf@fastmail.com> <8736xanm8j.fsf@aikidev.net> Date: Tue, 26 Jun 2018 23:39:46 +0200 Message-ID: <87bmbxxm59.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vagrant Cascadian , 31957@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Vagrant Cascadian writes: > On 2018-06-25, Marius Bakke wrote: >> Vagrant Cascadian writes: >> >>> Add new package definition for python-libusb1, needed to upgrade >>> python-trezor to newer versions. >> >> Thanks! I have some minor nitpicks: > ... >> Can you send an updated patch? Thanks in advance! > > Updated patch attached: > > - Add myself to copyright headers > - Drop unused srfi-26 > - Remove needless line break > - Flesh out description a bit... > - Remove COPYING file, which didn't match the licensing of the files > > The removal of COPYING was pretty much a shotgun-style approach, but I > couldn't figure out how to do a more surgical removal, and there weren't > any other COPYING files in the source. > > The description could probably be further improved... but that's as far > as I got for now... :) Thanks! Applied with these cosmetic changes (mostly to please `guix lint`): --=-=-= Content-Type: text/x-patch Content-Disposition: inline 1 file changed, 5 insertions(+), 5 deletions(-) gnu/packages/libusb.scm | 10 +++++----- modified gnu/packages/libusb.scm @@ -235,9 +235,9 @@ implementing @code{javax.usb} (JSR-80).") (modify-phases %standard-phases (add-before 'install-license-files 'remove-incorrect-license (lambda* (#:key out #:allow-other-keys) - ;; Was reliscensed to LGPL 2.1+, but old COPYING file still left + ;; Was relicensed to LGPL 2.1+, but old COPYING file still left ;; in source. Remove it so it does not get installed. - (delete-file-recursively "COPYING") + (delete-file "COPYING") #t)) (add-after 'unpack 'fix-libusb-reference (lambda* (#:key inputs #:allow-other-keys) @@ -251,11 +251,11 @@ implementing @code{javax.usb} (JSR-80).") "\""))) #t))))) (inputs `(("libusb" ,libusb))) - (home-page "http://github.com/vpelletier/python-libusb1") + (home-page "https://github.com/vpelletier/python-libusb1") (synopsis "Pure-python wrapper for libusb-1.0") (description "Libusb is a library that gives applications easy access to -USB devices on various operating systems. This is a python wrapper for -acessing libusb-1.0") +USB devices on various operating systems. This package provides a Python +wrapper for accessing libusb-1.0.") (license lgpl2.1+))) (define-public python-pyusb [back] --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsysqIACgkQoqBt8qM6 VPpYzwf+IfdgY4onnQFMw64h3JhsvgNya2K6wCv76CopxTYmS0NqReFLQSFWbkH/ gFrwHEgAGWKpxmYvoWi6/syX20R8DlU2herHy3ALVFxMA42fT22/TsNu7+Yu7LfN bKswhVMCCdHsLDFoFGfHjgoQSYBujTXnhWoI4/c8NgJgnpsf0g4bu0memlyL9ju7 HeWHfyw1AAigUYf4osMP5u4+sYu0J0lZ5VK47eqmdS0+KvBb8028g5IBm5ybg9lZ 5Ea3w5lduXK0wlCS60GDH5m/k4nZEjyGMG2Ytge3JboFCrp3q1unCige4/tU5e42 zo9P6H3UD5NT6h42IuXFrKnlaz/IUg== =ptSR -----END PGP SIGNATURE----- --==-=-=--