From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fapwV-0006ke-Rb for guix-patches@gnu.org; Wed, 04 Jul 2018 18:08:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fapwQ-0004N9-P5 for guix-patches@gnu.org; Wed, 04 Jul 2018 18:08:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fapwQ-0004Mr-KV for guix-patches@gnu.org; Wed, 04 Jul 2018 18:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fapwQ-00036L-7A for guix-patches@gnu.org; Wed, 04 Jul 2018 18:08:02 -0400 Subject: [bug#31955] [PATCH] gnu: rust: support build with glibc-2.27, update to 1.26.2 Resent-Message-ID: From: Nikolai Merinov References: <87in68i6b2.fsf@member.fsf.org> <20180704093137.js36pzgp7w3foe5p@abyayala> <87fu0z72nl.fsf@lassieur.org> <87fu0z899i.fsf@member.fsf.org> <20180704174502.7be766b5@scratchpost.org> Date: Thu, 05 Jul 2018 03:07:09 +0500 In-Reply-To: <20180704174502.7be766b5@scratchpost.org> (Danny Milosavljevic's message of "Wed, 4 Jul 2018 17:45:02 +0200") Message-ID: <87bmbm8xki.fsf@member.fsf.org> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 31955@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Lassieur , Nils Gillmann Hi Danny, In this case we should use "// ignore-test" comment as described in https://github.com/rust-lang/rust/blob/1.23.0/src/test/COMPILER_TESTS.md#ignoring-tests I checked: build passed succesfully with this 2 patches applied on top of b53a0c882d02ebc8fefc87faa6945cd90fe1d4ae commit. Regards, Nikolai Danny Milosavljevic writes: > Hi Nikolai, > > I get a test failure after I applied both patches and then invoke "guix package -i rust". > > egrep 'starting phase|build-started' RR > @ build-started > /gnu/store/zbc701kksgw26g0ckzkhixvjrmqayrjb-rust-1.23.0.drv - > x86_64-linux > /var/log/guix/drvs/zb//c701kksgw26g0ckzkhixvjrmqayrjb-rust-1.23.0.drv.bz2 > starting phase `set-SOURCE-DATE-EPOCH' > starting phase `set-paths' > starting phase `install-locale' > starting phase `unpack' > starting phase `dont-build-native' > starting phase `patch-tests' > starting phase `patch-cargo-tests' > starting phase `fix-mtime-bug' > starting phase `set-env' > starting phase `bootstrap' > starting phase `patch-usr-bin-file' > starting phase `patch-source-shebangs' > starting phase `patch-cargo-checksums' > starting phase `configure' > starting phase `patch-generated-file-shebangs' > starting phase `reset-timestamps-after-changes' > starting phase `build' > starting phase `check' > > > failures: > [run-pass] run-pass/out-of-stack.rs > > The phase that should have patched this test out never ran. I checked > the source file, it doesn't have the "// ignore-test" part. > > I'll take a closer look later but can you check on your side too? > > (Also, what's the deal with those comment directives? Isn't there #[ignore] instead?)