From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53850)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g4T5j-0002G9-Iq
	for guix-patches@gnu.org; Mon, 24 Sep 2018 11:48:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g4T5e-0003v0-Km
	for guix-patches@gnu.org; Mon, 24 Sep 2018 11:48:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:48001)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1g4T5e-0003ur-GE
	for guix-patches@gnu.org; Mon, 24 Sep 2018 11:48:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g4T5e-0000Vx-2q
	for guix-patches@gnu.org; Mon, 24 Sep 2018 11:48:02 -0400
Subject: [bug#32785] [PATCH] services: wpa-supplicant: Extend to support
	configuration parameters.
Resent-Message-ID: <handler.32785.B32785.15378040391919@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180920154214.4418-1-mbakke@fastmail.com>
Date: Mon, 24 Sep 2018 17:47:05 +0200
In-Reply-To: <20180920154214.4418-1-mbakke@fastmail.com> (Marius Bakke's
	message of "Thu, 20 Sep 2018 17:42:14 +0200")
Message-ID: <87bm8muccm.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 32785@debbugs.gnu.org

Hello,

Marius Bakke <mbakke@fastmail.com> skribis:

> This allows using WPA Supplicant "standalone" without an additional
> network manager.  The default configuration is unchanged.
>
> * gnu/services/networking.scm (<wpa-supplicant-configuration>): New recor=
d type.
> (wpa-supplicant-shepherd-service): Pass configuration records to the daem=
on.
> (wpa-supplicant-service-type): Adjust accordingly.
> * doc/guix.texi (Networking Services): Document the new service type.

[...]

> +@deftp {Data Type} wpa-supplicant-manager-configuration
                                     ^
Should be =E2=80=98wpa-supplicant-configuration=E2=80=99.

> +    (service-type (name 'wpa-supplicant)
> +                  (extensions
> +                   (list (service-extension shepherd-root-service-type
> +                                            wpa-supplicant-shepherd-serv=
ice)
> +                         (service-extension dbus-root-service-type confi=
g->package)
> +                         (service-extension profile-service-type config-=
>package)))
> +                  (default-value (wpa-supplicant-configuration)))))

While you=E2=80=99re at it you can add a =E2=80=98description=E2=80=99 fiel=
d.  :-)

I haven=E2=80=99t tested it but it LGTM.

Thank you!

Ludo=E2=80=99.