unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Vong <alexvong1995@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 33347@debbugs.gnu.org, alexvong1995@gmail.com
Subject: [bug#33347] [PATCH 3/4] gnu: Add json-parser.
Date: Wed, 14 Nov 2018 21:14:03 +0800	[thread overview]
Message-ID: <87bm6r3ip0.fsf@gmail.com> (raw)
In-Reply-To: <20181113164749.GA8498@jasmine.lan> (Leo Famulari's message of "Tue, 13 Nov 2018 11:47:49 -0500")

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Nov 12, 2018 at 03:09:04AM +0800, Alex Vong wrote:
>> From 6696a1dd8c69b9349c4897d1ce5b73d585d9f077 Mon Sep 17 00:00:00 2001
>> From: Alex Vong <alexvong1995@gmail.com>
>> Date: Mon, 12 Nov 2018 02:23:27 +0800
>> Subject: [PATCH 2/4] gnu: Add json-parser.
>> 
>> * gnu/packages/web.scm (json-parser): New variable.
>
>> +    (arguments '(#:tests? #f))
>
> Please add a comment explaining why we skip the tests. If there are no
> tests, it can be as simple as "No test suite.".
>
OK

>> +    (description "Very low footprint JSON parser written in portable ANSI C.
>
> Please use a complete sentence. For example, "This package provides a
> very low footprint ...".

The description was copied from upstream, but of course we can improve
it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2018-11-14 13:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 19:03 [bug#33347] [PATCH 0/4] gnu: teeworlds: Update to 0.7.0 [fixes CVE-2018-18541] Alex Vong
2018-11-11 19:06 ` [bug#33347] [PATCH 1/4] gnu: Add pnglite Alex Vong
2018-11-11 19:07 ` [bug#33347] [PATCH 2/4] gnu: Add json-parser Alex Vong
2018-11-13 16:49   ` Leo Famulari
2018-11-14 13:19     ` Alex Vong
2018-11-11 19:09 ` [bug#33347] [PATCH 3/4] " Alex Vong
2018-11-13 16:47   ` Leo Famulari
2018-11-14 13:14     ` Alex Vong [this message]
2018-11-11 19:09 ` [bug#33347] [PATCH 4/4] gnu: teeworlds: Update to 0.7.0 [fixes CVE-2018-18541] Alex Vong
2018-11-13 16:53   ` Leo Famulari
2018-11-14 13:36     ` Alex Vong
2018-11-14 17:39       ` Leo Famulari
2018-11-14 21:14         ` Alex Vong
     [not found]           ` <87va4q7at7.fsf@gmail.com>
2018-11-21 16:14             ` Leo Famulari
2018-11-11 19:13 ` [bug#33347] [PATCH 0/4] " Alex Vong
2018-11-13 16:54 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm6r3ip0.fsf@gmail.com \
    --to=alexvong1995@gmail.com \
    --cc=33347@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).