From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:60577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1FAZ-00046b-85 for guix-patches@gnu.org; Tue, 05 Mar 2019 13:52:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1FAY-0007bR-Es for guix-patches@gnu.org; Tue, 05 Mar 2019 13:52:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48135) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1FAY-0007Zx-7q for guix-patches@gnu.org; Tue, 05 Mar 2019 13:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1FAY-0004lR-2V for guix-patches@gnu.org; Tue, 05 Mar 2019 13:52:02 -0500 Subject: [bug#34650] [PATCH 7/7] gnu: Add mailcatcher. Resent-Message-ID: References: <87ftsa24ts.fsf@ambrevar.xyz> <20190228174435.14499-1-mail@ambrevar.xyz> <20190228174435.14499-7-mail@ambrevar.xyz> <87fts2fgxe.fsf@cbaines.net> <87y35tvgav.fsf@ambrevar.xyz> From: Christopher Baines In-reply-to: <87y35tvgav.fsf@ambrevar.xyz> Date: Tue, 05 Mar 2019 18:51:02 +0000 Message-ID: <87bm2pf949.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 34650@debbugs.gnu.org --=-=-= Content-Type: text/plain Pierre Neidhardt writes: > Thanks for the review! > >> I'd recommend trying to avoid inserting packages at the end of modules, >> or generally in the same place. This can make rebases difficult, and >> increase the chances of conflicts when going to apply patches. I >> generally try to fit patches in to modules somewhat alphabetically. > > You are very true here, but currently ruby.scm seems to follow no order > whatsoever. Not sure where to insert the new packages then. Well, it's in no strict order. One approach I normally use is to start at the top and work my way down, and fit packages in just below the first thing that's before them in the alphabet. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlx+xRZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdeFRAArbfgzQHcLdxCRkaay7mVXsL5Np/fqsirysTVdjm1sPb5EcHBCileN+j9 1J/GotpYWCb8KyrpwOh6LdzNhTjk6C9+JhSLqVi3xiAQCMAbNGGDl1VfHf8jKiz+ 5Xm6fHfR2ZdZbUu0ti/tTndtzLqob4hVLFjAi3lw/QP1mDRw9ORYUPn3rukLhnlS MBdrm2jToct2TqSXl5XxWkX/sC9xWifYxvtl0YXHRvVENsOhxe6qcnIOX/ZmHnQ+ vA9otsE7QdAGJYaMm4w4cjsrNbjpDCUoALOwvCeT9YAE/VxZ1ENIq6gR4pNAeSCf UPkOziPvNk8SsB42BcE18snAwz8Y7sUCNlSyBU5F7/7fsd+QMBRblBYvrlL/MLJQ 1gZIOeoPf6Jo8KhgXluakojRP8vdNeBvQOmSUkHdfNMDPl53uusStWUBK9DDHm36 ksYhxXyVtNqy7Q/3ynCiFmn7HaFJY+26r6yvrE33NYBZoTaYvcSUx4T0PFRS9GPP yZTjJo/GgFhxUl1qmmmjlPnxUhGTV30KorH+CB0IPDGti9M+hhaqgNi2EGZTWush lpNa2RInJOM+v+wEVZwHb6HOUeLkuI3XaTktJ1osMNF4XPJaS4YzkB5Z676094t0 UXtK18SG0Nt+dxP7li847WyBjnfnnIG9Y1li2/c2hVI9q7BXXG8= =cNum -----END PGP SIGNATURE----- --=-=-=--