From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:41278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4vdH-0001vA-3p
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:48:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4vQo-0008Qs-Le
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:36:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:60286)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h4vQo-0008Qf-BF
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:36:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4vQo-0005Kr-6o
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:36:02 -0400
Subject: bug#34859: [PATCH] pack: "-RR" produces PRoot-enabled relocatable
	binaries.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.34859.D34859.155268930320428.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190314161026.15696-1-ludo@gnu.org> <87wol015uk.fsf@elephly.net>
Date: Fri, 15 Mar 2019 23:34:53 +0100
In-Reply-To: <87wol015uk.fsf@elephly.net> (Ricardo Wurmus's message of "Fri,
	15 Mar 2019 17:04:51 +0100")
Message-ID: <87bm2b22cy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 34859-done@debbugs.gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> * gnu/packages/aux-files/run-in-namespace.c (exec_with_proot): New
>> function.
>> (main): When 'clone' fails, call 'rm_rf'.
>> [PROOT_PROGRAM]: When 'clone' fails, call 'exec_with_proot'.
>> * guix/scripts/pack.scm (wrapped-package): Add #:proot?.
>> [proot]: New procedure.
>> [build]: Compile with -DPROOT_PROGRAM when PROOT? is true.
>> * guix/scripts/pack.scm (%options): Set the 'relocatable?' value to
>> 'proot when "-R" is passed several times.
>> (guix-pack): Pass #:proot? to 'wrapped-package'.
>> * tests/guix-pack-relocatable.sh: Use "-RR" on Intel systems that lack
>> user namespace support.
>> * doc/guix.texi (Invoking guix pack): Document -RR.
>
> This is great!
>
> So, the only downside to using =E2=80=9C-RR=E2=80=9D is that it=E2=80=99s=
 1MB heavier than =E2=80=9C-R=E2=80=9D
> due to the included proot-static?=20=20

Yes!  But note that our =E2=80=98proot-static=E2=80=99 package currently fa=
ils to build
on ARM.

> Neat!

Pushed as 99aec37a78e7be6a591d0e5b7439896d669a75d1, thanks!

Ludo=E2=80=99.