From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:45911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hH9Ar-0005PA-Os
	for guix-patches@gnu.org; Thu, 18 Apr 2019 11:42:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hH9Aq-0007uZ-OV
	for guix-patches@gnu.org; Thu, 18 Apr 2019 11:42:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57021)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hH9Aq-0007uC-Kp
	for guix-patches@gnu.org; Thu, 18 Apr 2019 11:42:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hH9Aq-0002bW-Hs
	for guix-patches@gnu.org; Thu, 18 Apr 2019 11:42:04 -0400
Subject: [bug#35288] [PATCH 1/3] gnu: Add dumb.
Resent-Message-ID: <handler.35288.B35288.15556020889942@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190415135134.31839-1-kkebreau@posteo.net>
Date: Thu, 18 Apr 2019 17:41:18 +0200
In-Reply-To: <20190415135134.31839-1-kkebreau@posteo.net> (Kei Kebreau's
	message of "Mon, 15 Apr 2019 09:51:34 -0400")
Message-ID: <87bm13qq1t.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 35288@debbugs.gnu.org

Hello,

Kei Kebreau <kkebreau@posteo.net> skribis:

> * gnu/packages/music.scm (dumb): New variable.

[...]

> +    (home-page "https://github.com/kode54/dumb")
> +    (synopsis "Module audio renderer library")
> +    (description
> +     "DUMB is a tracker library with support for IT, XM, S3M and MOD fil=
es.  It
> +targets maximum accuracy to the original formats, with low-pass resonant=
 filters
> +for the IT files, accurate timing and pitching, and three resampling qua=
lity
> +settings (aliasing, linear interpolation and cubic interpolation).")
> +    (license (license:fsf-free "file://LICENSE"))))

This looks good, but the license deserves close reading (which I haven=E2=
=80=99t
done).  What=E2=80=99s your interpretation of it?  It would be nice to put a
comment above to summarize our findings.

> +(define-public vcvrack
> +  (package
> +    (name "vcvrack")
> +    (version "0.6.2b")

What=E2=80=99s this doin=E2=80=99 here?  :-)

Thanks,
Ludo=E2=80=99.