From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36455) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcyGT-0005pC-Iv for guix-patches@gnu.org; Mon, 17 Jun 2019 16:30:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcyGQ-0004vL-Vu for guix-patches@gnu.org; Mon, 17 Jun 2019 16:30:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcyGQ-0004uy-RD for guix-patches@gnu.org; Mon, 17 Jun 2019 16:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcyGQ-0003wn-Jn for guix-patches@gnu.org; Mon, 17 Jun 2019 16:30:02 -0400 Subject: [bug#36043] [PATCH] Add Geany Resent-Message-ID: From: Nicolas Goaziou References: <87muj1vvds.fsf@nicolasgoaziou.fr> <877e9zu4p2.fsf@nicolasgoaziou.fr> <87ef3yqw9o.fsf@nicolasgoaziou.fr> Date: Mon, 17 Jun 2019 22:29:03 +0200 In-Reply-To: (Arun Isaac's message of "Sat, 15 Jun 2019 12:51:33 +0530") Message-ID: <87blywrm5s.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 36043@debbugs.gnu.org Hello, Arun Isaac writes: >> I actually packaged scintilla > The scintilla package is not producing a shared library > (libscintilla.so). That is why you were not able to link it to geany. It > took a bit of substitute* surgery of the makefiles, but I managed to get > this working. Please see my attached patches. Thank you for keeping the ball rolling! > Ideally, we should get scintilla and geany upstreams to support > unbundling. Could you raise these issues upstream? I have bad news: see=20 https://sourceforge.net/p/scintilla/feature-requests/555/ It may not be worth to unbundle Scintilla, then. Guix has no proper way to use inputs' static libraries in a package? > The scintilla license is the ISC license. See > https://directory.fsf.org/wiki/License:ISC This doesn't look right. See https://www.scintilla.org/License.txt This is not ISC. > The headers should be installed in /include, not in > /include/scintilla. The libraries should be installed in /lib, not in > /lib/scintilla. Hmm I think I made the same mistake in nauty=E2=80=A6 because I saw another packages doing it too. So there are at least 2 other packages in the code base doing the same. > The changes specified in the comments above are also included in the > attached patches. Please feel free to refine my patches as required. Since then, Scintilla team released 4.1.7. WDYT? Regards, --=20 Nicolas Goaziou