From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40207@debbugs.gnu.org
Subject: [bug#40207] [PATCH 2/2] tests: install: Add %test-gui-installed-desktop-os-encrypted.
Date: Wed, 25 Mar 2020 22:41:11 +0100 [thread overview]
Message-ID: <87blokgljc.fsf@gnu.org> (raw)
In-Reply-To: <87d090nwr7.fsf@gmail.com> (Mathieu Othacehe's message of "Wed, 25 Mar 2020 18:57:00 +0100")
Hi!
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
>> What about making a separate OS definition for the desktop installation
>> case? We’d move the ‘os’ variable to the top-level and add an ‘os’
>> parameter to ‘guided-installation-test’.
>>
>> Having two separate OS definitions (one for desktop install, one for
>> “bare-bones” install) should be clearer than having a single definition
>> with conditionals.
>
> I fixed all your remarks. But there's still an issue, the size of the
> installation image is guessed badly in "run-install" for
> "%test-gui-installed-desktop-os-encrypted"
>
> (image (system-disk-image
> (operating-system-with-gc-roots
> os (list target))
> #:disk-image-size 'guess ;guess is too low.
> #:file-system-type
> installation-disk-image-file-system-type)))
>
>
> applying the dirty snippet below fixes it, but you may have a better idea?
>
> --- a/gnu/build/vm.scm
> +++ b/gnu/build/vm.scm
> @@ -233,7 +233,7 @@ deduplicates files common to CLOSURE and the rest of PREFIX."
> "Return the estimated size of a partition that can store the store items
> given by GRAPHS, a list of file names produced by #:references-graphs."
> ;; Simply add a 25% overhead.
> - (round (* 1.25 (closure-size graphs))))
> + (round (* 1.30 (closure-size graphs))))
Weird, the 25% hack had always worked fine.
I don’t have a better idea though. Perhaps it’s better to pass an
explicit size in ‘run-install’ than to modify the 25% hack above?
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-03-25 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 8:34 [bug#40207] [PATCH 0/2] Add a desktop graphical installer test Mathieu Othacehe
2020-03-24 8:36 ` [bug#40207] [PATCH 1/2] installer: tests: Use a filter to select desktop-environments Mathieu Othacehe
2020-03-24 8:36 ` [bug#40207] [PATCH 2/2] tests: install: Add %test-gui-installed-desktop-os-encrypted Mathieu Othacehe
2020-03-24 10:38 ` Ludovic Courtès
2020-03-25 17:57 ` Mathieu Othacehe
2020-03-25 21:41 ` Ludovic Courtès [this message]
2020-03-26 10:54 ` Mathieu Othacehe
2020-03-24 10:31 ` [bug#40207] [PATCH 1/2] installer: tests: Use a filter to select desktop-environments Ludovic Courtès
2020-03-24 10:35 ` Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blokgljc.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40207@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).