From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QHNPL5yjw16PewAA0tVLHw (envelope-from ) for ; Tue, 19 May 2020 09:15:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CD06K5yjw14tegAAB5/wlQ (envelope-from ) for ; Tue, 19 May 2020 09:15:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29A84940145 for ; Tue, 19 May 2020 09:15:08 +0000 (UTC) Received: from localhost ([::1]:36080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jayL3-0004vo-Kr for larch@yhetil.org; Tue, 19 May 2020 05:15:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jayL0-0004vb-Sp for guix-patches@gnu.org; Tue, 19 May 2020 05:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jayL0-0002pm-JY for guix-patches@gnu.org; Tue, 19 May 2020 05:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jayL0-0006cV-DZ for guix-patches@gnu.org; Tue, 19 May 2020 05:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 May 2020 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41350 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Jan \(janneke\) Nieuwenhuizen" Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 41350@debbugs.gnu.org Received: via spool by 41350-submit@debbugs.gnu.org id=B41350.158987967525400 (code B ref 41350); Tue, 19 May 2020 09:15:02 +0000 Received: (at 41350) by debbugs.gnu.org; 19 May 2020 09:14:35 +0000 Received: from localhost ([127.0.0.1]:49182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jayKY-0006bb-Mv for submit@debbugs.gnu.org; Tue, 19 May 2020 05:14:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jayKW-0006bP-Gu for 41350@debbugs.gnu.org; Tue, 19 May 2020 05:14:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47305) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jayKP-0002WD-6o; Tue, 19 May 2020 05:14:25 -0400 Received: from [2a01:e0a:fa:a50:7004:8043:e0bd:6eda] (port=35926 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jayKO-0007vp-NT; Tue, 19 May 2020 05:14:25 -0400 From: Mathieu Othacehe References: <20200519072302.9202-1-janneke@gnu.org> <20200519072302.9202-3-janneke@gnu.org> Date: Tue, 19 May 2020 11:14:23 +0200 In-Reply-To: <20200519072302.9202-3-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 19 May 2020 09:23:02 +0200") Message-ID: <87blmkthg0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: oklt+qQbxync Hello Janneke, > + #$(if (hurd-target?) > + #~#+(grub-root-search store-device font-file) > + (grub-root-search store-device font-file)) > + #$(if (hurd-target?) > + #~#+(setup-gfxterm config font-file) > + (setup-gfxterm config font-file)) I'm not certain that hurd-target? always return the expected answer here. Now that we have let-system, the safer way to check for the target system could be to write: --8<---------------cut here---------------start------------->8--- #$(let-system (system target) (hurd-target? system target)) --8<---------------cut here---------------end--------------->8--- Ludo, is this correct? Furthermore, if you make sure that "grub-root-search" and "setup-gfxterm" return #+, you could maybe drop this part? > + > + (loader #$(if (hurd-target?) #~#+loader loader)) > + (linux #$(if (hurd-target?) > + #~(string-append > + #+linux "/" > + #+(system-linux-image-file-name)) > + #~(string-append > + #$linux "/" > + #$(system-linux-image-file-name)))) Same concern as above about "hurd-target?". > + ;; (if #$(hurd-target?) > + ;; '#+(append (list parted e2fsprogs dosfstools) > + ;; (map canonical-package > + ;; (list sed grep coreutils findutils gawk))) > + ;; '#$(append (list parted e2fsprogs dosfstools) > + ;; (map canonical-package > + ;; (list sed grep coreutils findutils gawk)))) > + ) Is this needed? Thanks, Mathieu