* [bug#41551] [PATCH] gnu: Add emacs-bm.
@ 2020-05-26 23:41 Michael Rohleder
2020-05-30 11:50 ` Marius Bakke
0 siblings, 1 reply; 4+ messages in thread
From: Michael Rohleder @ 2020-05-26 23:41 UTC (permalink / raw)
To: 41551
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1: [PATCH] gnu: Add emacs-bm. --]
[-- Type: text/x-patch, Size: 1546 bytes --]
From edd01faf84a59499a9a83b336d55828aadd6bfa3 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Wed, 27 May 2020 01:37:42 +0200
Subject: [PATCH] gnu: Add emacs-bm.
* gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
---
gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b99acb7815..34afc73d8e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1860,6 +1860,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlinks and doing full-text
searches. Unlike code@{emacs-wiki.el}, it can be combined with any format.")
(license license:gpl1+)))
+(define-public emacs-bm
+ (package
+ (name "emacs-bm")
+ (version "201905")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/joodland/bm.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/joodland/bm")
+ (synopsis "Visual Bookmarks for Emacs")
+ (description "This package provides visible, buffer local, bookmarks and
+the ability to jump forward and backward to the next bookmark.")
+ (license license:gpl2+)))
+
(define-public emacs-calfw
(package
(name "emacs-calfw")
--
2.26.2
[-- Attachment #1.2: Type: text/plain, Size: 63 bytes --]
--
There are three kinds of people: men, women, and unix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#41551] [PATCH] gnu: Add emacs-bm.
2020-05-26 23:41 [bug#41551] [PATCH] gnu: Add emacs-bm Michael Rohleder
@ 2020-05-30 11:50 ` Marius Bakke
2020-05-30 17:55 ` Michael Rohleder
0 siblings, 1 reply; 4+ messages in thread
From: Marius Bakke @ 2020-05-30 11:50 UTC (permalink / raw)
To: Michael Rohleder, 41551
[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]
Michael Rohleder <mike@rohleder.de> writes:
> From edd01faf84a59499a9a83b336d55828aadd6bfa3 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Wed, 27 May 2020 01:37:42 +0200
> Subject: [PATCH] gnu: Add emacs-bm.
>
> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
Thanks! It LGTM but no longer applies, can you rebase it on the current
master branch?
> +(define-public emacs-bm
> + (package
> + (name "emacs-bm")
> + (version "201905")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/joodland/bm.git")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/joodland/bm")
> + (synopsis "Visual Bookmarks for Emacs")
^^^
Lowercase 'b'.
> + (description "This package provides visible, buffer local, bookmarks and
> +the ability to jump forward and backward to the next bookmark.")
The description reads a bit weird, I wonder if...
"visible, buffer local bookmarks" (without the second comma)
...is more correct?
Can you send an updated patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#41551] [PATCH] gnu: Add emacs-bm.
2020-05-30 11:50 ` Marius Bakke
@ 2020-05-30 17:55 ` Michael Rohleder
2020-05-30 21:16 ` bug#41551: " Marius Bakke
0 siblings, 1 reply; 4+ messages in thread
From: Michael Rohleder @ 2020-05-30 17:55 UTC (permalink / raw)
To: Marius Bakke; +Cc: 41551
[-- Attachment #1.1: Type: text/plain, Size: 713 bytes --]
Hi Marius,
you have an impressive pensum!
Thanks for the review!
Marius Bakke <marius@gnu.org> writes:
>> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
>
> Thanks! It LGTM but no longer applies, can you rebase it on the current
> master branch?
done.
>> + (synopsis "Visual Bookmarks for Emacs")
> ^^^
> Lowercase 'b'.
done.
>> + (description "This package provides visible, buffer local, bookmarks and
>> +the ability to jump forward and backward to the next bookmark.")
>
> The description reads a bit weird, I wonder if...
>
> "visible, buffer local bookmarks" (without the second comma)
>
> ...is more correct?
seems more correct, yes => done.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH] gnu: Add emacs-bm. --]
[-- Type: text/x-patch, Size: 1545 bytes --]
From b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Sat, 30 May 2020 19:50:02 +0200
Subject: [PATCH] gnu: Add emacs-bm.
* gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
---
gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6d82e1921c..9cf4cdd6a1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1918,6 +1918,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlinks and doing full-text
searches. Unlike code@{emacs-wiki.el}, it can be combined with any format.")
(license license:gpl1+)))
+(define-public emacs-bm
+ (package
+ (name "emacs-bm")
+ (version "201905")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/joodland/bm.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/joodland/bm")
+ (synopsis "Visual bookmarks for Emacs")
+ (description "This package provides visible, buffer local bookmarks and
+the ability to jump forward and backward to the next bookmark.")
+ (license license:gpl2+)))
+
(define-public emacs-calfw
(package
(name "emacs-calfw")
--
2.26.2
[-- Attachment #1.3: Type: text/plain, Size: 338 bytes --]
--
In short, I think gcc should be fixed, or at the very least it should be a
_documented_ bug at which point I have no gripe with fixing it in the
kernel. But I refuse to work around undocumented bugs - that starts to
smell too much like microsoft, and then I might as well start using
Windows myself.
Linus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#41551: [PATCH] gnu: Add emacs-bm.
2020-05-30 17:55 ` Michael Rohleder
@ 2020-05-30 21:16 ` Marius Bakke
0 siblings, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2020-05-30 21:16 UTC (permalink / raw)
To: Michael Rohleder; +Cc: 41551-done
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
Michael Rohleder <mike@rohleder.de> writes:
> Hi Marius,
>
> you have an impressive pensum!
Heh, not sure if that's meant as a compliment, but I'll take it. ;-)
> Thanks for the review!
You are welcome!
[...]
> From b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Sat, 30 May 2020 19:50:02 +0200
> Subject: [PATCH] gnu: Add emacs-bm.
>
> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
Applied, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-30 21:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 23:41 [bug#41551] [PATCH] gnu: Add emacs-bm Michael Rohleder
2020-05-30 11:50 ` Marius Bakke
2020-05-30 17:55 ` Michael Rohleder
2020-05-30 21:16 ` bug#41551: " Marius Bakke
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).