From: Mathieu Othacehe <othacehe@gnu.org>
To: "Jakub Kądziołka" <kuba@kadziolka.net>
Cc: 41637@debbugs.gnu.org
Subject: [bug#41637] [PATCH] gnu: Add hashcash.
Date: Wed, 03 Jun 2020 08:55:39 +0200 [thread overview]
Message-ID: <87blm07i50.fsf@gnu.org> (raw)
In-Reply-To: <20200601004015.21684-1-kuba@kadziolka.net> ("Jakub \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\= message of "Mon, 1 Jun 2020 02:40:15 +0200")
Hey Jakub,
Thanks for fixing the cross-compilation, a full review this time :)
> + (let* ((outdir (assoc-ref outputs "out"))
> + (bindir (string-append outdir "/bin"))
> + (mandir (string-append outdir "/share/man/man1"))
> + (docdir (string-append outdir "/share/doc/hashcash-" ,version)))
> + ;; make install assumes /usr and doesn't provide a way to override it
> + (install-file "hashcash" bindir)
> + (install-file "hashcash.1" mandir)
> + (install-file "README" docdir)
> + (install-file "LICENSE" docdir)
> + (install-file "CHANGELOG" docdir)
I think you can set the variables INSTALL_PATH, MAN_INSTALL_PATH and
DOC_INSTALL_PATH instead.
> + #t))))))
> + (home-page "https://www.hashcash.org/")
> + (synopsis "Denial-of-service countermeasure")
> + (description "Hashcash is a proof-of-work algorithm, which has been used
> +as a denial-of-service countermeasure technique in a number of systems.
You can remove "in a number of systems".
> +A hashcash stamp constitutes a proof-of-work which takes a parametrizable
> +amount of work to compute for the sender. The recipient can verify received
> +hashcash stamps efficiently.
> +
> +This package contains a command-line tool for computing and verifying hashcash
> +stamps.")
> + (license license:public-domain)))
I'm also concerned by this line in the Makefile:
--8<---------------cut here---------------start------------->8---
# request static link of -lcrypto only
LIBCRYPTO=/usr/lib/libcrypto.a
--8<---------------cut here---------------end--------------->8---
We should maybe add "openssl" to the inputs and fix this variable
(that's what Nix does).
Thanks,
Mathieu
next prev parent reply other threads:[~2020-06-03 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 0:40 [bug#41637] [PATCH] gnu: Add hashcash Jakub Kądziołka
2020-06-02 12:12 ` Mathieu Othacehe
2020-06-02 13:25 ` Jakub Kądziołka
2020-06-03 6:55 ` Mathieu Othacehe [this message]
2020-06-03 12:18 ` Jakub Kądziołka
2020-06-03 12:30 ` Mathieu Othacehe
2020-06-06 14:39 ` Jakub Kądziołka
2020-06-20 21:29 ` bug#41637: Done: " Jakub Kądziołka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blm07i50.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=41637@debbugs.gnu.org \
--cc=kuba@kadziolka.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).