From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UG9tBZSp414PYwAA0tVLHw (envelope-from ) for ; Fri, 12 Jun 2020 16:13:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6HImAZSp414xOwAAbx9fmQ (envelope-from ) for ; Fri, 12 Jun 2020 16:13:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C592940CBF for ; Fri, 12 Jun 2020 16:13:07 +0000 (UTC) Received: from localhost ([::1]:37178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjmIk-0003aC-Cc for larch@yhetil.org; Fri, 12 Jun 2020 12:13:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjmIg-0003Yh-Nw for guix-patches@gnu.org; Fri, 12 Jun 2020 12:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjmIg-0002HX-Eo for guix-patches@gnu.org; Fri, 12 Jun 2020 12:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jjmIg-0007Qe-9A for guix-patches@gnu.org; Fri, 12 Jun 2020 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41360] [PATCH v4 01/12] gnu: java-openjfx-graphics: Implement a complete compilation. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Jun 2020 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexey Abramov Cc: 41360@debbugs.gnu.org, Julien Lepiller Received: via spool by 41360-submit@debbugs.gnu.org id=B41360.159197835228499 (code B ref 41360); Fri, 12 Jun 2020 16:13:02 +0000 Received: (at 41360) by debbugs.gnu.org; 12 Jun 2020 16:12:32 +0000 Received: from localhost ([127.0.0.1]:40475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjmI9-0007PY-1G for submit@debbugs.gnu.org; Fri, 12 Jun 2020 12:12:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjmI6-0007PH-MJ for 41360@debbugs.gnu.org; Fri, 12 Jun 2020 12:12:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38453) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjmI0-0002CY-7v; Fri, 12 Jun 2020 12:12:20 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=55068 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jjmHy-0004Tt-5l; Fri, 12 Jun 2020 12:12:19 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200607155518.1400-1-levenson@mmer.org> <20200607155518.1400-2-levenson@mmer.org> Date: Fri, 12 Jun 2020 18:12:16 +0200 In-Reply-To: <20200607155518.1400-2-levenson@mmer.org> (Alexey Abramov's message of "Sun, 7 Jun 2020 17:55:07 +0200") Message-ID: <87bllo5km7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: qaVjgjqRF0K4 Hi Alexey, Alexey Abramov skribis: > * gnu/packages/java.scm (java-openjfx-graphics): Add stages to build > libdecora_sse, prism_common, glassgtk2, iio, prism_sw, prism_es2, > font_freetype, glassgtk3, font, font_pango and glass libraries. > > All the steps were taken by inspecting ./gradlew build --info result. Could you add it in a comment? So essentially all these phases and the unrolled and translated version of what Gradle would do, right? > Signed-off-by: Alexey Abramov > --- > gnu/packages/java.scm | 642 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 634 insertions(+), 8 deletions(-) I guess it=E2=80=99s still =E2=80=9Csource=E2=80=9D, but that=E2=80=99s a l= ot of it. Do you think there are ways this could be factorized? I=E2=80=99m not sayi= ng we have to do this right away, but we should probably keep in mind if we want to ensure the long-term maintainability of this package. > + ;; XX: Description can be found in build.gradle:1429. Current= ly I think you can remove =E2=80=9CXX=E2=80=9D, but description of what? Prob= ably a bit more context would be fine. > + (mkdir-p prism-gen-src) > + (for-each (lambda (file) > + (apply invoke "java" > + "-cp" (string-join (list > + ;; For CompileJSL > + prism-compilers-= classes > + ;; jsl files are= there > + prism-src > + (getenv "CLASSPA= TH")) > + ":") > + "CompileJSL" > + "-i" prism-src > + "-o" prism-gen-src > + "-t" > + "-pkg" "com/sun/prism" > + "-d3d" > + "-es2" > + "-name" (list file))) Problem is we won=E2=80=99t know where those flags come from, right? Perha= ps there=E2=80=99s additional info the Gradle build files? > + (add-after 'compile-decora-compilers 'generate-decora-shaders > + (lambda _ > + (let ((classes "modules/graphics/build/classes/java/main") > + (decora-classes "modules/graphics/build/classes/jsl= -decora/") > + (decora-compilers-classes "modules/graphics/build/c= lasses/jsl-compilers/decora") > + (decora-gen-src "modules/graphics/build/generated-s= rc/jsl-decora") > + (decora-src "modules/graphics/src/main/jsl-decora/") > + (decora-components '([(file-name . "ColorAdjust") > + (generator . "CompileJSL") > + (outputs . "-all")] > + [(file-name . "Brightpass") > + (generator . "CompileJSL") > + (outputs . "-all")] > + [(file-name . "SepiaTone") > + (generator . "CompileJSL") > + (outputs . "-all")] > + [(file-name . "PerspectiveTran= sform") > + (generator . "CompileJSL") > + (outputs . "-all")] > + [(file-name . "DisplacementMap= ") > + (generator . "CompileJSL") > + (outputs . "-all")] > + [(file-name . "InvertMask") > + (generator . "CompileJSL") > + (outputs . "-all")] > + [(file-name . "Blend") > + (generator . "CompileBlend") > + (outputs . "-all")] > + [(file-name . "PhongLighting") > + (generator . "CompilePhong") > + (outputs . "-all")] > + [(file-name . "LinearConvolve") > + (generator . "CompileLinearCo= nvolve") > + (outputs . "-hw")] > + [(file-name . "LinearConvolveS= hadow") > + (generator . "CompileLinearCo= nvolve") > + (outputs . "-hw")]))) We should at least have a comment explaining where that list comes from and what it means. I appreciate the huge amount of work you put into this, but I=E2=80=99m concerned about maintainability. Julien, what are the prospects of getting Gradle in Guix? What are your thoughts here? Thanks, Ludo=E2=80=99.