unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#43722] Add emacs-gcmh package
@ 2020-09-30 13:38 Niklas Eklund
  2020-09-30 15:59 ` [bug#43722] [PATCH] gnu: Add emacs-gcmh Niklas Eklund
  2020-10-01 12:32 ` [bug#43722] Add emacs-gcmh package Nicolas Goaziou
  0 siblings, 2 replies; 5+ messages in thread
From: Niklas Eklund @ 2020-09-30 13:38 UTC (permalink / raw)
  To: 43722

[-- Attachment #1: Type: text/plain, Size: 67 bytes --]


Add package that alters the garbage collection strategy in Emacs.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Content --]
[-- Type: text/x-patch, Size: 1753 bytes --]

From 0f7a1a461f99462276087c872479c3aafa0c12a4 Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Wed, 30 Sep 2020 15:34:36 +0200
Subject: [PATCH] gnu: Add emacs-gcmh.

* gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 13471f77d1..25b37d57c8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1768,6 +1768,31 @@ always indented.  It reindents after every change, making it more reliable
 than @code{electric-indent-mode}.")
     (license license:gpl2+)))
 
+(define-public emacs-gcmh
+  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
+        (revision "0"))
+    (package
+      (name "emacs-gcmh")
+      (version (git-version "0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://gitlab.com/koral/gcmh")
+               (commit commit)))
+         (sha256
+          (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
+         (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/koral/gcmh")
+      (synopsis
+       "The GNU Emacs Garbage Collector Magic Hack")
+      (description
+       "This package enforces a sneaky Garbage Collection strategy to minimize
+GC interference with the activity.  During normal use a high GC threshold is
+set.  When idling GC is immediately triggered and a low threshold is set.")
+      (license license:gpl3+))))
+
 (define-public emacs-ctrlf
   (package
     (name "emacs-ctrlf")
-- 
2.28.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#43722] [PATCH] gnu: Add emacs-gcmh.
  2020-09-30 13:38 [bug#43722] Add emacs-gcmh package Niklas Eklund
@ 2020-09-30 15:59 ` Niklas Eklund
  2020-10-01 12:32 ` [bug#43722] Add emacs-gcmh package Nicolas Goaziou
  1 sibling, 0 replies; 5+ messages in thread
From: Niklas Eklund @ 2020-09-30 15:59 UTC (permalink / raw)
  To: 43722


retitle 43722




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#43722] Add emacs-gcmh package
  2020-09-30 13:38 [bug#43722] Add emacs-gcmh package Niklas Eklund
  2020-09-30 15:59 ` [bug#43722] [PATCH] gnu: Add emacs-gcmh Niklas Eklund
@ 2020-10-01 12:32 ` Nicolas Goaziou
  2020-10-01 19:32   ` Niklas Eklund
  1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2020-10-01 12:32 UTC (permalink / raw)
  To: Niklas Eklund; +Cc: 43722

Hello,

Niklas Eklund <niklas.eklund@posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.

Thank you.

Some comments follow.

> +(define-public emacs-gcmh
> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
> +        (revision "0"))

Could you add a comment explaining why we're providing a specific commit
instead of a tagged release?

> +    (package
> +      (name "emacs-gcmh")
> +      (version (git-version "0.1" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://gitlab.com/koral/gcmh")
> +               (commit commit)))
> +         (sha256
> +          (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
> +         (file-name (git-file-name name version))))
> +      (build-system emacs-build-system)
> +      (home-page "https://gitlab.com/koral/gcmh")
> +      (synopsis
> +       "The GNU Emacs Garbage Collector Magic Hack")

The string should be moved on the same line as `synopsis'. Also:

  Emacs Garbage Collector Magic Hack

is enough.

> +      (description
> +       "This package enforces a sneaky Garbage Collection strategy to minimize

I suggest 

  ... a sneaky @dfn{garbage collector} (GC) strategy to minimize...

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#43722] Add emacs-gcmh package
  2020-10-01 12:32 ` [bug#43722] Add emacs-gcmh package Nicolas Goaziou
@ 2020-10-01 19:32   ` Niklas Eklund
  2020-10-14  9:24     ` bug#43722: " Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Niklas Eklund @ 2020-10-01 19:32 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 43722

[-- Attachment #1: Type: text/plain, Size: 1829 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Niklas Eklund <niklas.eklund@posteo.net> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
>
> Thank you.
>
> Some comments follow.
>
>> +(define-public emacs-gcmh
>> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
>> +        (revision "0"))
>
> Could you add a comment explaining why we're providing a specific commit
> instead of a tagged release?

I couldn't find a taged release on gitlab so I picked the most recent
commit. Upon looking closer there is not official tag to be found but in
the package it says version 0.1. What is the proper way of naming the
git version in this case? I changed it in this new patch to 0.0.0. Feel
free to change if it doesn't make sense.

>> +    (package
>> +      (name "emacs-gcmh")
>> +      (version (git-version "0.1" revision commit))
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://gitlab.com/koral/gcmh")
>> +               (commit commit)))
>> +         (sha256
>> +          (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
>> +         (file-name (git-file-name name version))))
>> +      (build-system emacs-build-system)
>> +      (home-page "https://gitlab.com/koral/gcmh")
>> +      (synopsis
>> +       "The GNU Emacs Garbage Collector Magic Hack")
>
> The string should be moved on the same line as `synopsis'. Also:
>
>   Emacs Garbage Collector Magic Hack
>
> is enough.
>
>> +      (description
>> +       "This package enforces a sneaky Garbage Collection strategy to minimize
>
> I suggest 
>
>   ... a sneaky @dfn{garbage collector} (GC) strategy to minimize...
>
> Could you send an updated patch?

Good suggestions, I have addressed them and here is a new patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Content --]
[-- Type: text/x-patch, Size: 1753 bytes --]

From 0feb4bd289c7bab7b82e4d2f37fc7247acda6f6e Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Wed, 30 Sep 2020 15:34:36 +0200
Subject: [PATCH v2] gnu: Add emacs-gcmh.

* gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 13471f77d1..575ee25308 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1768,6 +1768,31 @@ always indented.  It reindents after every change, making it more reliable
 than @code{electric-indent-mode}.")
     (license license:gpl2+)))
 
+(define-public emacs-gcmh
+  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
+        (revision "0"))
+    (package
+      (name "emacs-gcmh")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://gitlab.com/koral/gcmh")
+               (commit commit)))
+         (sha256
+          (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
+         (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/koral/gcmh")
+      (synopsis "Emacs Garbage Collector Magic Hack")
+      (description
+       "This package enforces a sneaky @dfn{garbage collector} (GC) strategy
+to minimize GC interference with the activity.  During normal use a high GC
+threshold is set.  When idling GC is immediately triggered and a low threshold
+is set.")
+      (license license:gpl3+))))
+
 (define-public emacs-ctrlf
   (package
     (name "emacs-ctrlf")
-- 
2.28.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#43722: Add emacs-gcmh package
  2020-10-01 19:32   ` Niklas Eklund
@ 2020-10-14  9:24     ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2020-10-14  9:24 UTC (permalink / raw)
  To: Niklas Eklund; +Cc: 43722-done, Nicolas Goaziou

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

Hi Niklas,

Niklas Eklund <niklas.eklund@posteo.net> skribis:

>>From 0feb4bd289c7bab7b82e4d2f37fc7247acda6f6e Mon Sep 17 00:00:00 2001
> From: Niklas Eklund <niklas.eklund@posteo.net>
> Date: Wed, 30 Sep 2020 15:34:36 +0200
> Subject: [PATCH v2] gnu: Add emacs-gcmh.
>
> * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.

Looks like this addresses the comments Nicolas made, except for the
comment about the lack of a tagged release, so I went ahead and applied
it with the following change.

Thanks!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 620 bytes --]

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index df22fbcc9a..0ac4c73ac7 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1771,11 +1771,12 @@ than @code{electric-indent-mode}.")
     (license license:gpl2+)))
 
 (define-public emacs-gcmh
+  ;; No tagged release upstream.
   (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
         (revision "0"))
     (package
       (name "emacs-gcmh")
-      (version (git-version "0.0.0" revision commit))
+      (version (git-version "0.1" revision commit))
       (source
        (origin
          (method git-fetch)

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-14  9:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 13:38 [bug#43722] Add emacs-gcmh package Niklas Eklund
2020-09-30 15:59 ` [bug#43722] [PATCH] gnu: Add emacs-gcmh Niklas Eklund
2020-10-01 12:32 ` [bug#43722] Add emacs-gcmh package Nicolas Goaziou
2020-10-01 19:32   ` Niklas Eklund
2020-10-14  9:24     ` bug#43722: " Ludovic Courtès

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git