unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Noah Landis <noahlandis@posteo.net>
Cc: 44495-done@debbugs.gnu.org
Subject: bug#44495: [PATCH] gnu: Add emacs-monokai-theme.
Date: Sat, 07 Nov 2020 10:47:35 +0100	[thread overview]
Message-ID: <87blg9jy6g.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20201106233904.GA10011@comp> (Noah Landis's message of "Fri, 6 Nov 2020 16:39:04 -0700")

Hello,

Noah Landis <noahlandis@posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-monokai-theme.

Thank you!

I "fixed" the commit message, which should be:

    gnu: Add emacs-monokai-theme.

    * gnu/packages/emacs-xyz.scm (emacs-monokai-theme): New variable.

If you use Yasnippets, you can simply type "update" + TAB in an empty
commit buffer.

Also I suggest to insert new packages elsewhere than at the very end of
the "emacs-xyz.scm" file, as this location is prone to introduce merge
conflicts.

> +    (description
> +     "Monokai theme is a port of the popular TextMate Monokai theme for Emacs.
> +It uses built-in theming support available in Emacs 24 or later.")

I removed the last sentence, which is not useful in our context (Guix
provides Emacs 27).

Patch applied.

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2020-11-07  9:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 23:39 [bug#44495] [PATCH] gnu: Add emacs-monokai-theme Noah Landis
2020-11-07  9:47 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blg9jy6g.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=44495-done@debbugs.gnu.org \
    --cc=noahlandis@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).