From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uGIGBwjruF+UOAAA0tVLHw (envelope-from ) for ; Sat, 21 Nov 2020 10:25:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id xHbWAgjruF/oTwAAB5/wlQ (envelope-from ) for ; Sat, 21 Nov 2020 10:25:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 479A09403CA for ; Sat, 21 Nov 2020 10:25:11 +0000 (UTC) Received: from localhost ([::1]:56706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgQ4r-0002FW-5x for larch@yhetil.org; Sat, 21 Nov 2020 05:25:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgQ4k-0002En-OF for guix-patches@gnu.org; Sat, 21 Nov 2020 05:25:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgQ4k-0001uf-Fm for guix-patches@gnu.org; Sat, 21 Nov 2020 05:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kgQ4k-0000Y2-Cy for guix-patches@gnu.org; Sat, 21 Nov 2020 05:25:02 -0500 Subject: bug#40367: [PATCH v3] lint: Display result of checkers on stdout. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 21 Nov 2020 10:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 40367 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 40367-done@debbugs.gnu.org Mail-Followup-To: 40367@debbugs.gnu.org, mail@cbaines.net, brice@waegenei.re Received: via spool by 40367-done@debbugs.gnu.org id=D40367.16059542822071 (code D ref 40367); Sat, 21 Nov 2020 10:25:02 +0000 Received: (at 40367-done) by debbugs.gnu.org; 21 Nov 2020 10:24:42 +0000 Received: from localhost ([127.0.0.1]:44920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgQ4P-0000XK-O3 for submit@debbugs.gnu.org; Sat, 21 Nov 2020 05:24:41 -0500 Received: from mira.cbaines.net ([212.71.252.8]:49182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgQ4N-0000XC-At for 40367-done@debbugs.gnu.org; Sat, 21 Nov 2020 05:24:40 -0500 Received: from localhost (188.28.108.199.threembb.co.uk [188.28.108.199]) by mira.cbaines.net (Postfix) with ESMTPSA id A566127BBF6; Sat, 21 Nov 2020 10:24:38 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id a727b0a3; Sat, 21 Nov 2020 10:24:36 +0000 (UTC) References: <20200401073835.5890-1-brice@waegenei.re> <20200521190838.29736-1-brice@waegenei.re> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <20200521190838.29736-1-brice@waegenei.re> Date: Sat, 21 Nov 2020 10:24:36 +0000 Message-ID: <87blfrhusb.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: tuQn0Ut5pIGK --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Brice Waegeneire writes: > * guix/scripts/lint.scm (emit-warnings): Use 'current-output-port' > instead of 'current-error-port'. > --- > > This version remove an extra space and correctly indent the patch. > > guix/scripts/lint.scm | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm > index 97ffd57301..5445645b53 100644 > --- a/guix/scripts/lint.scm > +++ b/guix/scripts/lint.scm > @@ -10,6 +10,7 @@ > ;;; Copyright =C2=A9 2017, 2018 Efraim Flashner > ;;; Copyright =C2=A9 2018, 2019 Arun Isaac > ;;; Copyright =C2=A9 2019 Simon Tournier > +;;; Copyright =C2=A9 2020 Brice Waegeneire > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -47,11 +48,15 @@ > ;; provided MESSAGE. > (for-each > (lambda (lint-warning) > - (let ((package (lint-warning-package lint-warning)) > - (loc (lint-warning-location lint-warning))) > - (info loc (G_ "~a@~a: ~a~%") > - (package-name package) (package-version package) > - (lint-warning-message lint-warning)))) > + (let* ((package (lint-warning-package lint-warning)) > + (name (package-name package)) > + (version (package-version package)) > + (loc (lint-warning-location lint-warning)) > + (message (lint-warning-message lint-warning))) > + (parameterize > + ((guix-warning-port (current-output-port))) > + (info loc (G_ "~a@~a: ~a~%") > + name version message)))) > warnings)) >=20=20 > (define* (run-checkers package checkers #:key store) Thanks, and apologies in the delay in looking at this again. I've pushed it to master as becfa42ea79feb402fe6bc5922da2019ef021e88.q Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+46uRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdaeA//TQChYqjA1hDqIGgSLOSOH5KUWad5BjEb Q9b1Zcf1wQOVR0Dt05Rw/LRO5oBR7WRKLlWy5rGicSwCx2cmTiLONZ4n75MbMRsY ZiPHN7nI7WlYeIV5tjyOYvHtfhK7+eTA91bmhbQTceD3fNB3MJjrc92lUjKeacoy x5J3cto5wJy3D0WWW+YNR0DgNGakeNGfCagVsRftvmmv5yzk6FdrKW3dfQPJoN94 e5gwdvHR0HqJRPKvLdtzV5+AO/f47jb/ao+aPxnnB6jxVd+7XoSb9KEpJorQ3sYJ ZwGfsKuKHIG98JlAefsURYQPP6vOM3vlVzWpwK54/eNktcfBTyifsdiLQ4cT5sLb o44LWCab3vHaWH6BrDRGOSdqePAsBJUTBQORMU/qQ5pkBa81rIi73o6tVSGldtzM UUlLQ8uxIO9QBV7XhVbbTUgOhbJVYfwrHkKSoPNqSKasjfrwGA2LI5bx9f5z2zO2 +NGHESBZDPFCQGc/AKwlYarxnhcawfH6y1CUnQSTix988FO09lBtlGTcz1K2SwMO 6npVJo/ItokXX7OCQjip4qV1Jia81bnqPYkcZSFVVwMuZGk6HVUNKDxVjA6x7bC/ FKQtqLThPyVLbsgEA+Lx560cxmTxLG++KVPjYWXivt+d8aEp9gcbNR6uv/zlv5cQ n117n3J8W4o= =SPSa -----END PGP SIGNATURE----- --=-=-=--