From: Christopher Baines <mail@cbaines.net>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 40367-done@debbugs.gnu.org
Subject: bug#40367: [PATCH v3] lint: Display result of checkers on stdout.
Date: Sat, 21 Nov 2020 10:24:36 +0000 [thread overview]
Message-ID: <87blfrhusb.fsf@cbaines.net> (raw)
In-Reply-To: <20200521190838.29736-1-brice@waegenei.re>
[-- Attachment #1: Type: text/plain, Size: 1941 bytes --]
Brice Waegeneire <brice@waegenei.re> writes:
> * guix/scripts/lint.scm (emit-warnings): Use 'current-output-port'
> instead of 'current-error-port'.
> ---
>
> This version remove an extra space and correctly indent the patch.
>
> guix/scripts/lint.scm | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
> index 97ffd57301..5445645b53 100644
> --- a/guix/scripts/lint.scm
> +++ b/guix/scripts/lint.scm
> @@ -10,6 +10,7 @@
> ;;; Copyright © 2017, 2018 Efraim Flashner <efraim@flashner.co.il>
> ;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@systemreboot.net>
> ;;; Copyright © 2019 Simon Tournier <zimon.toutoune@gmail.com>
> +;;; Copyright © 2020 Brice Waegeneire <brice@waegenei.re>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -47,11 +48,15 @@
> ;; provided MESSAGE.
> (for-each
> (lambda (lint-warning)
> - (let ((package (lint-warning-package lint-warning))
> - (loc (lint-warning-location lint-warning)))
> - (info loc (G_ "~a@~a: ~a~%")
> - (package-name package) (package-version package)
> - (lint-warning-message lint-warning))))
> + (let* ((package (lint-warning-package lint-warning))
> + (name (package-name package))
> + (version (package-version package))
> + (loc (lint-warning-location lint-warning))
> + (message (lint-warning-message lint-warning)))
> + (parameterize
> + ((guix-warning-port (current-output-port)))
> + (info loc (G_ "~a@~a: ~a~%")
> + name version message))))
> warnings))
>
> (define* (run-checkers package checkers #:key store)
Thanks, and apologies in the delay in looking at this again.
I've pushed it to master as becfa42ea79feb402fe6bc5922da2019ef021e88.q
Thanks again,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
prev parent reply other threads:[~2020-11-21 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 7:38 [bug#40367] [PATCH] lint: Display result of checkers on stdout Brice Waegeneire
2020-04-01 12:25 ` Tobias Geerinckx-Rice via Guix-patches via
2020-04-01 13:21 ` Brice Waegeneire
2020-04-21 8:58 ` Brice Waegeneire
2020-04-01 13:19 ` [bug#40367] [PATCH v2] " Brice Waegeneire
2020-05-21 19:08 ` [bug#40367] [PATCH v3] " Brice Waegeneire
2020-11-21 10:24 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blfrhusb.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=40367-done@debbugs.gnu.org \
--cc=brice@waegenei.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).