unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: John Soo <jsoo1@asu.edu>
To: Matthew Kraai <kraai@ftbfs.org>
Cc: 42295@debbugs.gnu.org
Subject: [bug#42295] [PATCH] gnu: rust-1.44: Add rustfmt output.
Date: Wed, 25 Nov 2020 06:46:42 -0800	[thread overview]
Message-ID: <87blfltrxp.fsf@asu.edu> (raw)
In-Reply-To: <20200709123256.7690-1-kraai@ftbfs.org> (Matthew Kraai's message of "Thu, 9 Jul 2020 05:32:56 -0700")

Hi Matthew,

Thanks! I had packaged rustfmt-nightly but this is much better.

Matthew Kraai <kraai@ftbfs.org> writes:

> +             (replace 'check
> +               (lambda* _
> +                 ;; Enable parallel execution.
> +                 (let ((parallel-job-spec
> +                        (string-append "-j" (number->string
> +                                             (min 4
> +                                                  (parallel-job-count))))))
> +                   (invoke "./x.py" parallel-job-spec "test" "-vv")
> +                   (invoke "./x.py" parallel-job-spec "test"
> +                           "src/tools/cargo")
> +                   (invoke "./x.py" parallel-job-spec "test"
> +                           "src/tools/rustfmt"))))

Nice!

> +      (outputs '("out" "doc" "cargo" "rustfmt"))

Perhaps we should make anything that can be installed as a rustup
component an output (provided the source is in the rust tree). I think
rls can be added immediately in the same fashion.

Do you want to add a copyright line?

Otherwise, this looks good to me.

Best regards,

John




  reply	other threads:[~2020-11-25 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 12:32 [bug#42295] [PATCH] gnu: rust-1.44: Add rustfmt output Matthew Kraai
2020-11-25 14:46 ` John Soo [this message]
2020-11-26 13:25   ` Matthew Kraai
2020-11-26 16:51     ` John Soo
2020-12-02 13:29       ` Matthew Kraai
2021-01-28 18:32         ` bug#42295: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blfltrxp.fsf@asu.edu \
    --to=jsoo1@asu.edu \
    --cc=42295@debbugs.gnu.org \
    --cc=kraai@ftbfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).