From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GGRxDeb14V8sBQAA0tVLHw (envelope-from ) for ; Tue, 22 Dec 2020 13:34:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iD1ACeb14V+JFQAAB5/wlQ (envelope-from ) for ; Tue, 22 Dec 2020 13:34:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 814779402A5 for ; Tue, 22 Dec 2020 13:34:29 +0000 (UTC) Received: from localhost ([::1]:46554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krho4-0003iP-32 for larch@yhetil.org; Tue, 22 Dec 2020 08:34:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krhne-0003ay-Qt for guix-patches@gnu.org; Tue, 22 Dec 2020 08:34:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krhne-00069R-J7 for guix-patches@gnu.org; Tue, 22 Dec 2020 08:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krhne-0004ZF-E8 for guix-patches@gnu.org; Tue, 22 Dec 2020 08:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45327] [PATCH] git: Periodically delete least-recently-used cached checkouts. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Dec 2020 13:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45327 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Received: via spool by 45327-submit@debbugs.gnu.org id=B45327.160864402817534 (code B ref 45327); Tue, 22 Dec 2020 13:34:02 +0000 Received: (at 45327) by debbugs.gnu.org; 22 Dec 2020 13:33:48 +0000 Received: from localhost ([127.0.0.1]:49224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krhnP-0004Yk-K8 for submit@debbugs.gnu.org; Tue, 22 Dec 2020 08:33:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krhnM-0004YU-TQ for 45327@debbugs.gnu.org; Tue, 22 Dec 2020 08:33:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58397) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krhnH-00063Z-Lf; Tue, 22 Dec 2020 08:33:39 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43826 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1krhnD-0007Hy-FD; Tue, 22 Dec 2020 08:33:36 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201219220630.24605-1-ludo@gnu.org> <86a6u7bgle.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 =?UTF-8?Q?Niv=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 22 Dec 2020 14:33:33 +0100 In-Reply-To: <86a6u7bgle.fsf@gmail.com> (zimoun's message of "Mon, 21 Dec 2020 11:26:05 +0100") Message-ID: <87blem2ceq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45327@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 814779402A5 X-Spam-Score: -2.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3sBsG222pS5t Hi, zimoun skribis: > On Sat, 19 Dec 2020 at 23:06, Ludovic Court=C3=A8s wrote: [...] >> I noticed that my ~/.cache/guix/checkouts directory had accumulated >> a lot of cruft from channels, playing with =E2=80=98--with-branch=E2=80= =99 and such, >> and that it would be nice to clean it up once in a while. >> >> This is what this patch does. It uses the (guix cache) default >> strategy, which consists in deleting least-recently-used items by >> looking at their atime. > > This is done at pull time, right? This is happens when =E2=80=98update-cached-checkout=E2=80=99 is called: wh= en updating a channel, using =E2=80=98--with-git-url=E2=80=99, etc. > Personally, I would prefer at gc time, and even maybe with an option > to =E2=80=9Cguix gc=E2=80=9D. Hmm yes (currently the two things are unrelated.) I have a slight preference for something automated that you don=E2=80=99t have to worry abo= ut. > Because, IIUC, every 5 days, the entries older than 1 month will be > deleted. Correct. > As an extensive user of the time-machine, it means that I will do this > extra work more than often, slowing down the already slow > =E2=80=9Ctime-machine=E2=80=9D. Let=E2=80=99s say there=E2=80=99s a couple of channels you regularly pull f= rom, like a few times per months. Their checkout would never be deleted so you wouldn=E2=80=99t notice any change in terms of performance. The difference you=E2=80=99d see is if you pull from a few channels, but le= ss than once per month. In that case, the =E2=80=98guix=E2=80=99 channel woul= d remain in cache (because cache cleanup happens after the cached checkout has been updated), but the other channels would be deleted just to be cloned again soon after that. Does that make sense? Thanks, Ludo=E2=80=99.