From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YAjCJsK6NGAkDwAA0tVLHw (envelope-from ) for ; Tue, 23 Feb 2021 08:20:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KGS7IcK6NGAXXgAAB5/wlQ (envelope-from ) for ; Tue, 23 Feb 2021 08:20:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ABE0CAE98 for ; Tue, 23 Feb 2021 09:20:13 +0100 (CET) Received: from localhost ([::1]:47832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lESvU-0007XF-QA for larch@yhetil.org; Tue, 23 Feb 2021 03:20:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lESvL-0007Vu-0Z for guix-patches@gnu.org; Tue, 23 Feb 2021 03:20:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lESvK-0001cz-Ln for guix-patches@gnu.org; Tue, 23 Feb 2021 03:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lESvK-000242-HN for guix-patches@gnu.org; Tue, 23 Feb 2021 03:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46564] [PATCH core-updates]: Use autoconf-wrapper instead of autoconf Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 Feb 2021 08:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46564 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 46564@debbugs.gnu.org Received: via spool by 46564-submit@debbugs.gnu.org id=B46564.16140683737877 (code B ref 46564); Tue, 23 Feb 2021 08:20:02 +0000 Received: (at 46564) by debbugs.gnu.org; 23 Feb 2021 08:19:33 +0000 Received: from localhost ([127.0.0.1]:58244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lESur-00022y-8F for submit@debbugs.gnu.org; Tue, 23 Feb 2021 03:19:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lESup-00022l-Gd for 46564@debbugs.gnu.org; Tue, 23 Feb 2021 03:19:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42293) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lESuj-0001Hi-Qo; Tue, 23 Feb 2021 03:19:26 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38614 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lESui-0006ox-E8; Tue, 23 Feb 2021 03:19:25 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87zh03dgty.fsf@telenet.be> <875z2lgjqg.fsf@gnu.org> <9e9ca439e3099b3e41b03b91b555b1b4000491d5.camel@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 =?UTF-8?Q?Vent=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 23 Feb 2021 09:19:22 +0100 In-Reply-To: <9e9ca439e3099b3e41b03b91b555b1b4000491d5.camel@telenet.be> (Maxime Devos's message of "Mon, 22 Feb 2021 18:23:32 +0100") Message-ID: <87blcb8ad1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.87 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: ABE0CAE98 X-Spam-Score: -2.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0g8l9wsK3UqC Hi Maxime, Maxime Devos skribis: >> There=E2=80=99s one exception I think: Automake. This one needs >> =E2=80=98autoconf-wrapper=E2=80=99 so it can actually run its test suite= . Perhaps >> Libtool too. > > Some other packages fail to build without autoconf-wrapper as well. > Some packages run './configure' from 'autogen.sh' or from the Makefile. Oh right. > I added a little explanation to each package that actually needs > autoconf-wrapper, and discouraged new uses of autoconf-wrapper with > a comment next to the definition of autoconf-wrapper. Great. > From d42be9473bac6b8bcfe17a37c92f2481cb2198fb Mon Sep 17 00:00:00 2001 > From: Maxime Devos > Date: Mon, 22 Feb 2021 16:43:10 +0100 > Subject: [PATCH] gnu: Use autoconf instead of autoconf-wrapper when possi= ble. > > This should reduce confusion on when to use the "autoconf" > package and when to use "autoconf-wrapper" instead in > package definitions. > > Fixes: > > * gnu/packages/autotools.scm (autoconf-wrapper): > advise to use the "autoconf" package instead where > possible. > * gnu/packages/game-development.scm (tsukundere)[native-inputs]: > use "autoconf" instead of "autoconf-wrapper". > * gnu/packages/gimp.scm > (glimpse)[native-inputs]: likewise. > (gimp-resynthesizer)[native-inputs]: add comment on why > "autoconf-wrapper" is used. > * gnu/packages/gnunet.scm (gnunet)[native-inputs]: > use "autoconf" instead of "autoconf-wrapper". > * gnu/packages/gnupg.scm (signing-party)[native-inputs]: > add comment on why "autoconf-wrapper" is used. > * gnu/packages/guile-xyz.scm > (guile-bash,guile-filesystem,guile-ics,guile-udev)[native-inputs]: > use "autoconf" instead of "autoconf-wrapper". > * gnu/packages/libevent.scm (libuv)[native-inputs]: indicates > "autoconf-wrapper" needs to be replaced with "autoconf" > on core-updates. > * gnu/packages/logging.scm (glog)[native-inputs]: use "autoconf" > instead of "autoconf-wrapper". > * gnu/packages/mail.scm (libetpan)[native-inputs]: likewise. > * gnu/packages/mate.scm > (mate-icon-theme-faenza)[native-inputs]: add comment on why > "autoconf-wrapper" is used. > (mate-screensaver)[native-inputs]: use "autoconf" instead of > "autoconf-wrapper". > * gnu/packages/package-management.scm (guix)[native-inputs]: likewise. > * gnu/packages/sawfish.scm (librep)[native-inputs]: likewise. > * gnu/packages/video.scm (motion)[native-inputs]: likewise. > * gnu/packages/zile.scm (zile)[native-inputs]: likewise. At first sight it should rebuild much so LGTM! Thanks, Ludo=E2=80=99.