unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#48158] [PATCH] gnu: xboard: Patch path to aplay.
@ 2021-05-02 11:46 Michael Rohleder
  2021-05-03 16:02 ` bug#48158: " Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Rohleder @ 2021-05-02 11:46 UTC (permalink / raw)
  To: 48158; +Cc: Michael Rohleder

Fixes <http://issues.guix.gnu.org/47195>.

* gnu/packages/games.scm (xboard): Patch path to aplay.
[inputs]: Add alsa-utils.
[arguments]: Add phase patch-aplay-path.
---
 gnu/packages/games.scm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 3227b3e6fc..8bd3c95ebb 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -3323,8 +3323,19 @@ exec ~a/bin/freedink -refdir ~a/share/dink\n"
         (base32
          "1mkh36xnnacnz9r00b5f9ld9309k32jv6mcavklbdnca8bl56bib"))))
     (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; Fixes https://issues.guix.gnu.org/47195.
+         (add-after 'unpack 'patch-aplay-path
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "xboard.conf"
+               (("aplay -q")
+                (string-append (assoc-ref inputs "alsa-utils") "/bin/aplay -q")))
+             #t)))))
     (inputs
-     `(("gtk+" ,gtk+-2)
+     `(("alsa-utils" ,alsa-utils)
+       ("gtk+" ,gtk+-2)
        ("librsvg" ,librsvg)))
     (native-inputs
      `(("texinfo" ,texinfo)
-- 
2.31.1





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#48158: [PATCH] gnu: xboard: Patch path to aplay.
  2021-05-02 11:46 [bug#48158] [PATCH] gnu: xboard: Patch path to aplay Michael Rohleder
@ 2021-05-03 16:02 ` Ludovic Courtès
  2021-05-03 16:13   ` [bug#48158] " Michael Rohleder
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2021-05-03 16:02 UTC (permalink / raw)
  To: Michael Rohleder; +Cc: 48158-done

Hi,

Michael Rohleder <mike@rohleder.de> skribis:

> Fixes <http://issues.guix.gnu.org/47195>.
>
> * gnu/packages/games.scm (xboard): Patch path to aplay.
> [inputs]: Add alsa-utils.
> [arguments]: Add phase patch-aplay-path.

Applied, thanks!

Incidentally, the following still breaks on the first move:

  $ guix environment --ad-hoc xboard -- xboard
  […]
  xboard: Error writing to first chess program: Broken pipe

At first sight the reason may be that it doesn’t find ‘fairymax’ (what’s
that?) in $PATH.  I’m sure I’m missing something obvious, but I wonder
if we could make it work out of the box.

Thoughts?

Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#48158] [PATCH] gnu: xboard: Patch path to aplay.
  2021-05-03 16:02 ` bug#48158: " Ludovic Courtès
@ 2021-05-03 16:13   ` Michael Rohleder
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Rohleder @ 2021-05-03 16:13 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 48158

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

Hi Ludo,

Thank you for reviewing!

Ludovic Courtès <ludo@gnu.org> writes:
> Incidentally, the following still breaks on the first move:
>
>   $ guix environment --ad-hoc xboard -- xboard
>   […]
>   xboard: Error writing to first chess program: Broken pipe
>
> At first sight the reason may be that it doesn’t find ‘fairymax’ (what’s
> that?) in $PATH.  I’m sure I’m missing something obvious, but I wonder
> if we could make it work out of the box.
>
> Thoughts?
>

Yes, I think that is https://issues.guix.gnu.org/45236

fairymax is a (simple) chessengine.

I plan to fix this issue (also via the xboard.conf), so that gnuchess
gets the default configured engine, after this one here is merged...

-- 
Wenn Du denkst, Abenteuer sind gefährlich, dann versuch´s doch mal mit Routine.
Die ist tödlich.    - Paulo Coelho

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-03 16:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-02 11:46 [bug#48158] [PATCH] gnu: xboard: Patch path to aplay Michael Rohleder
2021-05-03 16:02 ` bug#48158: " Ludovic Courtès
2021-05-03 16:13   ` [bug#48158] " Michael Rohleder

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git