unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Ryan Sundberg <ryan@arctype.co>
Cc: 48893@debbugs.gnu.org
Subject: [bug#48893] [PATCH] New package: ack
Date: Sun, 13 Jun 2021 22:46:49 +0200	[thread overview]
Message-ID: <87bl89ze4m.fsf_-_@gnu.org> (raw)
In-Reply-To: <f82c38c9-f1df-fad0-7034-f5fa17b9a37b@arctype.co> (Ryan Sundberg's message of "Wed, 9 Jun 2021 00:12:30 -0700")

Hi,

Ryan Sundberg <ryan@arctype.co> skribis:

> From fea54a57b5b4e1cdc6bd642ae499fbaafad5cb62 Mon Sep 17 00:00:00 2001
> From: Ryan Sundberg <ryan@arctype.co>
> Date: Sun, 31 Jan 2021 10:29:47 -0800
> Subject: [PATCH] gnu: Add ack version 3.5.0
>
> * gnu/packages/search.scm (ack): New variable.
>
> Signed-off-by: Ryan Sundberg <ryan@arctype.co>

Overall this LGTM.  However…

> +(define-public ack
> +  (package
> +    (name "ack")
> +    (version "3.5.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://beyondgrep.com/ack-v" version))
> +        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
> +    (inputs `(("perl" ,perl)))
> +    (build-system copy-build-system)

… I noticed this:

--8<---------------cut here---------------start------------->8---
$ head -4 $(./pre-inst-env guix build ack)/bin/ack
#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl
#
# This file, ack, is generated code.
# Please DO NOT EDIT or send patches for it.
--8<---------------cut here---------------end--------------->8---

Could you arrange so that the ‘ack’ file is “built from source”?
We usually try hard to build everything from source.

Thanks in advance,
Ludo’.




  reply	other threads:[~2021-06-13 20:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06 23:51 [bug#48893] [PATCH] New package: ack Ryan Sundberg via Guix-patches via
2021-06-06 23:58 ` Ryan Sundberg via Guix-patches via
2021-06-09  7:12   ` Ryan Sundberg via Guix-patches via
2021-06-13 20:46     ` Ludovic Courtès [this message]
2023-05-29 11:35     ` bug#48893: " Jelle Licht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl89ze4m.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=48893@debbugs.gnu.org \
    --cc=ryan@arctype.co \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).