From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MLDNM6+M22DYdwAAgWs5BA (envelope-from ) for ; Tue, 29 Jun 2021 23:12:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SMl4L6+M22BSNQAAbx9fmQ (envelope-from ) for ; Tue, 29 Jun 2021 21:12:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D676B348F5 for ; Tue, 29 Jun 2021 23:12:14 +0200 (CEST) Received: from localhost ([::1]:57508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyL1h-0008QA-FE for larch@yhetil.org; Tue, 29 Jun 2021 17:12:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyL1X-0008I8-Eq for guix-patches@gnu.org; Tue, 29 Jun 2021 17:12:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyL1X-0001RT-7c for guix-patches@gnu.org; Tue, 29 Jun 2021 17:12:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lyL1W-0002Pl-Vx for guix-patches@gnu.org; Tue, 29 Jun 2021 17:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48514] [PATCH] gnu: Add python-domain-connect-dyndns. Resent-From: Mekeor Melire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Jun 2021 21:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48514 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 48514@debbugs.gnu.org Received: via spool by 48514-submit@debbugs.gnu.org id=B48514.16250010829216 (code B ref 48514); Tue, 29 Jun 2021 21:12:02 +0000 Received: (at 48514) by debbugs.gnu.org; 29 Jun 2021 21:11:22 +0000 Received: from localhost ([127.0.0.1]:55786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyL0r-0002OV-Mh for submit@debbugs.gnu.org; Tue, 29 Jun 2021 17:11:22 -0400 Received: from mout01.posteo.de ([185.67.36.65]:47993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyKg3-0001qE-TK for 48514@debbugs.gnu.org; Tue, 29 Jun 2021 16:49:53 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7CB17240029 for <48514@debbugs.gnu.org>; Tue, 29 Jun 2021 22:49:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1624999785; bh=P15UJl8ghxvdlt3yPlvJ7KiJC7qREHj96y+ikKlEEIY=; h=From:To:Cc:Subject:Date:From; b=Lqe1R8WQz0PmhnhQD8p7QRyluj+SJWagnNHFTHhiYKGqo3TR6yiXarNq++EciFBRR OEhqlw3FV0eGrUxT/w21fEC1ymcnEAz33zwKJUtbYDNMLdPLmtyVtMHDGjubJNqeRR IInK0ygyL30S8ZKQqeacAuQrgNe8Qnrn4ZJiLUsVcvWRIDw858W74NPcxS/0IBj0k0 0VGKiOYwO0aS+LjKhVXIw22y1YMtCE4aEO4Tsld4SZauX4V+g66FYFJtXUbrII+lsd C/XibT9XuvRR7kknCBZIyaStoGdKQbKbyFeoqAK+lJ8DpiBTEIgZhSJ/dAkpksSbaQ cOgtPsq8iURgA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GDxRr2tZzz9rxF; Tue, 29 Jun 2021 22:49:44 +0200 (CEST) References: <87bl97lb2y.fsf@posteo.de> <87im39c39y.fsf@yoctocell.xyz> From: Mekeor Melire Date: Tue, 29 Jun 2021 20:43:22 +0000 In-reply-to: <87im39c39y.fsf@yoctocell.xyz> Message-ID: <87bl7otmzc.fsf@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 29 Jun 2021 17:11:19 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625001135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qBw5DgDl3cRNx4Ro/5pY11aGexg/T8I5G5/KfChYHlw=; b=jR3vL7cXujuvlnq4XINOvd8kKPXuPa6QKQR76iMfAqjj+RsDetl4dN8pvGuyG38d+cla1o WivwI8V2YWSNh8qqFBBmqu+KHyWbuE+ijpvK9yUDRjBk5zz0si1m7caWRQvIY/FhlTSlTn bgPGZ6BNzIeShAx7wySOxATF5VJ61KPlAlW+/k3EK2ERwRe1TKQHKEP1T8degEn24a0NNk oA650yIQ0GbGvziDB4krUKIJK/9awOKRu2xkSTFsmAqYRM3llQqddZJpxszLGpGY8NYKYg lVHArM8csqmP6nodzkASYVAwA+bRrh0bICM5kBCOfbmSkVkh5BYJo884fdwrWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625001135; a=rsa-sha256; cv=none; b=PGv20voD37wsN0xw4Z9NF/vbIL5Jv/ZKnd8Gb29vuhCf34/Iq+sGJkVyrycKMB595ncoiv sKXyjCqqYrTAXgNxwoIkPmepdPtB3MuUW+o1QvYTy+1opa9RCmmjULfyIvoknrPNAYOwaq TlxokaCHmUj2f5hirYnSdBHkYVVN9YMdXJ5CIYhnekz0kpC/99iUdB+Oi7B9qhTcudmO/h iftANd6iQ01iyyiLlVxblWH4bcLqyIqoarj7frpAdCkIcAiiTMSblIVADOPNVX9aIrb0Ys EBPhhJev8AoGBkKv0rhQ5InWKsfwiZ2tCjqxdkVNNDRFqsNxNYYQiGKCQzUsBA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.de header.s=2017 header.b=Lqe1R8WQ; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.de (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.de header.s=2017 header.b=Lqe1R8WQ; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.de (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D676B348F5 X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: pcdOFi0myB3b Hi and thank you for reviewing the patch! 2021-05-23 / 09:34 / public@yoctocell.xyz: > [[PGP Signed Part:Undecided]] > On Wed, May 19 2021, Mekeor Melire wrote: > >> From 488d77b3a6542598264ba964a723cf2c7d6e646f Mon Sep 17 00:00:00 2001 >> From: Mekeor Melire >> Date: Wed, 19 May 2021 03:45:08 +0200 >> Subject: [PATCH] gnu: Add python-domain-connect-dyndns. >> >> * gnu/packages/python-web.scm (python-publicsuffixlist, python-domain-co= nnect, >> python-domain-connect-dyndns): New variables. > > This should be split into three separate commits, you can use the > etc/committer.scm script to automatically create commits for unstaged > changes. > >> +(define-public python-publicsuffixlist >> + (package >> + (name "python-publicsuffixlist") >> + (version "0.7.7") >> + (home-page "https://github.com/ko-zu/psl") >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url home-page) >> + (commit "bff8d6a87b6bd3f6894e9211a9ee3c995ccfdcfc")= )) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "1nzvw6n702y1v1z5b62lv2rnlqjr3hjpal2750sg8s713fx= vxlzz")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:tests? #f)) > > What=E2=80=99s the reason for disabling the tests? I tried to get the tests working. But I'm not sure how to fix this error: "ImportError: Failed to import test module: domainconnect". The full logs are here: http://ix.io/3rvK It probably originates in this line: https://github.com/Domain-Connect/domainconnect_python/blob/d5a3a2935be36= a61985e0a86eab7e2a6098493d5/domainconnect/tests/test_domainConnect.py#L11 If I understand correctly, the package's tests try to import the package itself (which makes sense). I'm not sure why it does not work though. Any ideas? I will get the other change-requests done after fixing the tests. >> + (synopsis "Parse the Public Suffix List") >> + (description "Parse and use a given list of public suffix domains.") > > The description should contain one or more full sentences. > >> + (license license:mpl2.0))) >> + >> +(define-public python-domain-connect >> + (package >> + (name "python-domain-connect") >> + (version "0.0.9") >> + (home-page "https://github.com/Domain-Connect/domainconnect_python") >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url home-page) >> + (commit (string-append "v" version)))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "1xji0svamw961c7zgs1453cw2b9w94mk5qrfvqyb592l6yh= mmm62")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:tests? #f > > Same as above (why are tests disabled?). > >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'only-single-number-versions >> + (lambda _ >> + (substitute* '("setup.py" "requirements.txt") >> + (("(.*)([0-9]+)\\.[0-9]+\\.[0-9]+(.*)" all begin number = end) >> + (string-append begin number end "\n")))))))) > > Is the newline necessary? > >> + (propagated-inputs >> + `(("python-cffi" ,python-cffi) >> + ("python-cryptography" ,python-cryptography) >> + ("python-dnspython" ,python-dnspython) >> + ("python-future" ,python-future) >> + ("python-publicsuffix" ,python-publicsuffix) >> + ("python-publicsuffixlist" ,python-publicsuffixlist) >> + ("python-pycparser" ,python-pycparser) >> + ("python-six" ,python-six))) >> + (synopsis "Update DNS record of a domain per Domain Connect standar= d") >> + (description "This library provides \"Domain Connect\" for Python, = which >> +can be used to update DNS records of domains.") >> + (license license:expat))) >> + >> +(define-public python-domain-connect-dyndns >> + (package >> + (name "python-domain-connect-dyndns") >> + (version "0.0.9") >> + (home-page "https://github.com/Domain-Connect/DomainConnectDDNS-Pyt= hon") >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url home-page) >> + (commit (string-append "v" version)))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "024wxhfifl14j8s973lg6ls6s80grf9sm417kd2rpy1a90p89dnk")= ))) >> + (build-system python-build-system) >> + (arguments >> + `(#:tests? #f > > Same as the comment for python-domain-connect. > >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'only-single-number-versions >> + (lambda _ >> + (substitute* '("setup.py" "requirements.txt") >> + (("(.*)([0-9]+)\\.[0-9]+\\.[0-9]+(.*)" all begin number = end) >> + (string-append begin number end "\n")))))))) > > Same as the comment for python-domain-connect. > > otherwise LGTM! > > [[End of PGP Signed Part]]