From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CI9ELqzC3WCCKQAAgWs5BA (envelope-from ) for ; Thu, 01 Jul 2021 15:27:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EHvwKazC3WCrDQAAbx9fmQ (envelope-from ) for ; Thu, 01 Jul 2021 13:27:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D27D7116F5 for ; Thu, 1 Jul 2021 15:27:07 +0200 (CEST) Received: from localhost ([::1]:54518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lywig-0001qX-E4 for larch@yhetil.org; Thu, 01 Jul 2021 09:27:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lywic-0001q0-Mf for guix-patches@gnu.org; Thu, 01 Jul 2021 09:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lywic-0006V8-F8 for guix-patches@gnu.org; Thu, 01 Jul 2021 09:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lywic-0001P7-D3 for guix-patches@gnu.org; Thu, 01 Jul 2021 09:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49149] [PATCH 0/7] Add deb format for guix pack. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Jul 2021 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49149 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 49149@debbugs.gnu.org Received: via spool by 49149-submit@debbugs.gnu.org id=B49149.16251460145378 (code B ref 49149); Thu, 01 Jul 2021 13:27:02 +0000 Received: (at 49149) by debbugs.gnu.org; 1 Jul 2021 13:26:54 +0000 Received: from localhost ([127.0.0.1]:59962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lywiU-0001Ob-Hl for submit@debbugs.gnu.org; Thu, 01 Jul 2021 09:26:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lywiS-0001OH-UK for 49149@debbugs.gnu.org; Thu, 01 Jul 2021 09:26:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50958) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lywiN-0006GA-LG; Thu, 01 Jul 2021 09:26:47 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=36608 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lywiN-0005Gy-DV; Thu, 01 Jul 2021 09:26:47 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210624044049.17906-1-maxim.cournoyer@gmail.com> <20210624044049.17906-4-maxim.cournoyer@gmail.com> <87lf6roe32.fsf_-_@gnu.org> <8735sz42tc.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Messidor an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 01 Jul 2021 15:26:45 +0200 In-Reply-To: <8735sz42tc.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 30 Jun 2021 14:36:47 -0400") Message-ID: <87bl7mkvvu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625146027; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=GoBYewziOf353pKIhz4mm+2Dluj4Ip9TOHnuODkJpAE=; b=sQ6lSUWYP/E05z3QsRePJ2qB+E+0voCt/Vefe93thzaTX3jd9Oqe6w8pCNjRWinAnurFVO RfKEc2NewukE2cc1KGOV63Ehq9BzUVpKQNLjk5ZwbkjfxqOFXnsGj4bJ/5I8l1I2E8eOdg aJeUHUI2Xn2NK94YSa8n6bE+XpgEHjEXyhSkrF2pFrkiHWV+5JebznaoCqgK55biRbky/n QW4H9JPAvvb141LS3506MJC6FK+OE20mMvMYomJOdqiG/q28XpoiIKVYVYrs4UGFoLiSlv /RGaDsPXxa7qa2wZWHerEAOPYr+5KTCsQdImrXiUyYRp4i1ebvz7tTIfTuvAaQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625146027; a=rsa-sha256; cv=none; b=MktKWPBmbdgALG0A4K8GPhrmOt9iIWgv2392EDEEW+L/Ns2iRQUY6+A/0X93xQbLW62JJG C06+LqzC1OpcVrp+Ts9pc06C8JeVkv8IQQDJk8eJAtF8Q8nCBaX1Bq9mT7atpRO24OABwD OMxD/zaH7lYsE89pmQW39SVQtzHKn+8v+GyzxsweVqR8JL863TyNdpECRkFgTwjBCIlf8v iTXLeaivdObrgnQzSqXIw7E18TH4Q6L2nppjOm4nw3ApwQ5ogQKY14uEyIqxpkXigsCt+x Hjmztw8kCklqdPUkAR8siycVR1Bipg4lZUXxmblCxhezGxYsMfVLdvb6UVA5Tg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D27D7116F5 X-Spam-Score: -2.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: gBIqGXV0HGqZ Hi, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> Maxim Cournoyer skribis: >> >>> Instead of just naming them by their pack type, add information from the >>> package(s) they contain to make it easier to differentiate them. >>> >>> * guix/scripts/pack.scm (define-with-source): New macro. >>> (manifest->friendly-name): Extract procedure from ... >>> (docker-image): ... here, now defined via the above macro. Adjust REPO= SITORY >>> argument value accordingly. >>> (guix-pack): Derive NAME using MANIFEST->FRIENDLY-NAME. >> >> [...] >> >>> - (define tag >>> - ;; Compute a meaningful "repository" name, which will sh= ow up in >>> - ;; the output of "docker images". >>> - (let ((manifest (profile-manifest #$profile))) >>> - (let loop ((names (map manifest-entry-name >>> - (manifest-entries manifest)))) >>> - (define str (string-join names "-")) >>> - (if (< (string-length str) 40) >>> - str >>> - (match names >>> - ((_) str) >>> - ((names ... _) (loop names))))))) ;drop one en= try >> >> I think this should not be factorized because the requirements are very >> Docker-dependent. Once factorized, it becomes easy to overlook this. > > Hmm, I'm not a docker format expert, but my quick reading about it > turned no restrictions about what a docker image label should look like? > So perhaps it is not specially Docker-dependent. It=E2=80=99s a hack specifically written with Docker repository names in mi= nd, and the 40-or-so character limit, for instance. > If there's something truly Docker-dependent about it I'd suggest adding > a #:docker-compatible? boolean option to the procedure. To me it=E2=80=99s a case where factorization isn=E2=80=99t beneficial. Ev= en if there=E2=80=99s a similar procedure used in a different context, it=E2=80=99s still a diffe= rent context with different constraints. My 2=C2=A2! Ludo=E2=80=99.