From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EGQ+L3aA32DlWgAAgWs5BA (envelope-from ) for ; Fri, 02 Jul 2021 23:09:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gBvpKnaA32DNGAAAB5/wlQ (envelope-from ) for ; Fri, 02 Jul 2021 21:09:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1608412709 for ; Fri, 2 Jul 2021 23:09:10 +0200 (CEST) Received: from localhost ([::1]:33820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzQPN-0008FP-5h for larch@yhetil.org; Fri, 02 Jul 2021 17:09:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzQPH-0008F7-G0 for guix-patches@gnu.org; Fri, 02 Jul 2021 17:09:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzQPH-0007H8-8b for guix-patches@gnu.org; Fri, 02 Jul 2021 17:09:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lzQPH-0001rF-4y for guix-patches@gnu.org; Fri, 02 Jul 2021 17:09:03 -0400 Subject: bug#49227: [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 02 Jul 2021 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 49227 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 49227-done@debbugs.gnu.org Mail-Followup-To: 49227@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 49227-done@debbugs.gnu.org id=D49227.16252601267101 (code D ref 49227); Fri, 02 Jul 2021 21:09:02 +0000 Received: (at 49227-done) by debbugs.gnu.org; 2 Jul 2021 21:08:46 +0000 Received: from localhost ([127.0.0.1]:37223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzQP0-0001qT-9j for submit@debbugs.gnu.org; Fri, 02 Jul 2021 17:08:46 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:40779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzQOx-0001qC-Hh for 49227-done@debbugs.gnu.org; Fri, 02 Jul 2021 17:08:45 -0400 Received: by mail-qt1-f174.google.com with SMTP id n9so7632204qtk.7 for <49227-done@debbugs.gnu.org>; Fri, 02 Jul 2021 14:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pWMIMtmwXJoaCDL0J3hg+aM4LVjg15nVVzNu8Y6Q8Dw=; b=eTM7K1yICJaX4Y6BDM3gQZSLPf/E7vffHr7Ippyb0hJYI0deJdQeBUcTdXAKHgHKex uPf6kwQe2KMtT/TUPPA7I9hCmTSL1pcsKJzpCt8yTQI6sCzPXPYuJVQYoJrTqQYTG7kV WFq5/mURL52YKOd4pUHPhIg2yMhwtCI/GxAMZOqyt7gtr8hCJW0HjYJWcTZ769U53W2e peqvGiTZ1R4rux14c3PdEtirdvMN/8K8+zWsDs6NHDIEB2XA/hYufpdpu/8DuXe4O3KW z5ZoioL7Pk0BKpgzxApfeX8LmMo8uT1OgBnNyBHVft5s5enAJ+Y1LynHPSktLLxbjz6y ygbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pWMIMtmwXJoaCDL0J3hg+aM4LVjg15nVVzNu8Y6Q8Dw=; b=DqMU6G5oRkxp9SYMRhheV7AlyH6LEz5REol/Yo2rykQ+PhYFMEiclJE7EwSjc3ygYt rodBJlJgQk3x1IVlBZ0Vn6eMWBvUra5XWUQXxGAyQiy7sRa5lRefsCCcH+uQZcqxZjlo Tl8RbyOxefHls+7roeZ+keo2ghBsalViIfCJN2FRK7qgBLh2yHHdX5v7k/58TdCRjQDA 7kIIe2vFuPA87Azo5PjoJoq9Kmkb1oLbCeJ9W0rASkS1TKc0p9fOVuR5brFEglKIqwe/ EpdPcCHLPVHITs1w0gC9NIRR3rOG4hX3dI2o0lr+HUYe8CuxlJp6LeBjgDYHrsGGvQOI B5Pg== X-Gm-Message-State: AOAM530en9FNvTPTynSmB/0CXlexd/fzthYNZkVqYBCyP82jObDa8nL/ Zw+RxRqkcPJUUSpFTfXLUOkTFceU0oX92A== X-Google-Smtp-Source: ABdhPJzDAOkZsBwWVo4mGLeMvVYucI1Gl0Rejbp97RTiNpi5HdUWWKSJI2Cy9mgBgCHS/q7T0fghbA== X-Received: by 2002:ac8:7098:: with SMTP id y24mr1648564qto.309.1625260117952; Fri, 02 Jul 2021 14:08:37 -0700 (PDT) Received: from hurd (dsl-10-132-56.b2b2c.ca. [72.10.132.56]) by smtp.gmail.com with ESMTPSA id x24sm1632985qtj.94.2021.07.02.14.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 14:08:37 -0700 (PDT) From: Maxim Cournoyer References: <20210625180414.10045-1-maxim.cournoyer@gmail.com> <20210625180823.10382-1-maxim.cournoyer@gmail.com> Date: Fri, 02 Jul 2021 17:08:36 -0400 In-Reply-To: (Maxime Devos's message of "Sat, 26 Jun 2021 18:32:26 +0200") Message-ID: <87bl7k2zl7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625260150; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pWMIMtmwXJoaCDL0J3hg+aM4LVjg15nVVzNu8Y6Q8Dw=; b=uwfzfOPmZSZLARF0DWV2FCm5ycvFZKmZJPQDM6MMHb6t1S+eX7sKD16ZgmR6xOGeZIaSk+ n1liqyc3fwY0hW99s7LZoQ9WMLdSPMtbAbCy8Xqd0BhoICd7uND7nZArHQdrYf93hespvR aay5nYy8vC62NNhw3jfNeh6oCsKTJHM1R0/n6LMkRPPydGdgQlRYnTL2LiPRkVFGp3ae1W BktUmqu0OkSsqoWc9GMcLTZukuut7VeCq+0k48eq7a5/ietB6mY+0bbYnH/snVJYyxtyMX erivPqVq6KYzeGFTINODYt8VOETBGbKGznnZr5XFoXivQxjzD+WQCot9P0i9jA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625260150; a=rsa-sha256; cv=none; b=N6ZRdFWOclTVhZkUfYzcMLOkbv6u/I0GIEHd9p97hLLqiXuz2AreE6U2pgccKuv/hkj1Gq W2MRGuk0j0Y7QTejJ117r+WFNsrVFP0snzg4HzECVfjsP1JR4fAdpdXcKnxgLStqRSZZna P5TpAVWKsiriyscff9zYAOPUobRBZbnSQwa9IqhQcBvBi3ST2hTCmm7wG3fQkfjs+f/6Fd SNut6Muw1vH89tH/hvETKbhEt5Endu9TaSv6eHGfGx+rygxCw91snDSN/StQP3grPMsaAs fgMaEHg2nujdANdYI/uoJb6zd9NVs18bRzobHQ8+SWkM5Gyg5vGUp37bs5nYSw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=eTM7K1yI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=eTM7K1yI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1608412709 X-Spam-Score: -1.31 X-Migadu-Scanner: scn1.migadu.com X-TUID: SzIE/ocXD+dm Hi Maxime, Maxime Devos writes: > Maxim Cournoyer schreef op vr 25-06-2021 om 14:08 [-0400]: >> ;; These shall match the search-path-specification for Qt and KDE >> ;; libraries. >> - (list '("XDG_DATA_DIRS" directory "/share" >> + (list '("XDG_DATA_DIRS" suffix directory "/share" > > I'd recomend adding a comment here, explaining why 'suffix' is necessary > and '=' is unsufficient, with a link to the bug and patches tracker, > for clarity. I realized that there had already been the same fix on staging. I had to spend some time to manually resolve "conflicts" (which were not immediately apparent due to code having changed place on core-updates). The conflict cherry-picked from core-updates which ended up fixing this was 30759c4aadf279e470e8d7f94de332a31c1b9f42. I rebased the commits that had been pushed to master on that and a few related others, and pushed as d5c9cc6d9d979bfca5f035429bcf510a0a2285a3, which contains extra comments. Thank you! Maxim