unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 49227-done@debbugs.gnu.org
Subject: bug#49227: [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS.
Date: Fri, 02 Jul 2021 17:08:36 -0400	[thread overview]
Message-ID: <87bl7k2zl7.fsf@gmail.com> (raw)
In-Reply-To: <b9604603f40753e5054c82574ea1a95108297b01.camel@telenet.be> (Maxime Devos's message of "Sat, 26 Jun 2021 18:32:26 +0200")

Hi Maxime,

Maxime Devos <maximedevos@telenet.be> writes:

> Maxim Cournoyer schreef op vr 25-06-2021 om 14:08 [-0400]:
>>     ;; These shall match the search-path-specification for Qt and KDE
>>     ;; libraries.
>> -   (list '("XDG_DATA_DIRS" directory "/share"
>> +   (list '("XDG_DATA_DIRS" suffix directory "/share"
>
> I'd recomend adding a comment here, explaining why 'suffix' is necessary
> and '=' is unsufficient, with a link to the bug and patches tracker,
> for clarity.

I realized that there had already been the same fix on staging.  I had
to spend some time to manually resolve "conflicts" (which were not
immediately apparent due to code having changed place on core-updates).
The conflict cherry-picked from core-updates which ended up fixing this
was 30759c4aadf279e470e8d7f94de332a31c1b9f42.

I rebased the commits that had been pushed to master on that and a few
related others, and pushed as d5c9cc6d9d979bfca5f035429bcf510a0a2285a3,
which contains extra comments.

Thank you!

Maxim




      reply	other threads:[~2021-07-02 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 18:04 [bug#49227] [PATCH 0/3] Some Qt/qtbase improvements Maxim Cournoyer
2021-06-25 18:08 ` [bug#49227] [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS Maxim Cournoyer
2021-06-25 18:08   ` [bug#49227] [PATCH 2/3] gnu: qtbase: Enable GTK support Maxim Cournoyer
2021-06-25 18:08   ` [bug#49227] [PATCH 3/3] gnu: qtbase: Specify configure flags via the #:configure-flags argument Maxim Cournoyer
2021-06-26 16:32   ` [bug#49227] [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS Maxime Devos
2021-07-02 21:08     ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl7k2zl7.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=49227-done@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).