From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SHImCyMAv2FFxAAAgWs5BA (envelope-from ) for ; Sun, 19 Dec 2021 10:49:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GOgCByMAv2EbFwAA1q6Kng (envelope-from ) for ; Sun, 19 Dec 2021 09:49:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C4F1635FDA for ; Sun, 19 Dec 2021 10:49:22 +0100 (CET) Received: from localhost ([::1]:47302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mysoj-0007Lq-LG for larch@yhetil.org; Sun, 19 Dec 2021 04:49:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mysoQ-0007LV-OY for guix-patches@gnu.org; Sun, 19 Dec 2021 04:49:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mysoQ-0000qm-GC for guix-patches@gnu.org; Sun, 19 Dec 2021 04:49:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mysoQ-0003gw-F6 for guix-patches@gnu.org; Sun, 19 Dec 2021 04:49:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52472] [PATCH] gnu: Add libtree Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Dec 2021 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52472 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: poptsov.artyom@gmail.com (Artyom V. Poptsov) Cc: 52472@debbugs.gnu.org Received: via spool by 52472-submit@debbugs.gnu.org id=B52472.163990731814145 (code B ref 52472); Sun, 19 Dec 2021 09:49:02 +0000 Received: (at 52472) by debbugs.gnu.org; 19 Dec 2021 09:48:38 +0000 Received: from localhost ([127.0.0.1]:44825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myso2-0003g5-DM for submit@debbugs.gnu.org; Sun, 19 Dec 2021 04:48:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myso0-0003fp-9P for 52472@debbugs.gnu.org; Sun, 19 Dec 2021 04:48:36 -0500 Received: from [2001:470:142:3::e] (port=57334 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mysnu-0000oC-IY; Sun, 19 Dec 2021 04:48:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fevEJ+5Qm8ncODCpaTIjIjpWcvouUtcXBXoqaUuofaE=; b=hkUw44Ae5N8++sSgXTGy h3ud1zNAELniu0wIDfWRdFxPPvTuJ9Giw0H4Bf53qkitCN6WX6eDUi+sNWB1L3KmxomxGDqBih2bB +b2BuD0qSpnVf9Hq7VaL0DXR1g3F1qpXjWLnMn/hmiaxEM5myMnekxkvmWNN39T/xf8XrLpXCe4o2 uQf5NIcb2AoIm1yRCOC4ClHzl+kpK4fVw6O4BFsyH2hWsJd5tmJhW6uWVMms7o2ZvbEzhit8E3OMD pdxwMTSyS0g9p8KMTZ064TVTHAy7WMBEHedgfyaj1LOtmZOpDWTZQleCqk+wTCG0hKbtXizS9K6HI nP3k+BJENgKY8A==; Received: from [2a01:e0a:19b:d9a0:45b5:a14a:5c75:5737] (port=54124 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mysnu-00080b-Gm; Sun, 19 Dec 2021 04:48:30 -0500 From: Mathieu Othacehe References: <87fsqw5j9h.fsf@gmail.com> <87pmpu5oi8.fsf@gmail.com> Date: Sun, 19 Dec 2021 10:48:28 +0100 In-Reply-To: <87pmpu5oi8.fsf@gmail.com> (Artyom V. Poptsov's message of "Sat, 18 Dec 2021 11:02:55 +0300") Message-ID: <87bl1dsz6b.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639907362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fevEJ+5Qm8ncODCpaTIjIjpWcvouUtcXBXoqaUuofaE=; b=gyHHBtUeR2XxagQFmpYY9i1ZcSrxUNHCdYGo2ifQTQuMU6lhYRTyzOG2Gjn512cKECrcir RaMB1N2CvMCMkePRBdIrFV6Q5I8yk3DAR7CmQldgSEfxEr2P8dYAJuNEWiI0cUnPkSrhhP 098YlmfcLfm/foHE88pctY/aPtNAQk0LgO7iyH2QBI2x4fAN0nOSycSLqtxLpKdzEPMyRP 4sIWz+dAnNQeCHQ3Cbei1pnJDHoNrS7yZqEG2O/MJ8Jf1BpZmIJcjONtgIlGvF/HZLedOA ljAQbTvf87IonHhkY131+THxwbw7Rg3X3vDdxojuuZ5XSzH0Q3I0nqijiIFEyg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639907362; a=rsa-sha256; cv=none; b=ErjqNLrBcJVIep4MSwqLDx71oEBkITDteCsNAAvNAYOKY7QSzZ0rwnaidM4JqWfwIrVR++ Nu2GTgIfMQzm+hxWoh8RKlLhitvJB8k1tKv/GNyqubuokwm8c9WVTMpSbyh4fNJ2AsWwaZ l3mTkw04VMA65LYJSyJ/A0MclcVyKkE5LaR7pDT9skhKC25i0mnBAejX9kkhTmHvb3iory xiwi/qGsdzhcvWuB/C009U4l04ITW9L7um0gkI2j+Oh8l3dxkepEs2KxyJglohx9XGQ3N5 r4+dL6s1V6XsXwnvLMlCtUkMJZY+OGloYIz7Eh1lOOTcNuEcdJXelPm6AjoV9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=hkUw44Ae; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.71 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=hkUw44Ae; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C4F1635FDA X-Spam-Score: -4.71 X-Migadu-Scanner: scn0.migadu.com X-TUID: Y7hicO9+8sTC Hey Artyom, > ;;; Copyright =C2=A9 2021 Solene Rapenne > +;;; Copyright =C2=A9 2021 Artyom V. Poptsov > + No need for an extra new-line here. > + (lambda* (#:key outputs #:allow-other-keys) > + (substitute* "Makefile" > + (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)") > + (format #f "~a/bin/" (assoc-ref outputs "out"))) > + (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)") > + (format #f "~a/share/" (assoc-ref outputs "out")))))) You can now write: --8<---------------cut here---------------start------------->8--- ,#~(modify-phases %standard-phases (delete 'check) (delete 'configure) (add-before 'build 'patch (lambda* (#:key outputs #:allow-other-keys) (substitute* "Makefile" (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)") (string-append #$output "/bin/")) (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)") (string-append #$output "/share/"))))) --8<---------------cut here---------------end--------------->8--- > + (replace 'build > + (lambda _ > + (setenv "CC" "gcc") That would break cross-compilation. You should use something like: --8<---------------cut here---------------start------------->8--- (string-append "CC=3D" ,(cc-for-target)). --8<---------------cut here---------------end--------------->8--- > + (setenv "LDFLAGS" "-static") Why are we building a static version of the program? There's also this linter warning: gnu/packages/linux.scm:8649:14: libtree@3.0.1: synopsis should start with a= n upper-case letter or digit Thanks, Mathieu