unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 54368@debbugs.gnu.org
Subject: [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests.
Date: Fri, 18 Mar 2022 10:40:13 +0100	[thread overview]
Message-ID: <87bky38upu.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220313054356.17578-3-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sun, 13 Mar 2022 00:43:54 -0500")


Hello Maxim,

This looks great! I created a dedicated jobset here:
https://ci.guix.gnu.org/jobset/wip-btrfs-raid-tests to check everything
is still running fine.

> +OS to install TARGET-OS.  Return the VM disk images of TARGET-SIZE bytes
> +containing the installed system.  Unless providing OS, the PACKAGES will be
> +added to the packages defined in INSTALLATION-OS (from (gnu system install)).
> +NUMBER-OF-DISKS can be used to specify a number of disks different than one,
> +such as for RAID systems."

I'm having troubles understanding the "Unless providing OS" part of the
sentence, but that's also because this mechanism of adding packages to
the default OS definition is tricky.

Maybe we should augment the OS definition with those packages
unconditionally in the body of the "run-install" procedure.

Thanks,

Mathieu




  reply	other threads:[~2022-03-18  9:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-13  5:40 [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests Maxim Cournoyer
2022-03-13  5:43 ` [bug#54368] [PATCH 1/4] tests: install: Adjust the timeouts on two failing tests Maxim Cournoyer
2022-03-13  5:43   ` [bug#54368] [PATCH 2/4] tests: install: Streamline 'qemu-command/writable-image' Maxim Cournoyer
2022-03-13  5:43   ` [bug#54368] [PATCH 3/4] tests: install: Enable the use of multiple disk devices for tests Maxim Cournoyer
2022-03-18  9:40     ` Mathieu Othacehe [this message]
2022-03-18 13:28       ` [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests Maxim Cournoyer
2022-03-19 15:31       ` bug#54368: " Maxim Cournoyer
2022-03-18  9:41     ` [bug#54368] " Mathieu Othacehe
2022-03-18 13:31       ` Maxim Cournoyer
2022-03-18 15:26         ` Mathieu Othacehe
2022-03-13  5:43   ` [bug#54368] [PATCH 4/4] tests: install: Add two new Btrfs RAID10 install test Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bky38upu.fsf_-_@gnu.org \
    --to=othacehe@gnu.org \
    --cc=54368@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).