From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sDXZCejLtGKJiwAAbAwnHQ (envelope-from ) for ; Thu, 23 Jun 2022 22:24:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iP6ICejLtGIldQAAauVa8A (envelope-from ) for ; Thu, 23 Jun 2022 22:24:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CAA83148EB for ; Thu, 23 Jun 2022 22:24:07 +0200 (CEST) Received: from localhost ([::1]:52440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4TN1-0002CF-19 for larch@yhetil.org; Thu, 23 Jun 2022 16:24:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TMw-0002Be-Ph for guix-patches@gnu.org; Thu, 23 Jun 2022 16:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4TMw-0003nk-Hm for guix-patches@gnu.org; Thu, 23 Jun 2022 16:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4TMw-0005zV-Dt for guix-patches@gnu.org; Thu, 23 Jun 2022 16:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55964] [PATCH 2/9] gnu: Add node-yazl. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Jun 2022 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55964 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55964@debbugs.gnu.org Cc: Nicolas Graves X-Debbugs-Original-To: Nicolas Graves via Guix-patches via , 55964@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165601578622940 (code B ref -1); Thu, 23 Jun 2022 20:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2022 20:23:06 +0000 Received: from localhost ([127.0.0.1]:40016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TM1-0005xq-Iu for submit@debbugs.gnu.org; Thu, 23 Jun 2022 16:23:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:59804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TLw-0005x0-OW for submit@debbugs.gnu.org; Thu, 23 Jun 2022 16:23:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TLw-00021m-Hj for guix-patches@gnu.org; Thu, 23 Jun 2022 16:23:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TLv-0003ip-PI; Thu, 23 Jun 2022 16:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=QyWjoKHJX7qy1m2EAgcG5hGu+SNHQ7iCWO6I2qJOW3Y=; b=DvBSK3GfT50s+KFzFxu2 3V6btTkCbYmFz7bU73TSrnd+PrzwSpgZmrkKKRsYkaRWDl63No5gHTmQY9a1CQh8r90Wz4ICRzMNH AWtQ/pBfD5GNbp0AeC2F93EVrNScObMQIY749XUjCmfR8vMpelgS3m3zWozZ0zPqTMhkX8Mz9R9y6 bPcou040JjZ+PlOyHJm/w3DNF1qAjsfdogmJTT98ckzZyYZTakJK6MbuQqEWya1UkzNebq0P8T5+I cBaDdnsSeibodKA+fxq7rG8pOj7snkkLGHE5uT5gGpotRDQJBi9JUF/xGAKxtd1YUxyJDv3I43oVH o64ysURPty0DAQ==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:33108 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TLv-0000i6-CC; Thu, 23 Jun 2022 16:22:59 -0400 From: Marius Bakke In-Reply-To: <20220614094954.15197-2-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> <20220614094954.15197-2-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 22:22:56 +0200 Message-ID: <87bkujruxr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656015847; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=QyWjoKHJX7qy1m2EAgcG5hGu+SNHQ7iCWO6I2qJOW3Y=; b=pxKFxbogP9hcmdC2pwwHz2T8XJ42oH4JkXO6h7GcKqBz9FVLrprBjM/XQDm9N3RoIJGen1 0w7Zjek6NZ/z1JLgOJMaToyNEAYH7oWMgnD39CfIxF7gTWWudJyoD1WwAecWlN66Ye+ifl 9slDRMFTNo4QVLIOS2mESC7oq/vS8pPoEoFpVQWdE2Lf9PBrCBjdhskJeryOqW+mbW004l Uf0MufMCdJh/3tT0bHK0n2lRIvqDrp2S1AgTmsjhsYhBP3bmFYJZalh6rPQUPR3OCTbn28 lzNdA9ZaioZLpqNeRO4KQSbhJEs+g71A+z2wvKanoCpvZ4q0hUhu4QKiImT9NQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656015847; a=rsa-sha256; cv=none; b=OhLG5RsDYwEZgYBYHbCqOedsJf08EDP9BgTSDYRD30QzH/g60Sid721O2c/9Y/NTbcelJ2 UjFsBUiycMZkRneynZohFYym6GRH93Rh5XHLJfCwsMblImXV9AbfUBl401/sra8NPmH1NK h6RgDAv4acSd/Sp6lY+a3vBLonSqpSmvftir+fD/ks7VTgU8svZLTdnVzGQChfOaXbR7hq GYVcbzwZ1WozYkLm88YQmKavCbS8bg1nSea7oYxpi3VcoZFJ3WG+ucdLEuTGpro5i85jR2 /2kiNrriw5F6FWP2cvxSJ7EyftZ/PVySmhqEekGW4sDkzI1oPgspkK1ugT5UWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=DvBSK3Gf; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=DvBSK3Gf; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CAA83148EB X-Spam-Score: -5.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: v8e6C3SQkCdH --=-=-= Content-Type: text/plain Nicolas Graves via Guix-patches via skriver: > * gnu/packages/node-xyz.scm (node-yazl): New variable. [...] > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/thejoshwolfe/yazl") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1lhwqqnvazpi4xw81ldpx0ky0h1j5rcx3br480q2bnzj21cm109n")))) Indentation seems off here ('./pre-inst-env guix style node-yazl' can take care of it if you don't use Emacs). > + (build-system node-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'check) > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") > + "--offline" "--ignore-scripts" "install" "--production") > + #t))))) Same comments as previous patch. > + (inputs (list node-buffer-crc32)) > + (home-page "https://github.com/thejoshwolfe/yazl") > + (synopsis "Yet another zip library for node") > + (description "This package provides a zip library for Node. It follows the following principles: Keep lines < 78 characters if possible. Also use two spaces after punctuation. './pre-inst-env guix lint PACKAGE' will warn about this and save review time. ;-) > +Don't block the JavaScript thread. Use and provide async APIs. > +Keep memory usage under control. Don't attempt to buffer entire files in RAM at once. > +Prefer to open input files one at a time than all at once. ") Use @enumerate for "bullet lists" which this seems to be. Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTLoA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHc7GwD8Dccxstz8chniSO1xghiUjwx/LZL2W8+jKJbp A708fJ4BALYjbQn9JFPg5w+TQy/dUrFuqtt5kX1a7xwOnM8wK4YD =4ene -----END PGP SIGNATURE----- --=-=-=--