Nicolas Graves via Guix-patches via skriver: > * gnu/packages/node-xyz.scm (node-yazl): New variable. [...] > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/thejoshwolfe/yazl") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1lhwqqnvazpi4xw81ldpx0ky0h1j5rcx3br480q2bnzj21cm109n")))) Indentation seems off here ('./pre-inst-env guix style node-yazl' can take care of it if you don't use Emacs). > + (build-system node-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'check) > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") > + "--offline" "--ignore-scripts" "install" "--production") > + #t))))) Same comments as previous patch. > + (inputs (list node-buffer-crc32)) > + (home-page "https://github.com/thejoshwolfe/yazl") > + (synopsis "Yet another zip library for node") > + (description "This package provides a zip library for Node. It follows the following principles: Keep lines < 78 characters if possible. Also use two spaces after punctuation. './pre-inst-env guix lint PACKAGE' will warn about this and save review time. ;-) > +Don't block the JavaScript thread. Use and provide async APIs. > +Keep memory usage under control. Don't attempt to buffer entire files in RAM at once. > +Prefer to open input files one at a time than all at once. ") Use @enumerate for "bullet lists" which this seems to be. Otherwise LGTM.