From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Baptiste Strazzulla <bstrazzull@hotmail.fr>
Cc: 57088-done@debbugs.gnu.org
Subject: bug#57088: [PATCH] Add emacs-blight and emacs-lemon
Date: Fri, 26 Aug 2022 10:29:08 +0200 [thread overview]
Message-ID: <87bks7qugb.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <AS8P189MB2024CC1933A394084A837AA0B9629@AS8P189MB2024.EURP189.PROD.OUTLOOK.COM> (Baptiste Strazzulla's message of "Tue, 9 Aug 2022 18:57:04 +0000")
Hello,
Baptiste Strazzulla <bstrazzull@hotmail.fr> writes:
> Subject: [PATCH 1/2] gnu: Add emacs-blight
Applied with the following changes. Thank you.
> +(define-public emacs-blight
> + (let ((commit "6bf9c6192d")
Changed to a full hash.
> + (revision "0"))
> + (package
> + (name "emacs-blight")
> + (version (git-version "1.0.0" revision commit))
AFAICT, there is no mention of a version number whatsoever across the
code base. I set the base version to 0 instead.
> + (description
> + "@code{blight} allows you to control display brightness from Emacs. It
> +features object-oriented code using EIEIO, a base class implementing a
> +reasonable API which focuses on the extremely basic \"set the back light to
> +this percentage\" functionality instead of advanced tightly-coupled frippery,
> +it includes a concrete implementation that uses SysFS to control brightness.
> +Other systems (D-Bus, macOS, Windows, xbacklight, XELB using XRandR) are
> +easily supportable, giving the same experience across environments. It has a
> +500% snappier name than any other backlight tool for Emacs.")
I trimmed down the description a bit.
> +(define-public emacs-lemon
> + (let ((commit "37a6e6d6ef")
Same as above.
> + (native-inputs
> + (list emacs-emms emacs-blight))
I re-ordered inputs alphabetically.
> + (description
> + "@code{lemon} is a tiny system monitor which displays system information
> +in the echo area when Emacs is has been idle for a few seconds. This is a
> +fork of zk_phi’s Symon, which has been largely rewritten. It fixes a number of
> +bugs and shortcomings and emphasizes customizability and code reuse, but also
> +drops support for non-Linux platforms. It works nicely with EXWM.")
I removed the penultimate sentence, which is not useful in our case.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2022-08-26 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 18:57 [bug#57088] [PATCH] Add emacs-blight and emacs-lemon Baptiste Strazzulla
2022-08-26 8:29 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bks7qugb.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=57088-done@debbugs.gnu.org \
--cc=bstrazzull@hotmail.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).