From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EMBfIA0TM2PlPgAAbAwnHQ (envelope-from ) for ; Tue, 27 Sep 2022 17:13:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UBmGHw0TM2OpNAAAG6o9tA (envelope-from ) for ; Tue, 27 Sep 2022 17:13:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E72FC2D1D6 for ; Tue, 27 Sep 2022 17:13:16 +0200 (CEST) Received: from localhost ([::1]:54716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odCGp-0003nb-L0 for larch@yhetil.org; Tue, 27 Sep 2022 11:13:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odAjl-000743-KS for guix-patches@gnu.org; Tue, 27 Sep 2022 09:35:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odAjl-0007Xn-Bc for guix-patches@gnu.org; Tue, 27 Sep 2022 09:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odAjk-00050r-SJ for guix-patches@gnu.org; Tue, 27 Sep 2022 09:35:00 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57927] [PATCH] gnu: source-highlight: Fix lesspipe file name and use gexps. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Sep 2022 13:35:00 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57927 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: kiasoc5 Cc: 57927@debbugs.gnu.org Received: via spool by 57927-submit@debbugs.gnu.org id=B57927.166428568319231 (code B ref 57927); Tue, 27 Sep 2022 13:35:00 +0000 Received: (at 57927) by debbugs.gnu.org; 27 Sep 2022 13:34:43 +0000 Received: from localhost ([127.0.0.1]:53427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odAjS-000506-Ro for submit@debbugs.gnu.org; Tue, 27 Sep 2022 09:34:43 -0400 Received: from tobias.gr ([80.241.217.52]:34136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odAjQ-0004zr-Hx for 57927@debbugs.gnu.org; Tue, 27 Sep 2022 09:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=7LAjBPABr94t6 RuVMGFxKDNzcPKBym5jhQp8SBg5Ssk=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=Oy4hoHsYPH639nmtL3d2ODfRT/jVYrYBRbIREg mRssuRH/edyo7lJ4pDhYmVegDXbBMkRptS2nuMs/C8FfJ6Y5OvNDLLcKOtTUVt1ZeluS5Z MZSxyH2WEgg8jut2gg1y7GvZOf9GFwwCMnT1DcSlP27PgwRg7GW1h4+Ca8uDRyp8NVVhpZ HFp6MhTOKpJGh94tquchvNwXfG3dDkKriK5lTo362DdI75W4MN4CUERpKHFuvPY4sAs4Cm 8jNI2o75IcvjgEenIieIYOPyXcggfLimdQdIZ25ztIWDAwUjeyM4q2AYY5XF6yqS21ojMg 0YTtVDjO8uB96LAa15krl6Ew== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id db537ef5 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 27 Sep 2022 13:34:33 +0000 (UTC) References: <29d55f693128126558e2e3e0a030194453312187.1663570649.git.kiasoc5@disroot.org> Date: Tue, 27 Sep 2022 15:22:19 +0200 In-reply-to: <29d55f693128126558e2e3e0a030194453312187.1663570649.git.kiasoc5@disroot.org> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87bkr1ey8x.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664291597; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7LAjBPABr94t6RuVMGFxKDNzcPKBym5jhQp8SBg5Ssk=; b=mZlWWO4D0zH4qxUgJhQPWmcw5oKZWR0BHas9MXdul6R2UPEf437aoUjgIxDlyhN/7Y8+WV 8B+OUD1InH/PCh5DTrgRwII8zCLsnNoVaHym/tWeDMSolazGtlT59HuXFNN/Rf9bUsYEp1 AnKae1iVL9lu1qFodPDYYWdJFpYj1IY9kbsRrtzPADqAs0O8w/+sHXkER0xGdDMUW+08Dc Ck/5UmcAi8Rtj14L0Va0qWV94abaPoC43U1QSpxxbKEWoNpTrZZhLughUkFPX7454JsRN2 7ruz9pnLQ6XgLRP6EZERFEY8QCW6dIhhP5tf2HjqvyvS0pnzsa/YsMaR5rfNPg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664291597; a=rsa-sha256; cv=none; b=EVvp7VCK4+1FwO9koHFXtaZGg/GiFBRvIfx7rFN3MCA+ZnzkhpCRWctye66PCXA1wd/Iv2 644hitbfyAHEx/a/UZG03p/i1e7iroWyUhTdJHtH4MLY2luKEgxBiW/ojI3aBWv3xcq4Kh xRBmGZeGZ5H7uR2uPSSjdRjwzQX9DXDTKfBDBeCLZWEgZu6T00NJLaPmqxQ4vocnO+pPdR HNtCSMkwh9Dngo5vGB8f/vTmG5S67lfonO20smN2jXLg21Fw0pwbnKCIXjeHSZUpgsUmiv SVflR5M8M9G7SNZFGe8P4ycIwD+OZwtzhervFQypo1k00BXpdCZE+EHGCS/LBg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=Oy4hoHsY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=Oy4hoHsY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E72FC2D1D6 X-Spam-Score: -3.44 X-Migadu-Scanner: scn1.migadu.com X-TUID: iBgvjExNllbt --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi kiasoc5, kiasoc5 via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > This fixes src-hilite-lesspipe.sh so that lesspipe.sh is called=20 > instead of lesspipe. Thanks! I reverted this change on master. It caused over 4000=20 rebuilds (per architecture), which means it's core-updates=20 material. You can test this yourself by running =E2=80=98guix refresh -l=20 source-highlight=E2=80=99. It's not perfect: it can fail to detect some=20 paths, especially when inheritance is involved. But it's a good=20 sanity check. When you notice a rebuild count higher than the thresholds given=20 here[0], please add a =E2=80=98[PATCH core-updates]=E2=80=99 or =E2=80=98[P= ATCH staging]=E2=80=99=20 warning to your patch subject. It reduces the chance of these=20 slipping through. > * gnu/packages/pretty-print.scm (source-highlight): > [arguments]: Use gexps, remove trailing #ts. > [phases]: Add phase to make src-highlight-lesspipe.sh work. These unrelated changes should be separated into at least two=20 patches next time: one to gexp and remove the #ts, the other to=20 make the functional change. =E2=80=98At least=E2=80=99, because Gexpification often leaves the output h= ash=20 unchanged, so a separate gexp patch might have been able to go=20 straight to master. > + (arguments=20=20=20 This introduced a whitespace error: there are extra trailing=20 spaces. Git should highlight these when showing the diff. I=20 removed them. Kind regards, T G-R [0]: https://guix.gnu.org/manual/en/guix.html#Submitting-Patches --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYzL8Hw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15Hk8BAIhX/toTe0VN9rKtBgilHq1O92C2catpmlYdvRbq hjwpAQCnKiUPahy4P94xg3EpYpdsQya31Bz7j6uZq2YfkhXCAQ== =H94z -----END PGP SIGNATURE----- --=-=-=--