unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 58488-done@debbugs.gnu.org
Subject: bug#58488: [PATCH] gnu: gnome: Include aarch64 in librsvg-for-system.
Date: Thu, 03 Nov 2022 17:46:16 +0100	[thread overview]
Message-ID: <87bkpom1ed.fsf@cbaines.net> (raw)
In-Reply-To: <874jvgoxxw.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Christopher Baines <mail@cbaines.net> skribis:
>
>> Since the staging merge, librsvg has been buildable for aarch64.
>>
>> * gnu/packages/gnome.scm (librsvg-for-system): Use librsvg for aarch64.
>> ---
>>  gnu/packages/gnome.scm | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 09a991b14c..ff9d95c244 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -3753,8 +3753,10 @@ (define* (librsvg-for-system #:optional
>>                               (system (or (%current-target-system)
>>                                           (%current-system))))
>>    ;; Since librsvg 2.50 depends on Rust, and Rust is only correctly supported
>> -  ;; on x86_64 so far, use the ancient C version on other platforms (FIXME).
>> -  (if (string-prefix? "x86_64-" system)
>> +  ;; on x86_64 and aarch64 so far, use the ancient C version on other
>> +  ;; platforms (FIXME).
>> +  (if (or (string-prefix? "x86_64-" system)
>> +          (string-prefix? "aarch64-" system))
>
> With <https://issues.guix.gnu.org/58661> now fixed, I think you can go
> ahead and push this one, no?

Indeed, thanks for the reminder, I've pushed to master as
754f260753fb6ebe28325616bc08336a184e4621.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2022-11-03 16:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13 10:20 [bug#58488] [PATCH] gnu: gnome: Include aarch64 in librsvg-for-system Christopher Baines
2022-10-23 13:10 ` Ludovic Courtès
2022-11-03 15:32 ` Ludovic Courtès
2022-11-03 16:46   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkpom1ed.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=58488-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).